| Message ID | 20230112102644.27830-6-Jonathan.Cameron@huawei.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | hw/cxl: CXL emulation cleanups and minor fixes for upstream | expand |
On Thu, Jan 12, 2023 at 10:26:41AM +0000, Jonathan Cameron wrote: > Noticed as this prevents iASL disasembling the DSDT table. > > Reviewed-by: Ira Weiny <ira.weiny@intel.com> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> This needed but it looks like you did not bother updating expected files for the tests. Did you run make check? > --- > hw/i386/acpi-build.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 127c4e2d50..a584b62ae2 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -1482,7 +1482,6 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, > aml_append(pkg, aml_eisaid("PNP0A03")); > aml_append(dev, aml_name_decl("_CID", pkg)); > aml_append(dev, aml_name_decl("_ADR", aml_int(0))); > - aml_append(dev, aml_name_decl("_UID", aml_int(bus_num))); > build_cxl_osc_method(dev); > } else if (pci_bus_is_express(bus)) { > aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0A08"))); > -- > 2.37.2
On Fri, 27 Jan 2023 21:38:20 -0500 "Michael S. Tsirkin" <mst@redhat.com> wrote: > On Thu, Jan 12, 2023 at 10:26:41AM +0000, Jonathan Cameron wrote: > > Noticed as this prevents iASL disasembling the DSDT table. > > > > Reviewed-by: Ira Weiny <ira.weiny@intel.com> > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > This needed but it looks like you did not bother updating > expected files for the tests. Did you run make check? Sorry, that was sloppy of me. v3 with table update dance for q35/DSDT.cxl sent out. (I failed to send this email yesterday). > > > --- > > hw/i386/acpi-build.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > > index 127c4e2d50..a584b62ae2 100644 > > --- a/hw/i386/acpi-build.c > > +++ b/hw/i386/acpi-build.c > > @@ -1482,7 +1482,6 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, > > aml_append(pkg, aml_eisaid("PNP0A03")); > > aml_append(dev, aml_name_decl("_CID", pkg)); > > aml_append(dev, aml_name_decl("_ADR", aml_int(0))); > > - aml_append(dev, aml_name_decl("_UID", aml_int(bus_num))); > > build_cxl_osc_method(dev); > > } else if (pci_bus_is_express(bus)) { > > aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0A08"))); > > -- > > 2.37.2 >
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 127c4e2d50..a584b62ae2 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -1482,7 +1482,6 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, aml_append(pkg, aml_eisaid("PNP0A03")); aml_append(dev, aml_name_decl("_CID", pkg)); aml_append(dev, aml_name_decl("_ADR", aml_int(0))); - aml_append(dev, aml_name_decl("_UID", aml_int(bus_num))); build_cxl_osc_method(dev); } else if (pci_bus_is_express(bus)) { aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0A08")));