| Message ID | 20230119171809.1406-2-shiju.jose@huawei.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | rasdaemon: Add support for the CXL error events | expand |
On Thu, 19 Jan 2023 17:18:06 +0000 <shiju.jose@huawei.com> wrote: > From: Shiju Jose <shiju.jose@huawei.com> > > Move definition for BIT() and BIT_ULL() to the > common file ras-record.h > > Signed-off-by: Shiju Jose <shiju.jose@huawei.com> Hi Shiju, As you know I've looked at and tested this before you posted it so I'm happy with it, except mostly places where I think there is room to improve ras daemon in general ;) This patch makes sense though I suspect it will one day get moved again to an even more generic header. Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huwei.com> Thanks Jonathan > --- > ras-non-standard-handler.h | 3 --- > ras-record.h | 3 +++ > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/ras-non-standard-handler.h b/ras-non-standard-handler.h > index 57d4cb5..393b756 100644 > --- a/ras-non-standard-handler.h > +++ b/ras-non-standard-handler.h > @@ -17,9 +17,6 @@ > #include "ras-events.h" > #include "libtrace/event-parse.h" > > -#define BIT(nr) (1UL << (nr)) > -#define BIT_ULL(nr) (1ULL << (nr)) > - > struct ras_ns_ev_decoder { > struct ras_ns_ev_decoder *next; > const char *sec_type; > diff --git a/ras-record.h b/ras-record.h > index d9f7733..219f10b 100644 > --- a/ras-record.h > +++ b/ras-record.h > @@ -25,6 +25,9 @@ > > #define ARRAY_SIZE(x) (sizeof(x)/sizeof(*(x))) > > +#define BIT(nr) (1UL << (nr)) > +#define BIT_ULL(nr) (1ULL << (nr)) > + > extern long user_hz; > > struct ras_events;
diff --git a/ras-non-standard-handler.h b/ras-non-standard-handler.h index 57d4cb5..393b756 100644 --- a/ras-non-standard-handler.h +++ b/ras-non-standard-handler.h @@ -17,9 +17,6 @@ #include "ras-events.h" #include "libtrace/event-parse.h" -#define BIT(nr) (1UL << (nr)) -#define BIT_ULL(nr) (1ULL << (nr)) - struct ras_ns_ev_decoder { struct ras_ns_ev_decoder *next; const char *sec_type; diff --git a/ras-record.h b/ras-record.h index d9f7733..219f10b 100644 --- a/ras-record.h +++ b/ras-record.h @@ -25,6 +25,9 @@ #define ARRAY_SIZE(x) (sizeof(x)/sizeof(*(x))) +#define BIT(nr) (1UL << (nr)) +#define BIT_ULL(nr) (1ULL << (nr)) + extern long user_hz; struct ras_events;