diff mbox series

[v3] tools/testing/cxl: Remove cxl_test module math loading message

Message ID 20230126170555.701240-1-alison.schofield@intel.com
State Accepted
Commit 66f3cb7993c2729b72e20313f8dc6e0716416186
Headers show
Series [v3] tools/testing/cxl: Remove cxl_test module math loading message | expand

Commit Message

Alison Schofield Jan. 26, 2023, 5:05 p.m. UTC 
From: Alison Schofield <alison.schofield@intel.com>

Commit "tools/testing/cxl: Add XOR Math support to cxl_test" added
a module parameter to cxl_test for the interleave_arithmetic option.

In doing so, it also added this dev_dbg() message describing which
option cxl_test used during load:
"[  111.743246] (NULL device *): cxl_test loading modulo math option"
That "(NULL device *)" has raised needless user concern.

Remove the dev_dbg() message and make the module_param readable via
sysfs for users that need to know which math option is active.

Fixes: Fixes: 7a7e6edfca85 ("tools/testing/cxl: Add XOR Math support to cxl_test")
Suggested-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Alison Schofield <alison.schofield@intel.com>
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
---

Changes in v3:
- New base commit 6.2-rc5.  Suggest for 6.3, not a 6.2 fix.
- Update Commit log: explain why permission change is needed (DaveJ)
- Add Vishal's Reviewed-by Tag (Vishal)
- No change in code

Changes in v2:
- Use correct Fixes Tag in commit log. (Ira)
- Param always appears in sysfs. Don't say otherwise in commit log. (Ira)
- Commit msg: s/modulo/module, s/messages/message
- No change in code

 tools/testing/cxl/test/cxl.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)


base-commit: 2241ab53cbb5cdb08a6b2d4688feb13971058f65

Comments

Dan Williams Jan. 26, 2023, 11:53 p.m. UTC | #1 
alison.schofield@ wrote:
> From: Alison Schofield <alison.schofield@intel.com>
> 
> Commit "tools/testing/cxl: Add XOR Math support to cxl_test" added
> a module parameter to cxl_test for the interleave_arithmetic option.
> 
> In doing so, it also added this dev_dbg() message describing which
> option cxl_test used during load:
> "[  111.743246] (NULL device *): cxl_test loading modulo math option"
> That "(NULL device *)" has raised needless user concern.
> 
> Remove the dev_dbg() message and make the module_param readable via
> sysfs for users that need to know which math option is active.
> 
> Fixes: Fixes: 7a7e6edfca85 ("tools/testing/cxl: Add XOR Math support to cxl_test")

Well, no need for 'Fixes:' since the previous state was just a cosmetic
annoyance, but certainly no need for double 'Fixes:'.

> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>
> Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>

Otherwise, looks good to me, applied with the above fixup.
diff mbox series

Patch

diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
index 30ee680d38ff..ede84de69f59 100644
--- a/tools/testing/cxl/test/cxl.c
+++ b/tools/testing/cxl/test/cxl.c
@@ -1135,11 +1135,9 @@  static __init int cxl_test_init(void)
 	if (interleave_arithmetic == 1) {
 		cfmws_start = CFMWS_XOR_ARRAY_START;
 		cfmws_end = CFMWS_XOR_ARRAY_END;
-		dev_dbg(NULL, "cxl_test loading xor math option\n");
 	} else {
 		cfmws_start = CFMWS_MOD_ARRAY_START;
 		cfmws_end = CFMWS_MOD_ARRAY_END;
-		dev_dbg(NULL, "cxl_test loading modulo math option\n");
 	}
 
 	rc = populate_cedt();
@@ -1326,7 +1324,7 @@  static __exit void cxl_test_exit(void)
 	unregister_cxl_mock_ops(&cxl_mock_ops);
 }
 
-module_param(interleave_arithmetic, int, 0000);
+module_param(interleave_arithmetic, int, 0444);
 MODULE_PARM_DESC(interleave_arithmetic, "Modulo:0, XOR:1");
 module_init(cxl_test_init);
 module_exit(cxl_test_exit);