| Message ID | 20230726073421.2452-2-raghuhack78@gmail.com |
|---|---|
| State | Accepted |
| Commit | e6ee120397fc3c49bcf6133f149a6d91497e53b7 |
| Headers | show |
| Series | Fixing check patch styling issues | expand |
On Wed, Jul 26, 2023 at 07:34:20AM +0000, Raghu Halharvi wrote: > Issue found with checkpatch > > A return of errno should be good enough if the memory allocation fails, > the error message here is redundant as per the coding style, removing > it. > > Signed-off-by: Raghu Halharvi <raghuhack78@gmail.com> > Reviewed-by: Vishal Verma <vishal.l.verma@intel.com> > Reviewed-by: Dave Jiang <dave.jiang@intel.com> > Reviewed-by: Ira Weiny <ira.weiny@intel.com> Thanks for follow-up Raghu! Reviewed-by: Alison Schofield <alison.schofield@intel.com> > --- > drivers/cxl/core/mbox.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > index d6d067fbee97..af7f37cea871 100644 > --- a/drivers/cxl/core/mbox.c > +++ b/drivers/cxl/core/mbox.c > @@ -1325,10 +1325,8 @@ struct cxl_memdev_state *cxl_memdev_state_create(struct device *dev) > struct cxl_memdev_state *mds; > > mds = devm_kzalloc(dev, sizeof(*mds), GFP_KERNEL); > - if (!mds) { > - dev_err(dev, "No memory available\n"); > + if (!mds) > return ERR_PTR(-ENOMEM); > - } > > mutex_init(&mds->mbox_mutex); > mutex_init(&mds->event.log_lock); > -- > 2.39.2 >
diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index d6d067fbee97..af7f37cea871 100644 --- a/drivers/cxl/core/mbox.c +++ b/drivers/cxl/core/mbox.c @@ -1325,10 +1325,8 @@ struct cxl_memdev_state *cxl_memdev_state_create(struct device *dev) struct cxl_memdev_state *mds; mds = devm_kzalloc(dev, sizeof(*mds), GFP_KERNEL); - if (!mds) { - dev_err(dev, "No memory available\n"); + if (!mds) return ERR_PTR(-ENOMEM); - } mutex_init(&mds->mbox_mutex); mutex_init(&mds->event.log_lock);