| Message ID | 20231122021849.1208967-1-alison.schofield@intel.com |
|---|---|
| State | Accepted |
| Commit | cbf049039482a56c2b66ede3e10d5e9c652890b7 |
| Headers | show |
| Series | [ndctl] cxl/test: validate the auto region in cxl-topology.sh | expand |
On Tue, Nov 21, 2023 at 06:18:49PM -0800, alison.schofield@intel.com wrote: > From: Alison Schofield <alison.schofield@intel.com> > > The cxl-test module sets up a region to be autodiscovered in > order to test the CXL driver handling of BIOS defined regions. > Confirm the region exists upon load of the cxl-test module. > > Signed-off-by: Alison Schofield <alison.schofield@intel.com> > --- > > The region does survive the ensuing shenanigans of this test. > The region state moves from committed to disabled and back > again as the memdevs, ports, and host bridges are disabled > and then re-enabled. Although that was interesting, it's not > clear that this test should be doing region error recovery > testing. > Let me know if you think otherwise? I probably should have explained what doing 'more' would look like. We can add another check of the region before the final bus disable to confirm that it survived. > > > test/cxl-topology.sh | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/test/cxl-topology.sh b/test/cxl-topology.sh > index 89d01a89ccb1..e8b9f56543b5 100644 > --- a/test/cxl-topology.sh > +++ b/test/cxl-topology.sh > @@ -21,6 +21,14 @@ rc=1 > # tools/testing/cxl/test/cxl.c. If that model ever changes then the > # paired update must be made to this test. > > +# validate the autodiscovered region > +region=$("$CXL" list -R | jq -r ".[] | .region") > +if [[ ! $region ]]; then > + echo "failed to find autodiscovered region" > + err "$LINENO" > +fi > + > + > # collect cxl_test root device id > json=$($CXL list -b cxl_test) > count=$(jq "length" <<< $json) > > base-commit: a871e6153b11fe63780b37cdcb1eb347b296095c > -- > 2.37.3 >
diff --git a/test/cxl-topology.sh b/test/cxl-topology.sh index 89d01a89ccb1..e8b9f56543b5 100644 --- a/test/cxl-topology.sh +++ b/test/cxl-topology.sh @@ -21,6 +21,14 @@ rc=1 # tools/testing/cxl/test/cxl.c. If that model ever changes then the # paired update must be made to this test. +# validate the autodiscovered region +region=$("$CXL" list -R | jq -r ".[] | .region") +if [[ ! $region ]]; then + echo "failed to find autodiscovered region" + err "$LINENO" +fi + + # collect cxl_test root device id json=$($CXL list -b cxl_test) count=$(jq "length" <<< $json)