| Message ID | 20240112062709.2490947-1-ruansy.fnst@fujitsu.com |
|---|---|
| State | Accepted |
| Commit | 73bf93edeeea866b0b6efbc8d2595bdaaba7f1a5 |
| Headers | show |
| Series | cxl/core: use sysfs_emit() for attr's _show() | expand |
On Fri, 12 Jan 2024 14:27:09 +0800 Shiyang Ruan <ruansy.fnst@fujitsu.com> wrote: > sprintf() is deprecated for sysfs, use preferred sysfs_emit() instead. > > Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com> FWIW this looks fine to me. Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/cxl/core/memdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c > index 2f43d368ba07..dae8802ecdb0 100644 > --- a/drivers/cxl/core/memdev.c > +++ b/drivers/cxl/core/memdev.c > @@ -114,7 +114,7 @@ static DEVICE_ATTR_RO(serial); > static ssize_t numa_node_show(struct device *dev, struct device_attribute *attr, > char *buf) > { > - return sprintf(buf, "%d\n", dev_to_node(dev)); > + return sysfs_emit(buf, "%d\n", dev_to_node(dev)); > } > static DEVICE_ATTR_RO(numa_node); >
On 1/11/24 23:27, Shiyang Ruan wrote: > sprintf() is deprecated for sysfs, use preferred sysfs_emit() instead. > > Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> > --- > drivers/cxl/core/memdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c > index 2f43d368ba07..dae8802ecdb0 100644 > --- a/drivers/cxl/core/memdev.c > +++ b/drivers/cxl/core/memdev.c > @@ -114,7 +114,7 @@ static DEVICE_ATTR_RO(serial); > static ssize_t numa_node_show(struct device *dev, struct device_attribute *attr, > char *buf) > { > - return sprintf(buf, "%d\n", dev_to_node(dev)); > + return sysfs_emit(buf, "%d\n", dev_to_node(dev)); > } > static DEVICE_ATTR_RO(numa_node); >
On Fri, Jan 12, 2024 at 02:27:09PM +0800, Shiyang Ruan wrote: > sprintf() is deprecated for sysfs, use preferred sysfs_emit() instead. > > Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com> > --- Reviewed-by: Fan Ni <fan.ni@samsung.com> > drivers/cxl/core/memdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c > index 2f43d368ba07..dae8802ecdb0 100644 > --- a/drivers/cxl/core/memdev.c > +++ b/drivers/cxl/core/memdev.c > @@ -114,7 +114,7 @@ static DEVICE_ATTR_RO(serial); > static ssize_t numa_node_show(struct device *dev, struct device_attribute *attr, > char *buf) > { > - return sprintf(buf, "%d\n", dev_to_node(dev)); > + return sysfs_emit(buf, "%d\n", dev_to_node(dev)); > } > static DEVICE_ATTR_RO(numa_node); > > -- > 2.34.1 >
diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c index 2f43d368ba07..dae8802ecdb0 100644 --- a/drivers/cxl/core/memdev.c +++ b/drivers/cxl/core/memdev.c @@ -114,7 +114,7 @@ static DEVICE_ATTR_RO(serial); static ssize_t numa_node_show(struct device *dev, struct device_attribute *attr, char *buf) { - return sprintf(buf, "%d\n", dev_to_node(dev)); + return sysfs_emit(buf, "%d\n", dev_to_node(dev)); } static DEVICE_ATTR_RO(numa_node);
sprintf() is deprecated for sysfs, use preferred sysfs_emit() instead. Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com> --- drivers/cxl/core/memdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)