@@ -2110,6 +2110,20 @@ static void combine_coordinates(struct access_coordinate *c1,
c1->read_latency += c2->read_latency;
}
+static bool coordinates_invalid(struct access_coordinate *c)
+{
+ if (!c->read_bandwidth && !c->write_bandwidth &&
+ !c->read_latency && !c->write_latency)
+ return true;
+
+ return false;
+}
+
+static bool parent_port_is_cxl_root(struct cxl_port *port)
+{
+ return is_cxl_root(to_cxl_port(port->dev.parent));
+}
+
/**
* cxl_endpoint_get_perf_coordinates - Retrieve performance numbers stored in dports
* of CXL path
@@ -2142,16 +2156,25 @@ int cxl_endpoint_get_perf_coordinates(struct cxl_port *port,
* port each iteration. If the parent is cxl root then there is
* nothing to gather.
*/
- while (!is_cxl_root(to_cxl_port(iter->dev.parent))) {
- combine_coordinates(&c, &dport->sw_coord);
+ while (!parent_port_is_cxl_root(iter)) {
+ iter = to_cxl_port(iter->dev.parent);
+
+ /* There's no CDAT for the host bridge, so skip if so. */
+ if (!parent_port_is_cxl_root(iter)) {
+ if (coordinates_invalid(&dport->sw_coord))
+ return -EINVAL;
+
+ combine_coordinates(&c, &dport->sw_coord);
+ }
+
c.write_latency += dport->link_latency;
c.read_latency += dport->link_latency;
-
- iter = to_cxl_port(iter->dev.parent);
dport = iter->parent_dport;
}
/* Augment with the generic port (host bridge) perf data */
+ if (coordinates_invalid(&dport->hb_coord))
+ return -EINVAL;
combine_coordinates(&c, &dport->hb_coord);
/* Get the calculated PCI paths bandwidth */
Jonathan noted that when the coordinates for host bridge and switches can be 0s if no actual data are retrieved and the calculation continues. The resulting number would be inaccurate. Add checks to ensure that the calculation would complete only if the numbers are valid. The issue of bad data showing up from ACPI or CDAT currently is not expected to show up on production systems or endpoint devices. The changes in this commit are code enhancement and not bug fixes. Reported-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Signed-off-by: Dave Jiang <dave.jiang@intel.com> --- v2: - Add explanation of not a bug fix in commit log. (Dan) --- drivers/cxl/core/port.c | 31 +++++++++++++++++++++++++++---- 1 file changed, 27 insertions(+), 4 deletions(-)