| Message ID | 20240718213446.1750135-3-dave.jiang@intel.com |
|---|---|
| State | Accepted |
| Commit | 423c9baae4c7fe73d5812e28610418fd2e8050bd |
| Headers | show |
| Series | fwctl/cxl: Add CXL feature commands support via fwctl | expand |
On Thu, 18 Jul 2024 14:32:20 -0700 Dave Jiang <dave.jiang@intel.com> wrote: > The code indicates that the min of n_commands and total commands > is returned. The comment incorrectly says it's the max(). Correct > comment to min(). > > Signed-off-by: Dave Jiang <dave.jiang@intel.com> Send this one separately. > --- > drivers/cxl/core/mbox.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > index 783cb5ed823f..433819ac36b7 100644 > --- a/drivers/cxl/core/mbox.c > +++ b/drivers/cxl/core/mbox.c > @@ -547,7 +547,7 @@ int cxl_query_cmd(struct cxl_memdev *cxlmd, > return put_user(ARRAY_SIZE(cxl_mem_commands), &q->n_commands); > > /* > - * otherwise, return max(n_commands, total commands) cxl_command_info > + * otherwise, return min(n_commands, total commands) cxl_command_info > * structures. > */ > cxl_for_each_cmd(cmd) {
On 7/26/24 10:29 AM, Jonathan Cameron wrote: > On Thu, 18 Jul 2024 14:32:20 -0700 > Dave Jiang <dave.jiang@intel.com> wrote: > >> The code indicates that the min of n_commands and total commands >> is returned. The comment incorrectly says it's the max(). Correct >> comment to min(). >> >> Signed-off-by: Dave Jiang <dave.jiang@intel.com> > Send this one separately. Yup. This one is now queued for 6.12. >> --- >> drivers/cxl/core/mbox.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c >> index 783cb5ed823f..433819ac36b7 100644 >> --- a/drivers/cxl/core/mbox.c >> +++ b/drivers/cxl/core/mbox.c >> @@ -547,7 +547,7 @@ int cxl_query_cmd(struct cxl_memdev *cxlmd, >> return put_user(ARRAY_SIZE(cxl_mem_commands), &q->n_commands); >> >> /* >> - * otherwise, return max(n_commands, total commands) cxl_command_info >> + * otherwise, return min(n_commands, total commands) cxl_command_info >> * structures. >> */ >> cxl_for_each_cmd(cmd) {
diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index 783cb5ed823f..433819ac36b7 100644 --- a/drivers/cxl/core/mbox.c +++ b/drivers/cxl/core/mbox.c @@ -547,7 +547,7 @@ int cxl_query_cmd(struct cxl_memdev *cxlmd, return put_user(ARRAY_SIZE(cxl_mem_commands), &q->n_commands); /* - * otherwise, return max(n_commands, total commands) cxl_command_info + * otherwise, return min(n_commands, total commands) cxl_command_info * structures. */ cxl_for_each_cmd(cmd) {
The code indicates that the min of n_commands and total commands is returned. The comment incorrectly says it's the max(). Correct comment to min(). Signed-off-by: Dave Jiang <dave.jiang@intel.com> --- drivers/cxl/core/mbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)