| Message ID | 20181016164220.29413-1-ao2@ao2.it (mailing list archive) |
|---|---|
| Headers | show |
| Series | Build system updates and gcc warnings fixes | expand |
On Tue, 16 Oct 2018 18:42:15 +0200 Antonio Ospite <ao2@ao2.it> wrote: > Hi, > > here are some build system updates and some fixes for compilation > warnings with Gcc. > > After this patchset, compilation with Gcc is nice and clean, > [...] > .gitignore | 2 ++ > configure.ac | 8 +++++--- > src/Makefile.am | 16 ++++++++-------- > src/eval.c | 2 +- > src/system.h | 4 ---- > 5 files changed, 16 insertions(+), 16 deletions(-) > Looking at the mailing list I see there are some patches sent before this series which touch .gitignore and src/Makefile.am If you apply those first, let me know if you want me to rebase and resend this series to minimize conflicts. Thanks you, Antonio
On Sat, 27 Oct 2018 15:35:11 +0200 Antonio Ospite <ao2@ao2.it> wrote: > On Tue, 16 Oct 2018 18:42:15 +0200 > Antonio Ospite <ao2@ao2.it> wrote: > > > Hi, > > > > here are some build system updates and some fixes for compilation > > warnings with Gcc. > > > > After this patchset, compilation with Gcc is nice and clean, > > > [...] > > .gitignore | 2 ++ > > configure.ac | 8 +++++--- > > src/Makefile.am | 16 ++++++++-------- > > src/eval.c | 2 +- > > src/system.h | 4 ---- > > 5 files changed, 16 insertions(+), 16 deletions(-) > > > > Looking at the mailing list I see there are some patches sent > before this series which touch .gitignore and src/Makefile.am > I see that some of those other patches have been merged, and in fact patch 3/5 in this series can now be skipped. BTW a new warning was introduced by commit 8e43729 (eval: Report I/O error on stdout, 2018-09-07): CC eval.o eval.c: In function ‘evalbltin’: eval.c:956:3: warning: implicit declaration of function ‘warnx’; did you mean ‘sh_warnx’? [-Wimplicit-function-declaration] warnx("%s: I/O error", commandname); ^~~~~ sh_warnx > If you apply those first, let me know if you want me to rebase and > resend this series to minimize conflicts. > Ciao, Antonio
On Mon, 19 Nov 2018 13:04:45 +0100 Antonio Ospite <ao2@ao2.it> wrote: > On Sat, 27 Oct 2018 15:35:11 +0200 > Antonio Ospite <ao2@ao2.it> wrote: > > > On Tue, 16 Oct 2018 18:42:15 +0200 > > Antonio Ospite <ao2@ao2.it> wrote: > > > > > Hi, > > > > > > here are some build system updates and some fixes for compilation > > > warnings with Gcc. > > > > > > After this patchset, compilation with Gcc is nice and clean, > > > > > [...] > > > .gitignore | 2 ++ > > > configure.ac | 8 +++++--- > > > src/Makefile.am | 16 ++++++++-------- > > > src/eval.c | 2 +- > > > src/system.h | 4 ---- > > > 5 files changed, 16 insertions(+), 16 deletions(-) > > > > > > > Looking at the mailing list I see there are some patches sent > > before this series which touch .gitignore and src/Makefile.am > > > > I see that some of those other patches have been merged, and in fact > patch 3/5 in this series can now be skipped. > Hi, can I mark 3/5 as Superseded in patchwork myself? Or would that disrupt your workflow? The intent would be to have one patch less for you to worry about. Thank you, Antonio
Antonio Ospite <ao2@ao2.it> wrote: > > can I mark 3/5 as Superseded in patchwork myself? > Or would that disrupt your workflow? > > The intent would be to have one patch less for you to worry about. I just marked it. Thanks!
Antonio Ospite <ao2@ao2.it> wrote: > Hi, > > here are some build system updates and some fixes for compilation > warnings with Gcc. > > After this patchset, compilation with Gcc is nice and clean, > > There are still some warnings when compiling with clang but I have not > addressed those. > > Thank you. > Antonio > > Antonio Ospite (5): > Update configure.ac with suggestions from autoupdate > Enable automake silent rules > Add some missing autotools files to the .gitignore file > Stop using deprecated function sigsetmask() > Silence compiler warning about missing parentheses > > .gitignore | 2 ++ > configure.ac | 8 +++++--- > src/Makefile.am | 16 ++++++++-------- > src/eval.c | 2 +- > src/system.h | 4 ---- > 5 files changed, 16 insertions(+), 16 deletions(-) Patches 1, 2 and 5 applied. Thanks,