diff mbox series

[3/6] mkbuiltins: Default to mktemp, not tempfile

Message ID 20180907083414.14673-4-andrew.shadura@collabora.co.uk (mailing list archive)
State Accepted
Delegated to: Herbert Xu
Headers show
Series [1/6] exec: Don't execute binary files if execve() returned ENOEXEC. | expand

Commit Message

Andrej Shadura Sept. 7, 2018, 8:34 a.m. UTC 
Don't use tempfile, as it currently runs tempnam(), which is insecure
and fails under pseudo(1).

Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>
---
 src/mkbuiltins | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/src/mkbuiltins b/src/mkbuiltins
index b4d6f4e..f1f2593 100644
--- a/src/mkbuiltins
+++ b/src/mkbuiltins
@@ -35,7 +35,7 @@ 
 #
 #	@(#)mkbuiltins	8.2 (Berkeley) 5/4/95
 
-tempfile=tempfile
+tempfile=mktemp
 if ! type tempfile > /dev/null 2>&1 && ! type mktemp > /dev/null 2>&1; then
 	_my_tempfile()
 	{