From patchwork Fri Sep 7 08:34:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrej Shadura X-Patchwork-Id: 10592271 X-Patchwork-Delegate: herbert@gondor.apana.org.au Delivered-To: konstantin@linuxfoundation.org Received: by 2002:a0c:fb06:0:0:0:0:0 with SMTP id c6-v6csp1459279qvp; Fri, 7 Sep 2018 01:34:58 -0700 (PDT) X-Google-Smtp-Source: ANB0VdamPR06dyGPxB/LROvMcwklm/PbcTdXSm214LjwNbWZG6ZULnAVjCxLE/Mk0uBX7INlbxh+ X-Received: by 2002:a17:902:622:: with SMTP id 31-v6mr6824689plg.153.1536309298896; Fri, 07 Sep 2018 01:34:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536309298; cv=none; d=google.com; s=arc-20160816; b=ditOnkfLG85pdpnYAAlQff5bAW4J+6yoOIynWXhLKrvKbdxn0IOHGL2o4BiEoq/Tcf z8ioPeZq6FR8Grr1Tmi8cM9jyx/tI66DXhwUz2t7mZL5VmUHd8S6Be0/05q4tCujcEGs DEXc3JP1TY88LEhFYgbCzQS1wP3POcMwmeCBV4pMkCTsAN0Ml7GXU0See7YHWSXSt6tM M9kABEBPfJShjZcQqGT5cP64lG+ZQ+6xjFKWqgtX9W/cA8CWJWS+iIOObd0Py/CCXVfr HsQb4BaXg9GBi5AOtjb11B/W9bYFm060zommiilca5s4cLvnG40NEUF2AGVWWQLT2Mbv onSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:to:from; bh=YY3tnxrxXBKjm2LBXwnAsByPeoHWWKWyttShZsRI1a8=; b=A2ZDeF9BNe45cM2agQycnUe6YxKW7uZ/Kqs+50jJr42LYUJS7NdTWW4YL8YhShs8xK EyyaS/20K5PYpgvDk2RtiFoXd92Zds1AL4nwqApE44YUEtldcWCDMK8qhvvhJeWsDQYj zVD8gWAeJxJKlVofDCA1Rgq9cO6WJdn+jYNMUJMcRwPUkVsVphdKpYNwYAknctSA36kC 3PR7OmVGT4583dY9TYelrlU0phj5WbrFV33U68uF9Hu9hYFZNyPBVaeDSN8I0z7LrPOM xpb7lP7rsNkYOXrkBltOfPMuciF81HWU70cYl+7Fdaa9LNGiztXYZLzTZ6V7LRE/Npp7 H8DA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dash-owner@kernel.org designates 198.145.29.98 as permitted sender) smtp.mailfrom=dash-owner@kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.co.uk Return-Path: Received: from mail.wl.linuxfoundation.org (mail.wl.linuxfoundation.org. [198.145.29.98]) by mx.google.com with ESMTPS id 33-v6si7630792ply.251.2018.09.07.01.34.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Sep 2018 01:34:58 -0700 (PDT) Received-SPF: pass (google.com: domain of dash-owner@kernel.org designates 198.145.29.98 as permitted sender) client-ip=198.145.29.98; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dash-owner@kernel.org designates 198.145.29.98 as permitted sender) smtp.mailfrom=dash-owner@kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.co.uk Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7BA212ADD8 for ; Fri, 7 Sep 2018 08:34:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 708492ADE1; Fri, 7 Sep 2018 08:34:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 37B312ADD8 for ; Fri, 7 Sep 2018 08:34:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2C5332ADE1; Fri, 7 Sep 2018 08:34:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B2DBF2ADD8 for ; Fri, 7 Sep 2018 08:34:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728076AbeIGNOs (ORCPT ); Fri, 7 Sep 2018 09:14:48 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:35242 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725843AbeIGNOr (ORCPT ); Fri, 7 Sep 2018 09:14:47 -0400 Received: from localhost (2a02-ab04-03b9-5e00-0000-0000-0000-0003.dynamic.v6.chello.sk [IPv6:2a02:ab04:3b9:5e00::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: andrewsh) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 045BB27D873; Fri, 7 Sep 2018 09:34:47 +0100 (BST) From: Andrej Shadura To: dash@vger.kernel.org Subject: [PATCH 3/6] mkbuiltins: Default to mktemp, not tempfile Date: Fri, 7 Sep 2018 10:34:11 +0200 Message-Id: <20180907083414.14673-4-andrew.shadura@collabora.co.uk> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180907083414.14673-1-andrew.shadura@collabora.co.uk> References: <20180907083414.14673-1-andrew.shadura@collabora.co.uk> Sender: dash-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dash@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP X-Virus-Scanned: ClamAV using ClamSMTP Status: O Content-Length: 562 Lines: 24 Don't use tempfile, as it currently runs tempnam(), which is insecure and fails under pseudo(1). Signed-off-by: Andrej Shadura --- src/mkbuiltins | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mkbuiltins b/src/mkbuiltins index b4d6f4e..f1f2593 100644 --- a/src/mkbuiltins +++ b/src/mkbuiltins @@ -35,7 +35,7 @@ # # @(#)mkbuiltins 8.2 (Berkeley) 5/4/95 -tempfile=tempfile +tempfile=mktemp if ! type tempfile > /dev/null 2>&1 && ! type mktemp > /dev/null 2>&1; then _my_tempfile() {