diff mbox series

build: delete AC_PROG_YACC

Message ID 20191010164253.efork5stbhquef5m@google.com (mailing list archive)
State Accepted
Delegated to: Herbert Xu
Headers show
Series build: delete AC_PROG_YACC | expand

Commit Message

Fangrui Song Oct. 10, 2019, 4:42 p.m. UTC 
src/arith.y was deleted by commit f6e3b2 [ARITH] Add assignment and intmax_t support.
We can delete AC_PROG_YACC to get rid of the build-time dependency.

Comments

Harald van Dijk Oct. 12, 2019, 8:31 a.m. UTC | #1 
On 10/10/2019 17:42, Fangrui Song wrote:
> src/arith.y was deleted by commit f6e3b2 [ARITH] Add assignment and intmax_t support.
> We can delete AC_PROG_YACC to get rid of the build-time dependency.

Just a minor point of clarification: there is no build-time dependency 
on bison/yacc. The configure script checks whether bison/yacc exists, 
but if not, happily continues. This change does not get rid of a 
build-time dependency, it cleans up the configure script by removing an 
unused check.

Which is obviously still an improvement so your patch should still go in.

Cheers,
Harald van Dijk
diff mbox series

Patch

From 1d173d31dcc971f3dc6e233d04498adc41b7326c Mon Sep 17 00:00:00 2001
From: Fangrui Song <i@maskray.me>
Date: Thu, 10 Oct 2019 16:30:42 +0000
Subject: [PATCH] build: delete AC_PROG_YACC
To: dash@vger.kernel.org

---
 configure.ac | 1 -
 1 file changed, 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 036730d..5dab5aa 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,6 @@  m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES(yes)])
 dnl Checks for programs.
 AC_PROG_CC
 AC_USE_SYSTEM_EXTENSIONS
-AC_PROG_YACC
 
 AC_MSG_CHECKING([for build system compiler])
 if test "$cross_compiling" = yes; then
-- 
2.23.0