diff mbox

Add subdir-objects to AM_INIT_AUTOMAKE

Message ID CAAe81c4F9K0qbumqfP_ET+NqRc8aODqV3hfAcpo1qYb+OPONhA@mail.gmail.com (mailing list archive)
State Accepted
Delegated to: Herbert Xu
Headers show

Commit Message

Jason Bowen March 26, 2018, 6:53 p.m. UTC
I've attached a patch which adds the subdir-objects option to AM_INIT_AUTOMAKE.

For a while now when I've compiled dash I received a warning from
automake that there are source files in a subdirectory but that the
subdir-objects automake option was not supplied. I've just been adding
it myself, but I finally got around to submitting a patch. The code
still compiles for now (i'm using automake 1.15.1), but warning text
is rarely nice to see and, if the warning text is to be believed, then
the warning will eventually become an error.

Comments

Herbert Xu April 19, 2018, 10:23 a.m. UTC | #1
Jason Bowen <bowen.pi@gmail.com> wrote:
> [-- text/plain, encoding 7bit, charset: UTF-8, 10 lines --]
> 
> I've attached a patch which adds the subdir-objects option to AM_INIT_AUTOMAKE.
> 
> For a while now when I've compiled dash I received a warning from
> automake that there are source files in a subdirectory but that the
> subdir-objects automake option was not supplied. I've just been adding
> it myself, but I finally got around to submitting a patch. The code
> still compiles for now (i'm using automake 1.15.1), but warning text
> is rarely nice to see and, if the warning text is to be believed, then
> the warning will eventually become an error.

Patch applied.  Thanks.
diff mbox

Patch

From 1dc859e3891c1b891c7a31a8e247850226442cfb Mon Sep 17 00:00:00 2001
From: Jason Bowen <bowen.pi@gmail.com>
Date: Sun, 25 Mar 2018 22:39:32 -0500
Subject: [PATCH] Add `subdir-objects` to AM_INIT_AUTOMAKE to silence warnings.

---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 0417fa2..5d88894 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,5 +1,5 @@ 
 AC_INIT(dash, 0.5.9.1)
-AM_INIT_AUTOMAKE([foreign])
+AM_INIT_AUTOMAKE([foreign subdir-objects])
 AC_CONFIG_SRCDIR([src/main.c])
 
 AC_CONFIG_HEADERS(config.h)
-- 
2.14.3