From patchwork Sun May 24 21:05:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fredrik Fornwall X-Patchwork-Id: 6472321 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Original-To: patchwork-dash@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 630199F1C1 for ; Sun, 24 May 2015 21:06:01 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 50C8C20574 for ; Sun, 24 May 2015 21:05:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1EA2820411 for ; Sun, 24 May 2015 21:05:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751258AbbEXVFv (ORCPT ); Sun, 24 May 2015 17:05:51 -0400 Received: from mail-la0-f51.google.com ([209.85.215.51]:32998 "EHLO mail-la0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751275AbbEXVFv (ORCPT ); Sun, 24 May 2015 17:05:51 -0400 Received: by lami4 with SMTP id i4so39302381lam.0 for ; Sun, 24 May 2015 14:05:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=RKiIv99RDUYMFAJWs0ygV6LQqY8CHXzl7Hp+tJUrd1A=; b=QQSH5Yjk+qk5EAuklARAm1K0/mY2giSsIsK3oMd3dvKBOOIiAKvdCN7BOtQjQf5D3d e2HnEg4v7BNreaUxRy+58eNmxB2Y8O5WdKNMzrJ0DPk6SCA+iHefTlDirlFCmyFs8Vfy y/0G4p9qv5H+5ffBKk8xYTRKwj9Mnzyvxx8lbFAnZ/MOCo6SNmzqzQy5EeiHFzEQkhr/ Sp5bnKtf8iA3nR1Mq5RxnW3PQDedKZYTPR2m2MyYTUylTjkz2DBm9tAWx9lMRqovSmST 4LiJzzAh8+aLh1p2rd7VHVKRdvm/GjP5MZ4T6VEdv9PZ5EjnafNfTXlDrIAA5sj6zRg+ aQzQ== X-Gm-Message-State: ALoCoQnhNTa6THS9yqT+ovMqPTZbaf1er4NX21ODOuKMQlPvG5lgOUoMkO8q6lIzfhBpDRTGTAbb MIME-Version: 1.0 X-Received: by 10.112.16.227 with SMTP id j3mr7342967lbd.43.1432501548624; Sun, 24 May 2015 14:05:48 -0700 (PDT) Received: by 10.112.133.10 with HTTP; Sun, 24 May 2015 14:05:48 -0700 (PDT) In-Reply-To: <20150522042531.GA30829@gondor.apana.org.au> References: <20150522042531.GA30829@gondor.apana.org.au> Date: Sun, 24 May 2015 23:05:48 +0200 Message-ID: Subject: Re: [PATCH] Set LC_ALL instead LC_COLLATE in mkbuiltins From: Fredrik Fornwall To: Herbert Xu Cc: dash@vger.kernel.org Sender: dash-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dash@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, May 22, 2015 at 6:25 AM, Herbert Xu wrote: > This causes any errors printed by sort to come out in English. > > Please fix this by simply setting LC_ALL to empty alongside > LC_COLLATE=C. A version with LC_ALL= follows: --- To unsubscribe from this list: send the line "unsubscribe dash" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff -u -r ../dash-0.5.8/src/mkbuiltins ./src/mkbuiltins --- ../dash-0.5.8/src/mkbuiltins 2014-09-28 04:19:32.000000000 -0400 +++ ./src/mkbuiltins 2015-05-17 19:08:00.076452891 -0400 @@ -78,7 +78,7 @@ if ($i ~ /^-/) line = $(++i) "\t" line print line - }}' $temp | LC_COLLATE=C sort -k 1,1 | tee $temp2 | awk '{ + }}' $temp | LC_ALL= LC_COLLATE=C sort -k 1,1 | tee $temp2 | awk '{ opt = "" if (NF > 2) { opt = substr($2, 2) @@ -97,7 +97,7 @@ */ ! -sed 's/ -[a-z]*//' $temp2 | nl -b a -v 0 | LC_COLLATE=C sort -u -k 3,3 | +sed 's/ -[a-z]*//' $temp2 | nl -b a -v 0 | LC_ALL= LC_COLLATE=C sort -u -k 3,3 | tr abcdefghijklmnopqrstuvwxyz ABCDEFGHIJKLMNOPQRSTUVWXYZ | awk '{ printf "#define %s (builtincmd + %d)\n", $3, $1}' printf '\n#define NUMBUILTINS %d\n' $(wc -l < $temp2)