diff mbox series

shell: Disable fnmatch by default

Message ID ZkoOY9cWtv09aDjg@gondor.apana.org.au (mailing list archive)
State Accepted
Delegated to: Herbert Xu
Headers show
Series shell: Disable fnmatch by default | expand

Commit Message

Herbert Xu May 19, 2024, 2:36 p.m. UTC 
As fnmatch(3) is terribly slow with multi-byte strings, disable
it by default.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff mbox series

Patch

diff --git a/configure.ac b/configure.ac
index 50effc0..338d5bd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -37,8 +37,8 @@  if test "$enable_static" = "yes"; then
 	export LDFLAGS="-static"
 fi
 
-AC_ARG_ENABLE(fnmatch, AS_HELP_STRING(--disable-fnmatch, \
-				      [Do not use fnmatch(3) from libc]))
+AC_ARG_ENABLE(fnmatch, AS_HELP_STRING(--enable-fnmatch, \
+				      [Use fnmatch(3) from libc]))
 AC_ARG_ENABLE(glob, AS_HELP_STRING(--enable-glob, [Use glob(3) from libc]))
 
 dnl Checks for libraries.
@@ -122,7 +122,7 @@  if test "$enable_test_workaround" = "yes"; then
 		[Define if your faccessat tells root all files are executable])
 fi
 
-if test "$enable_fnmatch" != no; then
+if test "$enable_fnmatch" = yes; then
 	use_fnmatch=
 	AC_CHECK_FUNCS(fnmatch, use_fnmatch=yes)
 fi