From patchwork Fri Jun 23 16:42:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Larry Hynes X-Patchwork-Id: 9807043 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 727486086C for ; Fri, 23 Jun 2017 17:00:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 55DB2287BF for ; Fri, 23 Jun 2017 17:00:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4A78F287BA; Fri, 23 Jun 2017 17:00:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8C14A287C2 for ; Fri, 23 Jun 2017 17:00:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754022AbdFWRAQ (ORCPT ); Fri, 23 Jun 2017 13:00:16 -0400 Received: from [195.159.176.226] ([195.159.176.226]:33368 "EHLO blaine.gmane.org" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754014AbdFWRAP (ORCPT ); Fri, 23 Jun 2017 13:00:15 -0400 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dORwE-0006Ob-E1 for dash@vger.kernel.org; Fri, 23 Jun 2017 19:00:06 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: dash@vger.kernel.org From: Larry Hynes Subject: Re: Small cleanup to src/dash.1 - Command Line Editing Date: Fri, 23 Jun 2017 17:42:50 +0100 Lines: 65 Message-ID: References: <6csf1e-9n5.ln1@sabon.larryhynes.com> <20170623144128.GA15837@stack.nl> Mime-Version: 1.0 X-Complaints-To: usenet@blaine.gmane.org User-Agent: tin/2.4.1-20161224 ("Daill") (UNIX) (Darwin/14.5.0 (x86_64)) Sender: dash-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dash@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Jilles Tjoelker wrote: > On Sat, Jun 17, 2017 at 03:53:26PM +0100, Larry Hynes wrote: >> src/dash.1, under Command Line Editing, states: >> It's similar to vi: typing will throw you into command >> VI command mode. >> - There appears to be no need for both occurrences of 'command' >> - I can't see a reason for VI to be capitalised >> - 'will throw you into' seems a little... enthusiastic >> Following diff changes it to >> It's similar to vi: typing enters vi command mode. >> diff --git a/src/dash.1 b/src/dash.1 >> index 8b8026d..f35d89d 100644 >> --- a/src/dash.1 >> +++ b/src/dash.1 >> @@ -2232,7 +2232,7 @@ enabled, sh can be switched between insert mode and command mode. >> The editor is not described in full here, but will be in a later document. >> It's similar to vi: typing >> .Aq ESC >> -will throw you into command VI command mode. >> +enters vi command mode. >> Hitting >> .Aq return >> while in command mode will pass the line to the shell. > I agree. If you're changing things here anyway, I suggest getting rid of > the contraction as well (changing It's to It is). The fairly formal > style of man pages avoids contractions, just like it avoids "you". > The reference to the "later document" can probably be removed as well, > since said document does not exist yet after many years. Hi Revised diff, below, expands the contraction, deletes reference to 'later document' and changes 'place' to 'places' in the following: The command ‘set -o vi’ enables vi-mode editing and place sh into vi insert mode. --- To unsubscribe from this list: send the line "unsubscribe dash" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/src/dash.1 b/src/dash.1 index 8b8026d..1056285 100644 --- a/src/dash.1 +++ b/src/dash.1 @@ -2226,13 +2226,12 @@ This mode uses commands, described below, similar to a subset of those described in the vi man page. The command .Ql set -o vi -enables vi-mode editing and place sh into vi insert mode. +enables vi-mode editing and places sh into vi insert mode. With vi-mode enabled, sh can be switched between insert mode and command mode. -The editor is not described in full here, but will be in a later document. -It's similar to vi: typing +It is similar to vi: typing .Aq ESC -will throw you into command VI command mode. +enters vi command mode. Hitting .Aq return while in command mode will pass the line to the shell.