From patchwork Wed Feb 3 15:53:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtepa X-Patchwork-Id: 12064659 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51F6FC433E0 for ; Wed, 3 Feb 2021 15:54:41 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E8C664F5D for ; Wed, 3 Feb 2021 15:54:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E8C664F5D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=veeam.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-42-fQWKghqDNLKASGIZzs0Wfw-1; Wed, 03 Feb 2021 10:54:37 -0500 X-MC-Unique: fQWKghqDNLKASGIZzs0Wfw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4C4BB801962; Wed, 3 Feb 2021 15:54:32 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B690A5D9E8; Wed, 3 Feb 2021 15:54:31 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BE96918095CB; Wed, 3 Feb 2021 15:54:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 113FsR0a005961 for ; Wed, 3 Feb 2021 10:54:27 -0500 Received: by smtp.corp.redhat.com (Postfix) id 0E6A2200A39A; Wed, 3 Feb 2021 15:54:27 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0895620234A6 for ; Wed, 3 Feb 2021 15:54:23 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 86A4F858EEB for ; Wed, 3 Feb 2021 15:54:23 +0000 (UTC) Received: from mx2.veeam.com (mx2.veeam.com [64.129.123.6]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-482-cHQoDRScPfWWcqAvuiWB5A-1; Wed, 03 Feb 2021 10:54:19 -0500 X-MC-Unique: cHQoDRScPfWWcqAvuiWB5A-1 Received: from mail.veeam.com (prgmbx01.amust.local [172.24.0.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx2.veeam.com (Postfix) with ESMTPS id 49B004146C; Wed, 3 Feb 2021 10:54:15 -0500 (EST) Received: from prgdevlinuxpatch01.amust.local (172.24.14.5) by prgmbx01.amust.local (172.24.0.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.721.2; Wed, 3 Feb 2021 16:54:13 +0100 From: Sergei Shtepa To: , , , , , , , , , , , , , , , Date: Wed, 3 Feb 2021 18:53:52 +0300 Message-ID: <1612367638-3794-1-git-send-email-sergei.shtepa@veeam.com> MIME-Version: 1.0 X-Originating-IP: [172.24.14.5] X-ClientProxiedBy: prgmbx02.amust.local (172.24.0.172) To prgmbx01.amust.local (172.24.0.171) X-EsetResult: clean, is OK X-EsetId: 37303A29C604D265667062 X-Veeam-MMEX: True X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: dm-devel@redhat.com Cc: pavgel.tide@veeam.com, sergei.shtepa@veeam.com Subject: [dm-devel] [PATCH v4 0/6] block-layer interposer X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Hi all. I'm ready to suggest the block-layer interposer (blk_interposer). blk_interposer allows to intercept bio requests, remap bio to another devices or add new bios. This patch series adds support blk_interposer for dm-linear. In the first patch, I suggest the remap_and_filter.rst file. Yes, Mike, it's probably too early for documentation, but maybe it will be interesting for someone. In the documentation I tried to explain the purpose of blk_interposer and what prospects it opens up. The second patch is dedicated to blk_interposer itself, which provides the ability to intercept bio. The third - adds the function blk_mq_is_queue_frozen(). It allows to assert a queue state. The fourth one adds support for blk_interposer from the device mapper. Added ioctl DM_DEV_REMAP_CMD. In the fifth - added the 'noexcl' option for dm-linear, which allows to open the underlying block-device without the FMODE_EXCL mode. This allows to create a dm device to which can redirect bio requests using DM_DEV_REMAP_CMD. Here I would like to discuss the implementation. I don't like to play with flags. Adding the non_exclusive flags creates an excessive complexity. An alternative solution is to explicitly specify the FMODE_EXCL mode for each dm-target. The problem is that in this case, we will have to change each dm-target. It doesn't look cool either. The latest patch changes linear.rst with the description of the 'noexcl' option that is added for dm-linear. A little history of changes: v4 - current patch set Mostly changes were made, due to Damien's comments: * on the design of the code; * by the patch set organization; * bug with passing a wrong parameter to dm_get_device(); * description of the 'noexcl' parameter in the linear.rst. Also added remap_and_filter.rst. v3 - https://patchwork.kernel.org/project/linux-block/cover/1611853955-32167-1-git-send-email-sergei.shtepa@veeam.com/ In this version, I already suggested blk_interposer to apply to dm-linear. Problems were solved: * Interception of bio requests from a specific device on the disk, not from the entire disk. To do this, we added the dm_interposed_dev structure and an interval tree to store these structures. * Implemented ioctl DM_DEV_REMAP_CMD. A patch with changes in the lvm2 project was sent to the team lvm-devel@redhat.com. * Added the 'noexcl' option for dm-linear, which allows you to open the underlying block-device without FMODE_EXCL mode. v2 - https://patchwork.kernel.org/project/linux-block/cover/1607518911-30692-1-git-send-email-sergei.shtepa@veeam.com/ I tried to suggest blk_interposer without using it in device mapper, but with the addition of a sample of its use. It was then that I learned about the maintainers' attitudes towards the samples directory :). v1 - https://lwn.net/ml/linux-block/20201119164924.74401-1-hare@suse.de/ This Hannes's patch can be considered as a starting point, since this is where the interception mechanism and the term blk_interposer itself appeared. It became clear that blk_interposer can be useful for device mapper. before v1 - https://patchwork.kernel.org/project/linux-block/cover/1603271049-20681-1-git-send-email-sergei.shtepa@veeam.com/ I tried to offer a rather cumbersome blk-filter and a monster-like blk-snap module for creating snapshots. Thank you to everyone who was able to take the time to review the previous versions. I hope that this time I achieved the required quality. Thanks, Sergei. Sergei Shtepa (6): docs: device-mapper: add remap_and_filter block: add blk_interposer block: add blk_mq_is_queue_frozen() dm: new ioctl DM_DEV_REMAP_CMD dm: add 'noexcl' option for dm-linear docs: device-mapper: 'noexcl' option for dm-linear .../admin-guide/device-mapper/index.rst | 1 + .../admin-guide/device-mapper/linear.rst | 26 +- .../device-mapper/remap_and_filter.rst | 132 ++++++ block/bio.c | 2 + block/blk-core.c | 33 ++ block/blk-mq.c | 13 + block/genhd.c | 82 ++++ drivers/md/dm-core.h | 20 + drivers/md/dm-ioctl.c | 39 ++ drivers/md/dm-linear.c | 14 +- drivers/md/dm-table.c | 12 +- drivers/md/dm.c | 400 +++++++++++++++++- drivers/md/dm.h | 2 +- include/linux/blk-mq.h | 1 + include/linux/blk_types.h | 6 +- include/linux/device-mapper.h | 7 + include/linux/genhd.h | 18 + include/uapi/linux/dm-ioctl.h | 15 +- 18 files changed, 792 insertions(+), 31 deletions(-) create mode 100644 Documentation/admin-guide/device-mapper/remap_and_filter.rst --- 2.20.1 -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel