| Message ID | 20240319180005.246930-1-visitorckw@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | treewide: Refactor heap related implementation | expand |
On Wed, Mar 20, 2024 at 01:59:52AM +0800, Kuan-Wei Chiu wrote: > Hello, > > This patch series focuses on several adjustments related to heap > implementation. Firstly, a type-safe interface has been added to the > min_heap, along with the introduction of several new functions to > enhance its functionality. Additionally, the heap implementation for > bcache and bcachefs has been replaced with the generic min_heap > implementation from include/linux. Furthermore, several typos have been > corrected. > > Previous discussion with Kent Overstreet: > https://lkml.kernel.org/ioyfizrzq7w7mjrqcadtzsfgpuntowtjdw5pgn4qhvsdp4mqqg@nrlek5vmisbu Hey, thanks for doing this. Can you post a git repo link? I'll point my CI at it. > > Regards, > Kuan-Wei > > Kuan-Wei Chiu (13): > perf/core: Fix several typos > bcache: Fix typo > bcachefs: Fix typo > lib min_heap: Add type safe interface > lib min_heap: Add min_heap_init() > lib min_heap: Add min_heap_peek() > lib min_heap: Add min_heap_full() > lib min_heap: Add args for min_heap_callbacks > lib min_heap: Update min_heap_push() and min_heap_pop() to return bool > values > bcache: Remove heap-related macros and switch to generic min_heap > lib min_heap: Add min_heap_del() > lib min_heap: Add min_heap_sift_up() > bcachefs: Remove heap-related macros and switch to generic min_heap > > drivers/md/bcache/alloc.c | 66 ++++++++---- > drivers/md/bcache/bcache.h | 2 +- > drivers/md/bcache/bset.c | 73 ++++++++----- > drivers/md/bcache/bset.h | 38 ++++--- > drivers/md/bcache/btree.c | 27 ++++- > drivers/md/bcache/extents.c | 44 ++++---- > drivers/md/bcache/movinggc.c | 40 ++++++-- > drivers/md/bcache/super.c | 16 +++ > drivers/md/bcache/sysfs.c | 3 + > drivers/md/bcache/util.c | 2 +- > drivers/md/bcache/util.h | 81 +-------------- > drivers/md/dm-vdo/repair.c | 29 +++--- > drivers/md/dm-vdo/slab-depot.c | 21 ++-- > fs/bcachefs/clock.c | 53 +++++++--- > fs/bcachefs/clock_types.h | 2 +- > fs/bcachefs/ec.c | 99 +++++++++++------- > fs/bcachefs/ec_types.h | 2 +- > fs/bcachefs/util.c | 2 +- > fs/bcachefs/util.h | 127 ++--------------------- > include/linux/min_heap.h | 180 ++++++++++++++++++++++++++------- > kernel/events/core.c | 53 +++++----- > lib/test_min_heap.c | 75 +++++++------- > 22 files changed, 565 insertions(+), 470 deletions(-) > > -- > 2.34.1 >
On Tue, Mar 19, 2024 at 06:12:17PM -0400, Kent Overstreet wrote: > On Wed, Mar 20, 2024 at 01:59:52AM +0800, Kuan-Wei Chiu wrote: > > Hello, > > > > This patch series focuses on several adjustments related to heap > > implementation. Firstly, a type-safe interface has been added to the > > min_heap, along with the introduction of several new functions to > > enhance its functionality. Additionally, the heap implementation for > > bcache and bcachefs has been replaced with the generic min_heap > > implementation from include/linux. Furthermore, several typos have been > > corrected. > > > > Previous discussion with Kent Overstreet: > > https://lkml.kernel.org/ioyfizrzq7w7mjrqcadtzsfgpuntowtjdw5pgn4qhvsdp4mqqg@nrlek5vmisbu > > Hey, thanks for doing this. Can you post a git repo link? I'll point my > CI at it. > Here is the link to my GitHub repository: https://github.com/visitorckw/linux.git The patch series can be found on the 'refactor-heap' branch. Regards, Kuan-Wei > > > > Regards, > > Kuan-Wei > > > > Kuan-Wei Chiu (13): > > perf/core: Fix several typos > > bcache: Fix typo > > bcachefs: Fix typo > > lib min_heap: Add type safe interface > > lib min_heap: Add min_heap_init() > > lib min_heap: Add min_heap_peek() > > lib min_heap: Add min_heap_full() > > lib min_heap: Add args for min_heap_callbacks > > lib min_heap: Update min_heap_push() and min_heap_pop() to return bool > > values > > bcache: Remove heap-related macros and switch to generic min_heap > > lib min_heap: Add min_heap_del() > > lib min_heap: Add min_heap_sift_up() > > bcachefs: Remove heap-related macros and switch to generic min_heap > > > > drivers/md/bcache/alloc.c | 66 ++++++++---- > > drivers/md/bcache/bcache.h | 2 +- > > drivers/md/bcache/bset.c | 73 ++++++++----- > > drivers/md/bcache/bset.h | 38 ++++--- > > drivers/md/bcache/btree.c | 27 ++++- > > drivers/md/bcache/extents.c | 44 ++++---- > > drivers/md/bcache/movinggc.c | 40 ++++++-- > > drivers/md/bcache/super.c | 16 +++ > > drivers/md/bcache/sysfs.c | 3 + > > drivers/md/bcache/util.c | 2 +- > > drivers/md/bcache/util.h | 81 +-------------- > > drivers/md/dm-vdo/repair.c | 29 +++--- > > drivers/md/dm-vdo/slab-depot.c | 21 ++-- > > fs/bcachefs/clock.c | 53 +++++++--- > > fs/bcachefs/clock_types.h | 2 +- > > fs/bcachefs/ec.c | 99 +++++++++++------- > > fs/bcachefs/ec_types.h | 2 +- > > fs/bcachefs/util.c | 2 +- > > fs/bcachefs/util.h | 127 ++--------------------- > > include/linux/min_heap.h | 180 ++++++++++++++++++++++++++------- > > kernel/events/core.c | 53 +++++----- > > lib/test_min_heap.c | 75 +++++++------- > > 22 files changed, 565 insertions(+), 470 deletions(-) > > > > -- > > 2.34.1 > >
Hello, This patch series focuses on several adjustments related to heap implementation. Firstly, a type-safe interface has been added to the min_heap, along with the introduction of several new functions to enhance its functionality. Additionally, the heap implementation for bcache and bcachefs has been replaced with the generic min_heap implementation from include/linux. Furthermore, several typos have been corrected. Previous discussion with Kent Overstreet: https://lkml.kernel.org/ioyfizrzq7w7mjrqcadtzsfgpuntowtjdw5pgn4qhvsdp4mqqg@nrlek5vmisbu Regards, Kuan-Wei Kuan-Wei Chiu (13): perf/core: Fix several typos bcache: Fix typo bcachefs: Fix typo lib min_heap: Add type safe interface lib min_heap: Add min_heap_init() lib min_heap: Add min_heap_peek() lib min_heap: Add min_heap_full() lib min_heap: Add args for min_heap_callbacks lib min_heap: Update min_heap_push() and min_heap_pop() to return bool values bcache: Remove heap-related macros and switch to generic min_heap lib min_heap: Add min_heap_del() lib min_heap: Add min_heap_sift_up() bcachefs: Remove heap-related macros and switch to generic min_heap drivers/md/bcache/alloc.c | 66 ++++++++---- drivers/md/bcache/bcache.h | 2 +- drivers/md/bcache/bset.c | 73 ++++++++----- drivers/md/bcache/bset.h | 38 ++++--- drivers/md/bcache/btree.c | 27 ++++- drivers/md/bcache/extents.c | 44 ++++---- drivers/md/bcache/movinggc.c | 40 ++++++-- drivers/md/bcache/super.c | 16 +++ drivers/md/bcache/sysfs.c | 3 + drivers/md/bcache/util.c | 2 +- drivers/md/bcache/util.h | 81 +-------------- drivers/md/dm-vdo/repair.c | 29 +++--- drivers/md/dm-vdo/slab-depot.c | 21 ++-- fs/bcachefs/clock.c | 53 +++++++--- fs/bcachefs/clock_types.h | 2 +- fs/bcachefs/ec.c | 99 +++++++++++------- fs/bcachefs/ec_types.h | 2 +- fs/bcachefs/util.c | 2 +- fs/bcachefs/util.h | 127 ++--------------------- include/linux/min_heap.h | 180 ++++++++++++++++++++++++++------- kernel/events/core.c | 53 +++++----- lib/test_min_heap.c | 75 +++++++------- 22 files changed, 565 insertions(+), 470 deletions(-)