[0/3] dm-delay synchronization cleanup

Message

Benjamin Marzinski May 7, 2024, 9:16 p.m. UTC

This patchset fixes a possible crash in delay_dtr() caused by the
delay_timer queueing work on a destroyed workqueue. It also cuts down
on the amount of locking and waiting the dm-delay does.

Benjamin Marzinski (3):
  dm-delay: fix workqueue delay_timer race
  dm-delay: change locking to avoid contention
  dm-delay: remove timer_lock

 drivers/md/dm-delay.c | 52 +++++++++++++++++++++++--------------------
 1 file changed, 28 insertions(+), 24 deletions(-)

Comments

Mike Snitzer May 9, 2024, 2:24 p.m. UTC | #1

On Tue, May 07, 2024 at 05:16:22PM -0400, Benjamin Marzinski wrote:
> This patchset fixes a possible crash in delay_dtr() caused by the
> delay_timer queueing work on a destroyed workqueue. It also cuts down
> on the amount of locking and waiting the dm-delay does.
> 
> Benjamin Marzinski (3):
>   dm-delay: fix workqueue delay_timer race
>   dm-delay: change locking to avoid contention
>   dm-delay: remove timer_lock
> 
>  drivers/md/dm-delay.c | 52 +++++++++++++++++++++++--------------------
>  1 file changed, 28 insertions(+), 24 deletions(-)
> 
> -- 
> 2.45.0
> 
> 

Hey Ben,

I just staged 5 dm-delay patches in dm-6.10. 1 from Joel and 4 from
you.  Please confirm this is what you expected and looks good:
https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/log/?h=dm-6.10

Thanks,
Mike

Benjamin Marzinski May 9, 2024, 4:07 p.m. UTC | #2

On Thu, May 09, 2024 at 10:24:52AM -0400, Mike Snitzer wrote:
> On Tue, May 07, 2024 at 05:16:22PM -0400, Benjamin Marzinski wrote:
> > This patchset fixes a possible crash in delay_dtr() caused by the
> > delay_timer queueing work on a destroyed workqueue. It also cuts down
> > on the amount of locking and waiting the dm-delay does.
> > 
> > Benjamin Marzinski (3):
> >   dm-delay: fix workqueue delay_timer race
> >   dm-delay: change locking to avoid contention
> >   dm-delay: remove timer_lock
> > 
> >  drivers/md/dm-delay.c | 52 +++++++++++++++++++++++--------------------
> >  1 file changed, 28 insertions(+), 24 deletions(-)
> > 
> > -- 
> > 2.45.0
> > 
> > 
> 
> Hey Ben,
> 
> I just staged 5 dm-delay patches in dm-6.10. 1 from Joel and 4 from
> you.  Please confirm this is what you expected and looks good:
> https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/log/?h=dm-6.10

Well, I was half expecting to be told that it's kinda pointless to
optimize a target whoses purpose is to slow things down, but yeah, this
matches my dev branch.

Thanks.
-Ben

> 
> Thanks,
> Mike