diff mbox

DM RAID: Remove duplicate code.

Message ID 1340700941.19015.25.camel@f16 (mailing list archive)
State Deferred, archived
Headers show

Commit Message

Jonthan Brassow June 26, 2012, 8:55 a.m. UTC
dm-raid: Remove duplicate code.

Code must have gotten pasted in twice somehow.  Remove redundant chunk.

Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>



--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Comments

Alasdair G Kergon July 4, 2012, 1:14 a.m. UTC | #1
On Tue, Jun 26, 2012 at 03:55:41AM -0500, Jon Brassow wrote:
> dm-raid: Remove duplicate code.
> Code must have gotten pasted in twice somehow.  Remove redundant chunk.
 
I think that change is already in linux-next.

Alasdair

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Jonthan Brassow July 4, 2012, 4:02 a.m. UTC | #2
On Jul 3, 2012, at 8:14 PM, Alasdair G Kergon wrote:

> On Tue, Jun 26, 2012 at 03:55:41AM -0500, Jon Brassow wrote:
>> dm-raid: Remove duplicate code.
>> Code must have gotten pasted in twice somehow.  Remove redundant chunk.
> 
> I think that change is already in linux-next.

yup, in dm-support-non-power-of-two-target-max_io_len.patch.

Thanks,
 brassow

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
diff mbox

Patch

Index: linux-upstream/drivers/md/dm-raid.c
===================================================================
--- linux-upstream.orig/drivers/md/dm-raid.c
+++ linux-upstream/drivers/md/dm-raid.c
@@ -526,11 +526,6 @@  static int parse_raid_params(struct raid
 	else
 		rs->ti->split_io = region_size;
 
-	if (rs->md.chunk_sectors)
-		rs->ti->split_io = rs->md.chunk_sectors;
-	else
-		rs->ti->split_io = region_size;
-
 	/* Assume there are no metadata devices until the drives are parsed */
 	rs->md.persistent = 0;
 	rs->md.external = 1;