diff mbox

dm raid: don't allow "write behind" with raid4/5/6

Message ID 1480010024-17941-1-git-send-email-heinzm@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Mike Snitzer
Headers show

Commit Message

Heinz Mauelshagen Nov. 24, 2016, 5:53 p.m. UTC 
From: Heinz Mauelshagen <heinzm@redhat.com>

Only the md raid1 personality supports setting a maximum number
of "write behind" write ios on any legs set "write mostly".
"write mostly" enhances throughput with slow links/disks.

Technically the "write behind" value is a write intent bitmap
property only being respected by the raid1 personality. It allows
a maximum number of "write behind" writes to any "write mostly"
raid1 mirror legs to be delayed and reads from such legs avoided.

No other MD personalities supported via dm-raid types make
use of "write behind", thus setting this property is superfluous;
it wouldn't cause harm but it is correct to reject it.

Patch removes CTR_FLAG_MAX_WRITE_BEHIND from
raid4/5/6 valid flags allowed.

No bz is related, I came across it during review.

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
---
 drivers/md/dm-raid.c | 2 --
 1 file changed, 2 deletions(-)
diff mbox

Patch

diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 698b03e..9d5c6bb 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -160,7 +160,6 @@  struct raid_dev {
 				 CTR_FLAG_DAEMON_SLEEP | \
 				 CTR_FLAG_MIN_RECOVERY_RATE | \
 				 CTR_FLAG_MAX_RECOVERY_RATE | \
-				 CTR_FLAG_MAX_WRITE_BEHIND | \
 				 CTR_FLAG_STRIPE_CACHE | \
 				 CTR_FLAG_REGION_SIZE | \
 				 CTR_FLAG_DELTA_DISKS | \
@@ -171,7 +170,6 @@  struct raid_dev {
 				 CTR_FLAG_DAEMON_SLEEP | \
 				 CTR_FLAG_MIN_RECOVERY_RATE | \
 				 CTR_FLAG_MAX_RECOVERY_RATE | \
-				 CTR_FLAG_MAX_WRITE_BEHIND | \
 				 CTR_FLAG_STRIPE_CACHE | \
 				 CTR_FLAG_REGION_SIZE | \
 				 CTR_FLAG_DELTA_DISKS | \