From patchwork Mon Mar 7 05:19:39 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: bmarzins@sourceware.org X-Patchwork-Id: 614571 Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p275MovF018779 for ; Mon, 7 Mar 2011 05:23:11 GMT Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p275Jt8k028366; Mon, 7 Mar 2011 00:19:57 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p275JtUR015511 for ; Mon, 7 Mar 2011 00:19:55 -0500 Received: from mx1.redhat.com (ext-mx12.extmail.prod.ext.phx2.redhat.com [10.5.110.17]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p275JoTY020542 for ; Mon, 7 Mar 2011 00:19:50 -0500 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by mx1.redhat.com (8.14.4/8.14.4) with SMTP id p275Jfax005776 for ; Mon, 7 Mar 2011 00:19:41 -0500 Received: (qmail 24611 invoked by uid 9475); 7 Mar 2011 05:19:39 -0000 Date: 7 Mar 2011 05:19:39 -0000 Message-ID: <20110307051939.24609.qmail@sourceware.org> From: bmarzins@sourceware.org To: dm-cvs@sourceware.org, dm-devel@redhat.com X-RedHat-Spam-Score: -2.31 (RCVD_IN_DNSWL_MED,T_RP_MATCHES_RCVD) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-Scanned-By: MIMEDefang 2.68 on 10.5.110.17 X-loop: dm-devel@redhat.com Subject: [dm-devel] multipath-tools ./multipath.conf.defaults kpar ... X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Mon, 07 Mar 2011 05:23:11 +0000 (UTC) --- multipath-tools/multipath.conf.defaults 2010/11/12 20:17:09 1.5.4.28 +++ multipath-tools/multipath.conf.defaults 2011/03/07 05:19:36 1.5.4.29 @@ -81,7 +81,7 @@ # path_grouping_policy group_by_prio # failback immediate # rr_weight uniform -# no_path_retry 12 +# no_path_retry 18 # rr_min_io 100 # path_checker tur # } @@ -100,7 +100,35 @@ # } # device { # vendor "HP" -# product "MSA2012sa|MSA23(12|24)(fc|i|sa)|MSA2000s VOLUME" +# product "MSA2012sa|MSA2312sa|MSA2324sa" +# getuid_callout "/sbin/scsi_id -g -u -n -s /block/%n" +# prio_callout "/sbin/mpath_prio_alua /dev/%n" +# features "0" +# hardware_handler "0" +# path_grouping_policy group_by_prio +# failback immediate +# rr_weight uniform +# no_path_retry 18 +# rr_min_io 100 +# path_checker tur +# } +# device { +# vendor "HP" +# product "MSA2312fc|MSA2324fc|MSA2312i|MSA2324i|MSA2000s VOLUME" +# getuid_callout "/sbin/scsi_id -g -u -s /block/%n" +# prio_callout "/sbin/mpath_prio_alua /dev/%n" +# features "0" +# hardware_handler "0" +# path_grouping_policy group_by_prio +# failback immediate +# rr_weight uniform +# no_path_retry 18 +# rr_min_io 100 +# path_checker tur +# } +# device { +# vendor "HP" +# product "P2000 G3 FC" # getuid_callout "/sbin/scsi_id -g -u -s /block/%n" # prio_callout "/sbin/mpath_prio_alua /dev/%n" # features "0" @@ -122,7 +150,21 @@ # path_grouping_policy group_by_prio # failback immediate # rr_weight uniform -# no_path_retry 12 +# no_path_retry 18 +# rr_min_io 100 +# path_checker tur +# } +# device { +# vendor "HP" +# product "HSVX740" +# getuid_callout "/sbin/scsi_id -g -u -s /block/%n" +# prio_callout "/sbin/mpath_prio_alua /dev/%n" +# features "0" +# hardware_handler "0" +# path_grouping_policy group_by_prio +# failback immediate +# rr_weight uniform +# no_path_retry 18 # rr_min_io 100 # path_checker tur # } @@ -146,6 +188,7 @@ # path_grouping_policy multibus # failback immediate # rr_weight uniform +# no_path_retry 18 # rr_min_io 1000 # path_checker tur # } --- multipath-tools/kpartx/kpartx.c 2009/10/01 22:53:11 1.9.2.3 +++ multipath-tools/kpartx/kpartx.c 2011/03/07 05:19:37 1.9.2.4 @@ -195,6 +195,7 @@ char *uuid = NULL; int loopro = 0; int hotplug = 0; + int loopcreated = 0; struct stat buf; initpts(); @@ -298,6 +299,7 @@ fprintf(stderr, "can't set up loop\n"); exit (1); } + loopcreated = 1; } device = loopdev; } @@ -369,6 +371,15 @@ slices[j].size, device, slices[j].start); } + if (loopcreated && S_ISREG (buf.st_mode)) { + if (del_loop(device)) { + if (verbose) + printf("can't del loop : %s\n", + device); + exit(1); + } + printf("loop deleted : %s\n", device); + } break; case DELETE: --- multipath-tools/libmultipath/hwtable.c 2010/11/12 20:17:12 1.20.2.34 +++ multipath-tools/libmultipath/hwtable.c 2011/03/07 05:19:38 1.20.2.35 @@ -118,7 +118,7 @@ .pgpolicy = GROUP_BY_PRIO, .pgfailback = -FAILBACK_IMMEDIATE, .rr_weight = RR_WEIGHT_NONE, - .no_path_retry = 12, + .no_path_retry = 18, .minio = 100, .checker_name = TUR, }, @@ -139,9 +139,41 @@ .checker_name = TUR, }, { - /* HP MSA2000 product family with new firmware */ + /* HP MSA2000sa product family with new firmware */ + .vendor = "HP", + .product = "MSA2012sa|MSA2312sa|MSA2324sa", + .getuid = "/sbin/scsi_id -g -u -n -s /block/%n", + .getprio = "/sbin/mpath_prio_alua /dev/%n", + .features = DEFAULT_FEATURES, + .hwhandler = DEFAULT_HWHANDLER, + .selector = DEFAULT_SELECTOR, + .pgpolicy = GROUP_BY_PRIO, + .pgfailback = -FAILBACK_IMMEDIATE, + .rr_weight = RR_WEIGHT_NONE, + .no_path_retry = 18, + .minio = 100, + .checker_name = TUR, + }, + { + /* HP MSA2000fc and MSA2000i product family with new firmware */ + .vendor = "HP", + .product = "MSA2312fc|MSA2324fc|MSA2312i|MSA2324i|MSA2000s VOLUME", + .getuid = DEFAULT_GETUID, + .getprio = "/sbin/mpath_prio_alua /dev/%n", + .features = DEFAULT_FEATURES, + .hwhandler = DEFAULT_HWHANDLER, + .selector = DEFAULT_SELECTOR, + .pgpolicy = GROUP_BY_PRIO, + .pgfailback = -FAILBACK_IMMEDIATE, + .rr_weight = RR_WEIGHT_NONE, + .no_path_retry = 18, + .minio = 100, + .checker_name = TUR, + }, + { + /* HP P2000 product family */ .vendor = "HP", - .product = "MSA2012sa|MSA23(12|24)(fc|i|sa)|MSA2000s VOLUME", + .product = "P2000 G3 FC", .getuid = DEFAULT_GETUID, .getprio = "/sbin/mpath_prio_alua /dev/%n", .features = DEFAULT_FEATURES, @@ -155,7 +187,7 @@ .checker_name = TUR, }, { - /* HP SVSP */ + /* HP SVSP Active-Standby */ .vendor = "HP", .product = "HSVX700", .getuid = DEFAULT_GETUID, @@ -166,11 +198,27 @@ .pgpolicy = GROUP_BY_PRIO, .pgfailback = -FAILBACK_IMMEDIATE, .rr_weight = RR_WEIGHT_NONE, - .no_path_retry = 12, + .no_path_retry = 18, .minio = 100, .checker_name = TUR, }, { + /* HP SVSP Active-Active*/ + .vendor = "HP", + .product = "HSVX740", + .getuid = DEFAULT_GETUID, + .getprio = "/sbin/mpath_prio_alua /dev/%n", + .features = DEFAULT_FEATURES, + .hwhandler = DEFAULT_HWHANDLER, + .selector = DEFAULT_SELECTOR, + .pgpolicy = GROUP_BY_PRIO, + .pgfailback = -FAILBACK_IMMEDIATE, + .rr_weight = RR_WEIGHT_NONE, + .no_path_retry = 18, + .minio = 100, + .checker_name = TUR, + }, + { .vendor = "HP", .product = "A6189A", .getuid = DEFAULT_GETUID, @@ -313,7 +361,7 @@ .pgpolicy = MULTIBUS, .pgfailback = -FAILBACK_IMMEDIATE, .rr_weight = RR_WEIGHT_NONE, - .no_path_retry = 12, + .no_path_retry = 18, .minio = DEFAULT_MINIO, .checker_name = TUR, }, --- multipath-tools/libmultipath/parser.c 2010/08/27 21:02:08 1.18.2.2 +++ multipath-tools/libmultipath/parser.c 2011/03/07 05:19:38 1.18.2.3 @@ -2,7 +2,7 @@ * Part: Configuration file parser/reader. Place into the dynamic * data structure representation the conf file * - * Version: $Id: parser.c,v 1.18.2.2 2010/08/27 21:02:08 bmarzins Exp $ + * Version: $Id: parser.c,v 1.18.2.3 2011/03/07 05:19:38 bmarzins Exp $ * * Author: Alexandre Cassen, * @@ -501,7 +501,7 @@ } } if (i >= VECTOR_SIZE(keywords)) - condlog(1, "mulipath.conf line %d, invalid keyword: %s", + condlog(1, "multipath.conf line %d, invalid keyword: %s", line_nr, str); free_strvec(strvec); --- multipath-tools/multipathd/main.c 2011/02/18 18:27:00 1.69.2.32 +++ multipath-tools/multipathd/main.c 2011/03/07 05:19:38 1.69.2.33 @@ -1356,7 +1356,8 @@ strncmp(mnt, "/dev", 4) == 0 || strncmp(mnt, "/sys", 4) == 0 || strcmp(mnt, "/var") == 0 || strncmp(mnt, "/var/lib", 8) == 0 || strncmp(mnt, "/var/run", 8) == 0 || strncmp(mnt, "/lib", 4) == 0 || - strncmp(mnt, "/lib64", 6) == 0 || strncmp(mnt, "/usr/lib64", 10) == 0) + strncmp(mnt, "/lib64", 6) == 0 || strncmp(mnt, "/usr/lib64", 10) == 0 || + strncmp(mnt, "/ram", 4) == 0) continue; if (umount2(mnt, MNT_DETACH) < 0 && errno != ENOENT) { condlog(0, "failed to umount '%s' (%s). skipping", mnt, strerror(errno));