| Message ID | 20191108015702.233102-8-damien.lemoal@wdc.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Mike Snitzer |
| Headers | show |
| Series | Zoned block device enhancements and zone report rework | expand |
On 11/8/19 2:57 AM, Damien Le Moal wrote: > For a null_blk device with zoned mode enabled, the number of > conventional zones can be configured through configfs with the > zone_nr_conv parameter. Add this missing parameter in the features > string. > > Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> > --- > drivers/block/null_blk_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/null_blk_main.c b/drivers/block/null_blk_main.c > index 2687eb36441c..27fb34d7da31 100644 > --- a/drivers/block/null_blk_main.c > +++ b/drivers/block/null_blk_main.c > @@ -467,7 +467,7 @@ nullb_group_drop_item(struct config_group *group, struct config_item *item) > > static ssize_t memb_group_features_show(struct config_item *item, char *page) > { > - return snprintf(page, PAGE_SIZE, "memory_backed,discard,bandwidth,cache,badblocks,zoned,zone_size\n"); > + return snprintf(page, PAGE_SIZE, "memory_backed,discard,bandwidth,cache,badblocks,zoned,zone_size,zone_nr_conv\n"); > } > > CONFIGFS_ATTR_RO(memb_group_, features); > Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes
Looks good to me. Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> On 11/07/2019 05:57 PM, Damien Le Moal wrote: > For a null_blk device with zoned mode enabled, the number of > conventional zones can be configured through configfs with the > zone_nr_conv parameter. Add this missing parameter in the features > string. > -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
diff --git a/drivers/block/null_blk_main.c b/drivers/block/null_blk_main.c index 2687eb36441c..27fb34d7da31 100644 --- a/drivers/block/null_blk_main.c +++ b/drivers/block/null_blk_main.c @@ -467,7 +467,7 @@ nullb_group_drop_item(struct config_group *group, struct config_item *item) static ssize_t memb_group_features_show(struct config_item *item, char *page) { - return snprintf(page, PAGE_SIZE, "memory_backed,discard,bandwidth,cache,badblocks,zoned,zone_size\n"); + return snprintf(page, PAGE_SIZE, "memory_backed,discard,bandwidth,cache,badblocks,zoned,zone_size,zone_nr_conv\n"); } CONFIGFS_ATTR_RO(memb_group_, features);
For a null_blk device with zoned mode enabled, the number of conventional zones can be configured through configfs with the zone_nr_conv parameter. Add this missing parameter in the features string. Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> --- drivers/block/null_blk_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)