| Message ID | 20200731224645.89483-1-jdorminy@redhat.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Mike Snitzer |
| Headers | show |
| Series | dm-ebs: Fix incorrect checking for REQ_OP_FLUSH. | expand |
Acked-by: Heinz Mauelshagen <heinzm@redhat.com> On 8/1/20 12:46 AM, John Dorminy wrote: > REQ_OP_FLUSH was being treated as a flag, but the operation > part of bio->bi_opf must be treated as a whole. Change to > accessing the operation part via bio_op(bio) and checking > for equality. > > Signed-off-by: John Dorminy <jdorminy@redhat.com> > --- > drivers/md/dm-ebs-target.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/md/dm-ebs-target.c b/drivers/md/dm-ebs-target.c > index 44451276f128..cb85610527c2 100644 > --- a/drivers/md/dm-ebs-target.c > +++ b/drivers/md/dm-ebs-target.c > @@ -363,7 +363,7 @@ static int ebs_map(struct dm_target *ti, struct bio *bio) > bio_set_dev(bio, ec->dev->bdev); > bio->bi_iter.bi_sector = ec->start + dm_target_offset(ti, bio->bi_iter.bi_sector); > > - if (unlikely(bio->bi_opf & REQ_OP_FLUSH)) > + if (unlikely(bio_op(bio) == REQ_OP_FLUSH)) > return DM_MAPIO_REMAPPED; > /* > * Only queue for bufio processing in case of partial -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
diff --git a/drivers/md/dm-ebs-target.c b/drivers/md/dm-ebs-target.c index 44451276f128..cb85610527c2 100644 --- a/drivers/md/dm-ebs-target.c +++ b/drivers/md/dm-ebs-target.c @@ -363,7 +363,7 @@ static int ebs_map(struct dm_target *ti, struct bio *bio) bio_set_dev(bio, ec->dev->bdev); bio->bi_iter.bi_sector = ec->start + dm_target_offset(ti, bio->bi_iter.bi_sector); - if (unlikely(bio->bi_opf & REQ_OP_FLUSH)) + if (unlikely(bio_op(bio) == REQ_OP_FLUSH)) return DM_MAPIO_REMAPPED; /* * Only queue for bufio processing in case of partial or overlapping buffers
REQ_OP_FLUSH was being treated as a flag, but the operation part of bio->bi_opf must be treated as a whole. Change to accessing the operation part via bio_op(bio) and checking for equality. Signed-off-by: John Dorminy <jdorminy@redhat.com> --- drivers/md/dm-ebs-target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)