diff mbox series

multipath-tools: add info about HPE Alletra 6000 and 9000

Message ID 20210603212402.5559-1-xose.vazquez@gmail.com (mailing list archive)
State Not Applicable, archived
Delegated to: christophe varoqui
Headers show
Series multipath-tools: add info about HPE Alletra 6000 and 9000 | expand

Commit Message

Xose Vazquez Perez June 3, 2021, 9:24 p.m. UTC
Cc: Martin Wilck <mwilck@suse.com>
Cc: Benjamin Marzinski <bmarzins@redhat.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: DM-DEVEL ML <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 README.alua                | 2 +-
 libmultipath/hwtable.c     | 4 ++--
 multipath/multipath.conf.5 | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

Comments

Martin Wilck June 4, 2021, 12:14 p.m. UTC | #1
On Do, 2021-06-03 at 23:24 +0200, Xose Vazquez Perez wrote:
> Cc: Martin Wilck <mwilck@suse.com>
> Cc: Benjamin Marzinski <bmarzins@redhat.com>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: DM-DEVEL ML <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
>  README.alua                | 2 +-
>  libmultipath/hwtable.c     | 4 ++--
>  multipath/multipath.conf.5 | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/README.alua b/README.alua
> index b15eb487..5d2b1c64 100644
> --- a/README.alua
> +++ b/README.alua
> @@ -6,7 +6,7 @@ To enable ALUA, the following options should be
> changed:
>  - EMC CLARiiON/VNX:
>     "Failover Mode" should be changed to "4" or "Active-Active
> mode(ALUA)-failover mode 4"
>  
> -- HPE 3PAR:
> +- HPE 3PAR, Primera, and Alletra 9000:
>     "Host:" should be changed to "Generic-ALUA Persona 2 (UARepLun,
> SESLun, ALUA)".
>  
>  - Promise VTrak/Vess:
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index 58fa7387..e884d8c7 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -107,7 +107,7 @@ static struct hwentry default_hw[] = {
>          * HPE
>          */
>         {
> -               /* 3PAR / Primera */
> +               /* 3PAR / Primera / Alletra 9000 */
>                 .vendor        = "3PARdata",
>                 .product       = "VV",
>                 .pgpolicy      = GROUP_BY_PRIO,
> @@ -225,7 +225,7 @@ static struct hwentry default_hw[] = {
>                 .prio_name     = PRIO_ALUA,
>         },
>         {
> -               /* Nimble Storage */
> +               /* Nimble Storage / HPE Alletra 6000 */
>                 .vendor        = "Nimble",
>                 .product       = "Server",
>                 .hwhandler     = "1 alua",
> diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
> index 064e4826..c2b642dc 100644
> --- a/multipath/multipath.conf.5
> +++ b/multipath/multipath.conf.5
> @@ -1540,7 +1540,7 @@ The vpd page abbreviation can be found by
> running \fIsg_vpd -e\fR. multipathd
>  will use this information to gather device specific information that
> can be
>  displayed with the \fI%g\fR wilcard for the \fImultipathd show maps
> format\fR
>  and \fImultipathd show paths format\fR commands. Currently only the
> -\fBhp3par\fR vpd page is supported.
> +\fBhp3par\fR vpd page(for HPE 3PAR, Primera, and Alletra 9000) is
> supported.

Nack. Array-specific info like this doesn't belong in the man page.
The rest of the patch is fine.

Regards
Martin


>  .TP
>  .B hardware_handler
>  The hardware handler to use for this device type.



--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
diff mbox series

Patch

diff --git a/README.alua b/README.alua
index b15eb487..5d2b1c64 100644
--- a/README.alua
+++ b/README.alua
@@ -6,7 +6,7 @@  To enable ALUA, the following options should be changed:
 - EMC CLARiiON/VNX:
    "Failover Mode" should be changed to "4" or "Active-Active mode(ALUA)-failover mode 4"
 
-- HPE 3PAR:
+- HPE 3PAR, Primera, and Alletra 9000:
    "Host:" should be changed to "Generic-ALUA Persona 2 (UARepLun, SESLun, ALUA)".
 
 - Promise VTrak/Vess:
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 58fa7387..e884d8c7 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -107,7 +107,7 @@  static struct hwentry default_hw[] = {
 	 * HPE
 	 */
 	{
-		/* 3PAR / Primera */
+		/* 3PAR / Primera / Alletra 9000 */
 		.vendor        = "3PARdata",
 		.product       = "VV",
 		.pgpolicy      = GROUP_BY_PRIO,
@@ -225,7 +225,7 @@  static struct hwentry default_hw[] = {
 		.prio_name     = PRIO_ALUA,
 	},
 	{
-		/* Nimble Storage */
+		/* Nimble Storage / HPE Alletra 6000 */
 		.vendor        = "Nimble",
 		.product       = "Server",
 		.hwhandler     = "1 alua",
diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
index 064e4826..c2b642dc 100644
--- a/multipath/multipath.conf.5
+++ b/multipath/multipath.conf.5
@@ -1540,7 +1540,7 @@  The vpd page abbreviation can be found by running \fIsg_vpd -e\fR. multipathd
 will use this information to gather device specific information that can be
 displayed with the \fI%g\fR wilcard for the \fImultipathd show maps format\fR
 and \fImultipathd show paths format\fR commands. Currently only the
-\fBhp3par\fR vpd page is supported.
+\fBhp3par\fR vpd page(for HPE 3PAR, Primera, and Alletra 9000) is supported.
 .TP
 .B hardware_handler
 The hardware handler to use for this device type.