| Message ID | 20230315170209.13886-1-xose.vazquez@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | christophe varoqui |
| Headers | show |
| Series | multipath-tools: delete multipathd/multipathc.d file when "make clean" | expand |
On Wed, Mar 15, 2023 at 06:02:09PM +0100, Xose Vazquez Perez wrote: > Cc: Martin Wilck <mwilck@suse.com> > Cc: Benjamin Marzinski <bmarzins@redhat.com> > Cc: Christophe Varoqui <christophe.varoqui@opensvc.com> > Cc: DM-DEVEL ML <dm-devel@redhat.com> > Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com> Shouldn't this also go in the include line? -Ben > --- > multipathd/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/multipathd/Makefile b/multipathd/Makefile > index 9d531329..ba879102 100644 > --- a/multipathd/Makefile > +++ b/multipathd/Makefile > @@ -79,7 +79,7 @@ uninstall: > $(Q)$(RM) $(DESTDIR)$(unitdir)/$(EXEC).socket > > clean: dep_clean > - $(Q)$(RM) core *.o $(EXEC) $(CLI) > + $(Q)$(RM) core *.o $(EXEC) $(CLI) multipathc.d > > include $(wildcard $(OBJS:.o=.d)) > > -- > 2.40.0 -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
On Wed, 2023-03-15 at 17:01 -0500, Benjamin Marzinski wrote: > On Wed, Mar 15, 2023 at 06:02:09PM +0100, Xose Vazquez Perez wrote: > > Cc: Martin Wilck <mwilck@suse.com> > > Cc: Benjamin Marzinski <bmarzins@redhat.com> > > Cc: Christophe Varoqui <christophe.varoqui@opensvc.com> > > Cc: DM-DEVEL ML <dm-devel@redhat.com> > > Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com> > > Shouldn't this also go in the include line? Right. And the dep_clean target needs to be fixed. We seem to have more issues like this. I will post a patch. Martin -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
diff --git a/multipathd/Makefile b/multipathd/Makefile index 9d531329..ba879102 100644 --- a/multipathd/Makefile +++ b/multipathd/Makefile @@ -79,7 +79,7 @@ uninstall: $(Q)$(RM) $(DESTDIR)$(unitdir)/$(EXEC).socket clean: dep_clean - $(Q)$(RM) core *.o $(EXEC) $(CLI) + $(Q)$(RM) core *.o $(EXEC) $(CLI) multipathc.d include $(wildcard $(OBJS:.o=.d))
Cc: Martin Wilck <mwilck@suse.com> Cc: Benjamin Marzinski <bmarzins@redhat.com> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com> Cc: DM-DEVEL ML <dm-devel@redhat.com> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com> --- multipathd/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)