[v4,19/22] block: mark bio_add_page as __must_check

Message ID	20230420100501.32981-20-jth@kernel.org (mailing list archive)
State	Superseded, archived
Delegated to:	Mike Snitzer
Headers	show Return-Path: <dm-devel-bounces@redhat.com> From: Johannes Thumshirn <jth@kernel.org> To: axboe@kernel.dk Date: Thu, 20 Apr 2023 12:04:58 +0200 Message-Id: <20230420100501.32981-20-jth@kernel.org> In-Reply-To: <20230420100501.32981-1-jth@kernel.org> References: <20230420100501.32981-1-jth@kernel.org> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false Subject: [dm-devel] [PATCH v4 19/22] block: mark bio_add_page as __must_check Precedence: list Cc: shaggy@kernel.org, jfs-discussion@lists.sourceforge.net, linux-mm@kvack.org, dm-devel@redhat.com, hch@lst.de, agruenba@redhat.com, Damien Le Moal <damien.lemoal@opensource.wdc.com>, willy@infradead.org, cluster-devel@redhat.com, kch@nvidia.com, snitzer@kernel.org, ming.lei@redhat.com, linux-block@vger.kernel.org, rpeterso@redhat.com, dsterba@suse.com, linux-raid@vger.kernel.org, damien.lemoal@wdc.com, song@kernel.org, johannes.thumshirn@wdc.com, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" <dm-devel-bounces@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit
Series	bio: check return values of bio_add_page \| expand [v4,00/22] bio: check return values of bio_add_page [v4,01/22] swap: use __bio_add_page to add page to bio [v4,02/22] drbd: use __bio_add_page to add page to bio [v4,03/22] dm: dm-zoned: use __bio_add_page for adding single metadata page [v4,04/22] fs: buffer: use __bio_add_page to add single page to bio [v4,05/22] md: use __bio_add_page to add single page [v4,06/22] md: raid5-log: use __bio_add_page to add single page [v4,07/22] md: raid5: use __bio_add_page to add single page to new bio [v4,08/22] btrfs: repair: use __bio_add_page for adding single page [v4,09/22] btrfs: raid56: use __bio_add_page to add single page [v4,10/22] jfs: logmgr: use __bio_add_page to add single page to bio [v4,11/22] gfs2: use __bio_add_page for adding single page to bio [v4,12/22] zonefs: use __bio_add_page for adding single page to bio [v4,13/22] zram: use __bio_add_page for adding single page to bio [v4,14/22] floppy: use __bio_add_page for adding single page to bio [v4,15/22] md: check for failure when adding pages in alloc_behind_master_bio [v4,16/22] md: raid1: use __bio_add_page for adding single page to bio [v4,17/22] md: raid1: check if adding pages to resync bio fails [v4,18/22] dm-crypt: check if adding pages to clone bio fails [v4,19/22] block: mark bio_add_page as __must_check [v4,20/22] block: add __bio_add_folio [v4,21/22] fs: iomap: use __bio_add_folio where possible [v4,22/22] block: mark bio_add_folio as __must_check

Message ID

20230420100501.32981-20-jth@kernel.org (mailing list archive)

State

Superseded, archived

Delegated to:

Mike Snitzer

Headers

From: Johannes Thumshirn <jth@kernel.org>
To: axboe@kernel.dk
Date: Thu, 20 Apr 2023 12:04:58 +0200
Message-Id: <20230420100501.32981-20-jth@kernel.org>
In-Reply-To: <20230420100501.32981-1-jth@kernel.org>
References: <20230420100501.32981-1-jth@kernel.org>
MIME-Version: 1.0
Subject: [dm-devel] [PATCH v4 19/22] block: mark bio_add_page as __must_check
Precedence: list
Cc: shaggy@kernel.org, jfs-discussion@lists.sourceforge.net,
 linux-mm@kvack.org,
 dm-devel@redhat.com, hch@lst.de, agruenba@redhat.com,
 Damien Le Moal <damien.lemoal@opensource.wdc.com>, willy@infradead.org,
 cluster-devel@redhat.com, kch@nvidia.com, snitzer@kernel.org,
 ming.lei@redhat.com, linux-block@vger.kernel.org, rpeterso@redhat.com,
 dsterba@suse.com, linux-raid@vger.kernel.org, damien.lemoal@wdc.com,
 song@kernel.org, johannes.thumshirn@wdc.com, linux-fsdevel@vger.kernel.org,
 linux-btrfs@vger.kernel.org
Errors-To: dm-devel-bounces@redhat.com
Sender: "dm-devel" <dm-devel-bounces@redhat.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Series

bio: check return values of bio_add_page | expand

Commit Message

Johannes Thumshirn April 20, 2023, 10:04 a.m. UTC

From: Johannes Thumshirn <johannes.thumshirn@wdc.com>

Now that all users of bio_add_page check for the return value, mark
bio_add_page as __must_check.

Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 include/linux/bio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/bio.h b/include/linux/bio.h
index d766be7152e1..0f8a8d7a6384 100644
--- a/include/linux/bio.h
+++ b/include/linux/bio.h
@@ -465,7 +465,7 @@  extern void bio_uninit(struct bio *);
 void bio_reset(struct bio *bio, struct block_device *bdev, blk_opf_t opf);
 void bio_chain(struct bio *, struct bio *);
 
-int bio_add_page(struct bio *, struct page *, unsigned len, unsigned off);
+int __must_check bio_add_page(struct bio *, struct page *, unsigned len, unsigned off);
 bool bio_add_folio(struct bio *, struct folio *, size_t len, size_t off);
 extern int bio_add_pc_page(struct request_queue *, struct bio *, struct page *,
 			   unsigned int, unsigned int);

[v4,19/22] block: mark bio_add_page as __must_check

Commit Message

Patch