| Message ID | 20230901180235.23980-17-mwilck@suse.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | christophe varoqui |
| Headers | show |
| Series | multipath-tools: user-friendly names rework | expand |
On Fri, Sep 01, 2023 at 08:02:29PM +0200, mwilck@suse.com wrote: > From: Martin Wilck <mwilck@suse.com> > > The name of the temp file is unlikely to be helpful for uses, > and hard to predict in the unit test. Omit it. > Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com> > Signed-off-by: Martin Wilck <mwilck@suse.com> > --- > libmultipath/alias.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libmultipath/alias.c b/libmultipath/alias.c > index c26f37c..9ca5da8 100644 > --- a/libmultipath/alias.c > +++ b/libmultipath/alias.c > @@ -167,8 +167,7 @@ static int update_bindings_file(const Bindings *bindings, > rc = write_bindings_file(bindings, fd); > pthread_cleanup_pop(1); > if (rc == -1) { > - condlog(1, "failed to write new bindings file %s", > - tempname); > + condlog(1, "failed to write new bindings file"); > unlink(tempname); > return rc; > } > -- > 2.41.0 -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
diff --git a/libmultipath/alias.c b/libmultipath/alias.c index c26f37c..9ca5da8 100644 --- a/libmultipath/alias.c +++ b/libmultipath/alias.c @@ -167,8 +167,7 @@ static int update_bindings_file(const Bindings *bindings, rc = write_bindings_file(bindings, fd); pthread_cleanup_pop(1); if (rc == -1) { - condlog(1, "failed to write new bindings file %s", - tempname); + condlog(1, "failed to write new bindings file"); unlink(tempname); return rc; }