diff mbox series

Fix hwtable test after "libmultipath: don't bother to recheck timeout"

Message ID 20230901212439.11880-1-mwilck@suse.com (mailing list archive)
State New, archived
Headers show
Series Fix hwtable test after "libmultipath: don't bother to recheck timeout" | expand

Commit Message

Martin Wilck Sept. 1, 2023, 9:24 p.m. UTC
From: Martin Wilck <mwilck@suse.com>

The previous patch  "libmultipath: don't bother to recheck timeout"
causes sysfs_get_timeout() to be called less frequently. Adapt the
tests.

Signed-off-by: Martin Wilck <mwilck@suse.com>
---
 tests/test-lib.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Benjamin Marzinski Sept. 5, 2023, 9:44 p.m. UTC | #1
On Fri, Sep 01, 2023 at 11:24:39PM +0200, mwilck@suse.com wrote:
> From: Martin Wilck <mwilck@suse.com>
> 
> The previous patch  "libmultipath: don't bother to recheck timeout"
> causes sysfs_get_timeout() to be called less frequently. Adapt the
> tests.
> 
Oops.

Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
> Signed-off-by: Martin Wilck <mwilck@suse.com>
> ---
>  tests/test-lib.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/tests/test-lib.c b/tests/test-lib.c
> index 0bc49d5..f75ea31 100644
> --- a/tests/test-lib.c
> +++ b/tests/test-lib.c
> @@ -342,12 +342,6 @@ void mock_pathinfo(int mask, const struct mocked_path *mp)
>  			    mp->wwid);
>  	}
>  
> -	if (mask & DI_CHECKER) {
> -		/* get_state -> sysfs_get_timeout  */
> -		will_return(__wrap_udev_device_get_subsystem, "scsi");
> -		will_return(__wrap_udev_device_get_sysattr_value, "180");
> -	}
> -
>  	if (mask & DI_PRIO && mp->flags & NEED_SELECT_PRIO) {
>  
>  		/* sysfs_get_timeout, again (!?) */
> -- 
> 2.41.0
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
diff mbox series

Patch

diff --git a/tests/test-lib.c b/tests/test-lib.c
index 0bc49d5..f75ea31 100644
--- a/tests/test-lib.c
+++ b/tests/test-lib.c
@@ -342,12 +342,6 @@  void mock_pathinfo(int mask, const struct mocked_path *mp)
 			    mp->wwid);
 	}
 
-	if (mask & DI_CHECKER) {
-		/* get_state -> sysfs_get_timeout  */
-		will_return(__wrap_udev_device_get_subsystem, "scsi");
-		will_return(__wrap_udev_device_get_sysattr_value, "180");
-	}
-
 	if (mask & DI_PRIO && mp->flags & NEED_SELECT_PRIO) {
 
 		/* sysfs_get_timeout, again (!?) */