diff mbox

multipath-tools: Manual failback fix when priority changes

Message ID 47D23AD8469A2B448F33C24BD7A39BD90DBE8600@RTPMVEXC1-PRD.hq.netapp.com (mailing list archive)
State Deferred, archived
Headers show

Commit Message

babu moger May 27, 2011, 2:30 p.m. UTC 
Current code switches the path-group when there is a change in priority. However,
this is not the right thing to do when failback is set to manual. This patch fixes
this problem. Call update_path_groups only if failback is immediate.

Signed-off-by: Babu Moger <babu.moger@netapp.com>

---



--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
diff mbox

Patch

--- multipath-tools/multipathd/main.c.orig	2011-05-26 08:06:08.000000000 -0500
+++ multipath-tools/multipathd/main.c	2011-05-26 08:21:39.000000000 -0500
@@ -1189,7 +1189,8 @@  check_path (struct vectors * vecs, struc
 	condlog(4, "path prio refresh");
 
 	if (update_prio(pp, new_path_up) &&
-	    pp->mpp->pgpolicyfn == (pgpolicyfn *)group_by_prio)
+	    (pp->mpp->pgpolicyfn == (pgpolicyfn *)group_by_prio) &&
+	     pp->mpp->pgfailback == -FAILBACK_IMMEDIATE)
 		update_path_groups(pp->mpp, vecs, !new_path_up);
 	else if (need_switch_pathgroup(pp->mpp, 0)) {
 		if (pp->mpp->pgfailback > 0 &&