From patchwork Fri Jun 20 22:33:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Merla, ShivaKrishna" X-Patchwork-Id: 4399481 X-Patchwork-Delegate: christophe.varoqui@free.fr Return-Path: X-Original-To: patchwork-dm-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 765DABEEAA for ; Mon, 23 Jun 2014 07:06:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 49DB520172 for ; Mon, 23 Jun 2014 07:06:25 +0000 (UTC) Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by mail.kernel.org (Postfix) with ESMTP id 3FBB720122 for ; Mon, 23 Jun 2014 07:06:21 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s5N71g3w016013; Mon, 23 Jun 2014 03:01:45 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s5KMY4Xh002285 for ; Fri, 20 Jun 2014 18:34:04 -0400 Received: from mx1.redhat.com (ext-mx13.extmail.prod.ext.phx2.redhat.com [10.5.110.18]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5KMY3uZ001031 for ; Fri, 20 Jun 2014 18:34:04 -0400 Received: from mx11.netapp.com (mx11.netapp.com [216.240.18.76]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5KMXxCT013689 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=FAIL) for ; Fri, 20 Jun 2014 18:34:01 -0400 X-IronPort-AV: E=Sophos;i="5.01,517,1400050800"; d="scan'208";a="129918808" Received: from vmwexceht02-prd.hq.netapp.com ([10.106.76.240]) by mx11-out.netapp.com with ESMTP; 20 Jun 2014 15:33:59 -0700 Received: from HIOEXCMBX05-PRD.hq.netapp.com (10.122.105.38) by vmwexceht02-prd.hq.netapp.com (10.106.76.240) with Microsoft SMTP Server (TLS) id 14.3.123.3; Fri, 20 Jun 2014 15:33:58 -0700 Received: from HIOEXCMBX01-PRD.hq.netapp.com (10.122.105.34) by hioexcmbx05-prd.hq.netapp.com (10.122.105.38) with Microsoft SMTP Server (TLS) id 15.0.847.32; Fri, 20 Jun 2014 15:33:40 -0700 Received: from HIOEXCMBX01-PRD.hq.netapp.com ([10.122.105.34]) by hioexcmbx01-prd.hq.netapp.com ([10.122.105.34]) with mapi id 15.00.0847.030; Fri, 20 Jun 2014 15:33:40 -0700 From: "Merla, ShivaKrishna" To: "christophe.varoqui@opensvc.com" Thread-Topic: [PATCH]multipath: Wrong sysfs attribute used for iSCSI settings. Thread-Index: Ac+M13mzhfbLH5mnTperOs0nTj2WhA== Date: Fri, 20 Jun 2014 22:33:39 +0000 Message-ID: <47bff49ac3c742fc86a11b013a76e985@hioexcmbx01-prd.hq.netapp.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.122.56.79] MIME-Version: 1.0 X-RedHat-Spam-Score: -1.656 (BAYES_00, DCC_REPUT_00_12, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_SOFTFAIL, T_RP_MATCHES_RCVD) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Scanned-By: MIMEDefang 2.68 on 10.5.110.18 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id s5KMY4Xh002285 X-loop: dm-devel@redhat.com X-Mailman-Approved-At: Mon, 23 Jun 2014 03:01:42 -0400 Cc: "dm-devel@redhat.com" Subject: [dm-devel] [PATCH]multipath: Wrong sysfs attribute used for iSCSI settings. X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Wrong sysfs parameter used to configure iSCSI settings. /sys/class/iscsi_session/session/tgtname It's always /sys/class/iscsi_session/session/targetname This is the reason recovery_tmo was not getting set to fast_io_fail_tmo value for iscsi sessions. Signed-off-by: Shiva Krishna Merla --- libmultipath/discovery.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c index 786e1de..7bb0a33 100644 --- a/libmultipath/discovery.c +++ b/libmultipath/discovery.c @@ -289,7 +289,7 @@ sysfs_get_tgt_nodename (struct path *pp, char * node) if (tgtdev) { const char *value; - value = udev_device_get_sysattr_value(tgtdev, "tgtname"); + value = udev_device_get_sysattr_value(tgtdev, "targetname"); if (value) { pp->sg_id.proto_id = SCSI_PROTOCOL_ISCSI; pp->sg_id.transport_id = tgtid;