From patchwork Wed May 6 21:40:43 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "IKEDA, Munehiro" X-Patchwork-Id: 26262 Received: from hormel.redhat.com (hormel1.redhat.com [209.132.177.33]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n4R0VUcc011043 for ; Wed, 27 May 2009 00:31:33 GMT Received: from listman.util.phx.redhat.com (listman.util.phx.redhat.com [10.8.4.110]) by hormel.redhat.com (Postfix) with ESMTP id 3B3298E025A; Tue, 26 May 2009 20:31:32 -0400 (EDT) Received: from int-mx2.corp.redhat.com ([172.16.27.26]) by listman.util.phx.redhat.com (8.13.1/8.13.1) with ESMTP id n46Lg38J031730 for ; Wed, 6 May 2009 17:42:03 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n46Lg18F022562; Wed, 6 May 2009 17:42:02 -0400 Received: from localhost.localdomain (dhcp-100-2-140.bos.redhat.com [10.16.2.140]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n46Lg0f5010313; Wed, 6 May 2009 17:42:00 -0400 Message-ID: <4A0203DB.1090809@ds.jp.nec.com> Date: Wed, 06 May 2009 17:40:43 -0400 From: "IKEDA, Munehiro" User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: Vivek Goyal References: <1241553525-28095-1-git-send-email-vgoyal@redhat.com> <1241553525-28095-19-git-send-email-vgoyal@redhat.com> In-Reply-To: <1241553525-28095-19-git-send-email-vgoyal@redhat.com> X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 X-loop: dm-devel@redhat.com X-Mailman-Approved-At: Tue, 26 May 2009 20:31:16 -0400 Cc: dhaval@linux.vnet.ibm.com, snitzer@redhat.com, dm-devel@redhat.com, dpshah@google.com, jens.axboe@oracle.com, agk@redhat.com, balbir@linux.vnet.ibm.com, paolo.valente@unimore.it, guijianfeng@cn.fujitsu.com, fernando@oss.ntt.co.jp, mikew@google.com, jmoyer@redhat.com, nauman@google.com, righi.andrea@gmail.com, lizf@cn.fujitsu.com, fchecconi@gmail.com, s-uchida@ap.jp.nec.com, containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: [dm-devel] Re: [PATCH 18/18] io-controller: Debug hierarchical IO scheduling X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.5 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com Hi Vivek, Patching and compilation error occurred on the 18/18 patch. I know this is a patch for debug but report them in case. Vivek Goyal wrote: > @@ -2203,6 +2241,25 @@ EXPORT_SYMBOL(elv_get_slice_idle); > void elv_ioq_served(struct io_queue *ioq, bfq_service_t served) > { > entity_served(&ioq->entity, served, ioq->nr_sectors); Patch failed due to this line. I guess this should be entity_served(&ioq->entity, served); > + > +#ifdef CONFIG_DEBUG_GROUP_IOSCHED > + { > + struct elv_fq_data *efqd = ioq->efqd; > + char path[128]; > + struct io_group *iog = ioq_to_io_group(ioq); > + io_group_path(iog, path, sizeof(path)); > + elv_log_ioq(efqd, ioq, "ioq served: QSt=0x%lx QSs=0x%lx" > + " QTt=0x%lx QTs=0x%lx grp=%s GTt=0x%lx " > + " GTs=0x%lx rq_queued=%d", > + served, ioq->nr_sectors, > + ioq->entity.total_service, > + ioq->entity.total_sector_service, > + path, > + iog->entity.total_service, > + iog->entity.total_sector_service, > + ioq->nr_queued); > + } > +#endif > } Because io_entity::total_service and io_entity::total_sector_service are not defined, compilation failed if CONFIG_DEBUG_GROUP_IOSCHED=y here. (and everywhere referencing entity.total_service or entity.total_sector_service) They need to be defined like: Unfortunately I couldn't figure out where and how the members should be calculated, sorry. diff --git a/block/elevator-fq.h b/block/elevator-fq.h index 1ea4ff3..6d0a735 100644 --- a/block/elevator-fq.h +++ b/block/elevator-fq.h @@ -147,6 +147,10 @@ struct io_entity { unsigned short ioprio_class, new_ioprio_class; int ioprio_changed; + +#ifdef CONFIG_DEBUG_GROUP_IOSCHED + unsigned long total_service, total_sector_service; +#endif }; /*