From patchwork Fri Jun 5 09:17:07 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gui Jianfeng X-Patchwork-Id: 28156 Received: from hormel.redhat.com (hormel1.redhat.com [209.132.177.33]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n559IpDw030651 for ; Fri, 5 Jun 2009 09:18:51 GMT Received: from listman.util.phx.redhat.com (listman.util.phx.redhat.com [10.8.4.110]) by hormel.redhat.com (Postfix) with ESMTP id CCC9F6189F3; Fri, 5 Jun 2009 05:18:50 -0400 (EDT) Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by listman.util.phx.redhat.com (8.13.1/8.13.1) with ESMTP id n559ImFP005985 for ; Fri, 5 Jun 2009 05:18:48 -0400 Received: from mx3.redhat.com (mx3.redhat.com [172.16.48.32]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n559IkjE023498; Fri, 5 Jun 2009 05:18:46 -0400 Received: from song.cn.fujitsu.com (cn.fujitsu.com [222.73.24.84] (may be forged)) by mx3.redhat.com (8.13.8/8.13.8) with ESMTP id n559IW6v029718; Fri, 5 Jun 2009 05:18:33 -0400 Received: from tang.cn.fujitsu.com (tang.cn.fujitsu.com [10.167.250.3]) by song.cn.fujitsu.com (Postfix) with ESMTP id 8CAD6170147; Fri, 5 Jun 2009 17:37:32 +0800 (CST) Received: from fnst.cn.fujitsu.com (localhost.localdomain [127.0.0.1]) by tang.cn.fujitsu.com (8.13.1/8.13.1) with ESMTP id n559Rteu025384; Fri, 5 Jun 2009 17:27:55 +0800 Received: from [127.0.0.1] (unknown [10.167.141.226]) by fnst.cn.fujitsu.com (Postfix) with ESMTPA id 9137ED4032; Fri, 5 Jun 2009 17:17:57 +0800 (CST) Message-ID: <4A28E293.90402@cn.fujitsu.com> Date: Fri, 05 Jun 2009 17:17:07 +0800 From: Gui Jianfeng User-Agent: Thunderbird 2.0.0.5 (Windows/20070716) MIME-Version: 1.0 To: Vivek Goyal References: <1243377729-2176-1-git-send-email-vgoyal@redhat.com> <1243377729-2176-11-git-send-email-vgoyal@redhat.com> In-Reply-To: <1243377729-2176-11-git-send-email-vgoyal@redhat.com> X-RedHat-Spam-Score: -0.696 X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-Scanned-By: MIMEDefang 2.63 on 172.16.48.32 X-loop: dm-devel@redhat.com Cc: dhaval@linux.vnet.ibm.com, snitzer@redhat.com, peterz@infradead.org, dm-devel@redhat.com, dpshah@google.com, jens.axboe@oracle.com, agk@redhat.com, balbir@linux.vnet.ibm.com, paolo.valente@unimore.it, fernando@oss.ntt.co.jp, mikew@google.com, jmoyer@redhat.com, nauman@google.com, m-ikeda@ds.jp.nec.com, lizf@cn.fujitsu.com, fchecconi@gmail.com, akpm@linux-foundation.org, jbaron@redhat.com, linux-kernel@vger.kernel.org, s-uchida@ap.jp.nec.com, righi.andrea@gmail.com, containers@lists.linux-foundation.org Subject: [dm-devel] Re: [PATCH 10/20] io-conroller: Prepare elevator layer for single queue schedulers X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.5 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com Vivek Goyal wrote: > + e->ops->elevator_free_sched_queue_fn(e, > + sched_q); > + sched_q = NULL; > + goto queue_fail; > + } > + } > + > + elv_init_ioq(e, ioq, iog, sched_q, IOPRIO_CLASS_BE, 4, 1); It's better to use IOPRIO_NORM here. Signed-off-by: Gui Jianfeng --- block/elevator-fq.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/block/elevator-fq.c b/block/elevator-fq.c index f1179aa..3c5f9da 100644 --- a/block/elevator-fq.c +++ b/block/elevator-fq.c @@ -2403,7 +2403,8 @@ alloc_ioq: } } - elv_init_ioq(e, ioq, iog, sched_q, IOPRIO_CLASS_BE, 4, 1); + elv_init_ioq(e, ioq, iog, sched_q, IOPRIO_CLASS_BE, + IOPRIO_NORM, 1); io_group_set_ioq(iog, ioq); elv_mark_ioq_sync(ioq); elv_get_iog(iog);