From patchwork Mon Jun 8 07:44:31 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gui Jianfeng X-Patchwork-Id: 28565 Received: from hormel.redhat.com (hormel1.redhat.com [209.132.177.33]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n587kp4R030498 for ; Mon, 8 Jun 2009 07:46:51 GMT Received: from listman.util.phx.redhat.com (listman.util.phx.redhat.com [10.8.4.110]) by hormel.redhat.com (Postfix) with ESMTP id 4F8F761972B; Mon, 8 Jun 2009 03:46:50 -0400 (EDT) Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by listman.util.phx.redhat.com (8.13.1/8.13.1) with ESMTP id n587kjXo000432 for ; Mon, 8 Jun 2009 03:46:45 -0400 Received: from mx3.redhat.com (mx3.redhat.com [172.16.48.32]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n587kdrL014138; Mon, 8 Jun 2009 03:46:39 -0400 Received: from song.cn.fujitsu.com (cn.fujitsu.com [222.73.24.84] (may be forged)) by mx3.redhat.com (8.13.8/8.13.8) with ESMTP id n587k6wh021486; Mon, 8 Jun 2009 03:46:07 -0400 Received: from tang.cn.fujitsu.com (tang.cn.fujitsu.com [10.167.250.3]) by song.cn.fujitsu.com (Postfix) with ESMTP id CBC3A17013B; Mon, 8 Jun 2009 16:07:17 +0800 (CST) Received: from fnst.cn.fujitsu.com (localhost.localdomain [127.0.0.1]) by tang.cn.fujitsu.com (8.13.1/8.13.1) with ESMTP id n587vfqm015068; Mon, 8 Jun 2009 15:57:41 +0800 Received: from [127.0.0.1] (unknown [10.167.141.226]) by fnst.cn.fujitsu.com (Postfix) with ESMTPA id 62D63D4016; Mon, 8 Jun 2009 15:45:48 +0800 (CST) Message-ID: <4A2CC15F.2010708@cn.fujitsu.com> Date: Mon, 08 Jun 2009 15:44:31 +0800 From: Gui Jianfeng User-Agent: Thunderbird 2.0.0.5 (Windows/20070716) MIME-Version: 1.0 To: Vivek Goyal References: <1243377729-2176-1-git-send-email-vgoyal@redhat.com> <1243377729-2176-3-git-send-email-vgoyal@redhat.com> In-Reply-To: <1243377729-2176-3-git-send-email-vgoyal@redhat.com> X-RedHat-Spam-Score: -0.72 X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-Scanned-By: MIMEDefang 2.63 on 172.16.48.32 X-loop: dm-devel@redhat.com Cc: dhaval@linux.vnet.ibm.com, snitzer@redhat.com, peterz@infradead.org, dm-devel@redhat.com, dpshah@google.com, jens.axboe@oracle.com, agk@redhat.com, balbir@linux.vnet.ibm.com, paolo.valente@unimore.it, fernando@oss.ntt.co.jp, mikew@google.com, jmoyer@redhat.com, nauman@google.com, m-ikeda@ds.jp.nec.com, lizf@cn.fujitsu.com, fchecconi@gmail.com, akpm@linux-foundation.org, jbaron@redhat.com, linux-kernel@vger.kernel.org, s-uchida@ap.jp.nec.com, righi.andrea@gmail.com, containers@lists.linux-foundation.org Subject: [dm-devel] Re: [PATCH 02/20] io-controller: Common flat fair queuing code in elevaotor layer X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.5 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com Vivek Goyal wrote: ... > + > +static inline pid_t elv_ioq_pid(struct io_queue *ioq) > +{ > + return ioq->pid; > +} > + > +static inline unsigned long elv_ioq_ttime_mean(struct io_queue *ioq) > +{ > + return ioq->ttime_mean; > +} > + > +static inline unsigned long elv_ioq_sample_valid(struct io_queue *ioq) > +{ > + return ioq_sample_valid(ioq->ttime_samples); > +} > + These three functions are dead now, just remove them. Signed-off-by: Gui Jianfeng --- block/elevator-fq.h | 15 --------------- 1 files changed, 0 insertions(+), 15 deletions(-) diff --git a/block/elevator-fq.h b/block/elevator-fq.h index 24a3af9..b2bb11a 100644 --- a/block/elevator-fq.h +++ b/block/elevator-fq.h @@ -452,21 +452,6 @@ static inline int elv_ioq_nr_queued(struct io_queue *ioq) return ioq->nr_queued; } -static inline pid_t elv_ioq_pid(struct io_queue *ioq) -{ - return ioq->pid; -} - -static inline unsigned long elv_ioq_ttime_mean(struct io_queue *ioq) -{ - return ioq->ttime_mean; -} - -static inline unsigned long elv_ioq_sample_valid(struct io_queue *ioq) -{ - return ioq_sample_valid(ioq->ttime_samples); -} - static inline void elv_get_ioq(struct io_queue *ioq) { atomic_inc(&ioq->ref);