From patchwork Fri Sep 18 01:37:53 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kiyoshi Ueda X-Patchwork-Id: 48439 X-Patchwork-Delegate: christophe.varoqui@free.fr Received: from hormel.redhat.com (hormel1.redhat.com [209.132.177.33]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n8I1hTbn019279 for ; Fri, 18 Sep 2009 01:43:30 GMT Received: from listman.util.phx.redhat.com (listman.util.phx.redhat.com [10.8.4.110]) by hormel.redhat.com (Postfix) with ESMTP id EF57D618920; Thu, 17 Sep 2009 21:43:28 -0400 (EDT) Received: from int-mx02.intmail.prod.int.phx2.redhat.com (nat-pool.util.phx.redhat.com [10.8.5.200]) by listman.util.phx.redhat.com (8.13.1/8.13.1) with ESMTP id n8I1hQZa021544 for ; Thu, 17 Sep 2009 21:43:26 -0400 Received: from mx1.redhat.com (ext-mx09.extmail.prod.ext.phx2.redhat.com [10.5.110.13]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n8I1hQlp012379 for ; Thu, 17 Sep 2009 21:43:26 -0400 Received: from tyo202.gate.nec.co.jp (TYO202.gate.nec.co.jp [202.32.8.206]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8I1hGCU003646 for ; Thu, 17 Sep 2009 21:43:17 -0400 Received: from mailgate3.nec.co.jp ([10.7.69.160]) by tyo202.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id n8I1h60j011101; Fri, 18 Sep 2009 10:43:06 +0900 (JST) Received: (from root@localhost) by mailgate3.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) id n8I1h6804256; Fri, 18 Sep 2009 10:43:06 +0900 (JST) Received: from mail03.kamome.nec.co.jp (mail03.kamome.nec.co.jp [10.25.43.7]) by mailsv.nec.co.jp (8.13.8/8.13.4) with ESMTP id n8I1h54H010810; Fri, 18 Sep 2009 10:43:05 +0900 (JST) Received: from genzui.jp.nec.com ([10.26.220.13] [10.26.220.13]) by mail03.kamome.nec.co.jp with ESMTP id BT-MMP-2053388; Fri, 18 Sep 2009 10:38:22 +0900 Received: from elcondor.linux.bs1.fc.nec.co.jp ([10.34.125.195] [10.34.125.195]) by mail.jp.nec.com with ESMTP; Fri, 18 Sep 2009 10:37:57 +0900 Message-ID: <4AB2E471.9010802@ct.jp.nec.com> Date: Fri, 18 Sep 2009 10:37:53 +0900 From: Kiyoshi Ueda User-Agent: Thunderbird 2.0.0.23 (X11/20090825) MIME-Version: 1.0 To: genanr@emsphone.com Subject: Re: [dm-devel] multipath-tools and queue-length/service-time path selectors oops References: <20090911213435.GA1590@thumper2> <4AADA753.6000205@ct.jp.nec.com> <20090914151251.GA17421@thumper2> <4AAEF795.9060301@ct.jp.nec.com> <20090915143509.GA22993@thumper2> In-Reply-To: <20090915143509.GA22993@thumper2> X-RedHat-Spam-Score: 0 () X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-Scanned-By: MIMEDefang 2.67 on 10.5.110.13 X-loop: dm-devel@redhat.com Cc: device-mapper development X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.5 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com Hi Andy, Sorry for the late reply. On 09/15/2009 11:35 PM +0900, Andy wrote: > Now, I have another question. Why does the queue-length selector not use all > my paths? > > Sep 15 09:25:44 | loop0: device node name blacklisted > Sep 15 09:25:44 | loop1: device node name blacklisted > Sep 15 09:25:44 | params = 0 0 1 1 queue-length 0 4 1 8:64 8 8:144 8 8:224 8 65:48 8 > Sep 15 09:25:44 | status = 2 0 0 0 1 1 A 0 4 1 8:64 A 0 0 8:144 A 0 0 8:224 A 0 0 65:48 A 0 0 > Sep 15 09:25:44 | 8: not found in pathvec > Sep 15 09:25:44 | Invalid device number 8 > Sep 15 09:25:44 | Invalid device number 8 > reload: u02 (350002ac000020246) undef 3PARdata,VV > size=100G features='0' hwhandler='0' wp=undef > `-+- policy='queue-length 0' prio=4 status=undef > |- 1:0:0:3 sde 8:64 active ready running > |- 1:0:1:3 sdj 8:144 active ready running > |- 2:0:0:3 sdo 8:224 undef ready running > `- 2:0:1:3 sdt 65:48 undef ready running > Sep 15 09:25:49 | Invalid device number 8 > Sep 15 09:25:49 | Invalid device number 8 > > > u02 (350002ac000020246) dm-3 3PARdata,VV > size=100G features='0' hwhandler='0' wp=rw > `-+- policy='queue-length 0' prio=2 status=active > |- 1:0:0:3 sde 8:64 active ready running > |- #:#:#:# - #:# active faulty running > |- 1:0:1:3 sdj 8:144 active ready running > `- #:#:#:# - #:# active faulty running Actual device configuration seems to be working fine, but the getting information from the configured device seems to be failing due to table parsing problem in disassemble_map(). (The RHEL5's device-mapper-multipath package works fine. So the problem seems to be introduced during upstream development.) I guess the attached patch works around the problem. Please try it. Please note that this patch may *NOT* be a complete fix. Some more codes for new dynamic load balancers may be needed. By the way, unfortunatelly, I can't work on this next week. I'll look at this more after that. Sorry for the inconvenience. Thanks, Kiyoshi Ueda --- libmultipath/dmparser.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel Index: multipath-tools/libmultipath/dmparser.c =================================================================== --- multipath-tools.orig/libmultipath/dmparser.c +++ multipath-tools/libmultipath/dmparser.c @@ -323,8 +323,10 @@ disassemble_map (vector pathvec, char * def_minio /= pp->priority; FREE(word); - } else + } else { + p += get_word(p, NULL); def_minio = 0; + } if (def_minio != mpp->minio) mpp->minio = def_minio;