From patchwork Sun Oct 6 02:14:50 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akira Hayakawa X-Patchwork-Id: 2992211 X-Patchwork-Delegate: snitzer@redhat.com Return-Path: X-Original-To: patchwork-dm-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B67509F1C3 for ; Sun, 6 Oct 2013 02:18:48 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E3DD42024C for ; Sun, 6 Oct 2013 02:18:47 +0000 (UTC) Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by mail.kernel.org (Postfix) with ESMTP id 1BDB62024A for ; Sun, 6 Oct 2013 02:18:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r962F5fK006017; Sat, 5 Oct 2013 22:15:06 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r962F3c7023765 for ; Sat, 5 Oct 2013 22:15:03 -0400 Received: from mx1.redhat.com (ext-mx16.extmail.prod.ext.phx2.redhat.com [10.5.110.21]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r962F28Q000459; Sat, 5 Oct 2013 22:15:02 -0400 Received: from mail-pa0-f50.google.com (mail-pa0-f50.google.com [209.85.220.50]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r962F1gF002450; Sat, 5 Oct 2013 22:15:01 -0400 Received: by mail-pa0-f50.google.com with SMTP id fb1so5794488pad.37 for ; Sat, 05 Oct 2013 19:15:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=VImMFzA2PhHn/+a6RYAS4s01G1rJ8/X95AARj0AUuH0=; b=bQU/o7z263IowkqmzFinSEiO0QhoIxykxoNQLWaYdiMJ6MJKePLuW/3L0db+OoRmeS nEZCxY6BKa/Wt19qAU/9Lic2nL7U0dPT404wv8UeULAg1CvXQBZL7j5j8FMqWjABpXZs Dw10g7EQy8IA+xZujyWlg6OeiIuvMkSnYOaZjrZJzUw6Gz4ddRQHVJ5CbS7xNScE5vsx eoqyWEqBEjlNAi9WFq1IVTlz2q/OK1ujB+uijVkGAH/wUTv64HkyAdg1FLBOlfELl/n8 6xtz9mNkIFmBORPthvKtCKZRdEV1LLq/KhxVsoaBHF/aqZV0lTKpwO8Si19xFe5MSbWZ aNFQ== X-Received: by 10.66.132.69 with SMTP id os5mr23380433pab.114.1381025700782; Sat, 05 Oct 2013 19:15:00 -0700 (PDT) Received: from Akira-Hayakawas-MacBook-Pro.local (em117-55-65-135.emobile.ad.jp. [117.55.65.135]) by mx.google.com with ESMTPSA id l8sm24023950pbl.22.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 05 Oct 2013 19:15:00 -0700 (PDT) Message-ID: <5250C79A.8060103@gmail.com> Date: Sun, 06 Oct 2013 11:14:50 +0900 From: Akira Hayakawa User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: mpatocka@redhat.com References: <524E27DD.2050809@gmail.com> <524ECFC9.3000603@gmail.com> <524FBA3F.3050409@gmail.com> In-Reply-To: X-RedHat-Spam-Score: -2.1 (BAYES_00, DCC_REPUT_00_12, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, KHOP_BIG_TO_CC, RCVD_IN_DNSWL_LOW, SPF_PASS) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-Scanned-By: MIMEDefang 2.68 on 10.5.110.21 X-loop: dm-devel@redhat.com Cc: devel@driverdev.osuosl.org, thornber@redhat.com, snitzer@redhat.com, gregkh@linuxfoundation.org, david@fromorbit.com, linux-kernel@vger.kernel.org, ruby.wktk@gmail.com, joe@perches.com, dm-devel@redhat.com, agk@redhat.com, tj@kernel.org, akpm@linux-foundation.org, dan.carpenter@oracle.com, ejt@redhat.com, cesarb@cesarb.net, m.chehab@samsung.com Subject: Re: [dm-devel] dm-writeboost testing X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, KHOP_BIG_TO_CC, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Mikulas, > The change seems ok. Please, also move this piece of code in flush_proc > out of the spinlock: > if (kthread_should_stop()) > return 0; > > It caused the workqueue warning I reported before and still causes warning > with kthreads: > note: flush_daemon[5145] exited with preempt_count 1 You are right. I fixed the bug. I will reply to you about this later. So much bugs and some seems to be crucial. Akira --- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel diff --git a/Driver/dm-writeboost-daemon.c b/Driver/dm-writeboost-daemon.c index 65974e2..cf790bf 100644 --- a/Driver/dm-writeboost-daemon.c +++ b/Driver/dm-writeboost-daemon.c @@ -29,7 +29,6 @@ int flush_proc(void *data) cache->flush_wait_queue, (!list_empty(&cache->flush_queue)), msecs_to_jiffies(100)); - spin_lock_irqsave(&cache->flush_queue_lock, flags); /* * flush daemon can exit @@ -37,6 +36,8 @@ int flush_proc(void *data) */ if (kthread_should_stop()) return 0; + else + spin_lock_irqsave(&cache->flush_queue_lock, flags); } > I will send you next email with more bugs that I found in your code