From patchwork Thu Sep 29 09:13:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9357741 X-Patchwork-Delegate: snitzer@redhat.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1E593600C8 for ; Fri, 30 Sep 2016 08:04:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1110729E8F for ; Fri, 30 Sep 2016 08:04:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0596029EAC; Fri, 30 Sep 2016 08:04:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from mx6-phx2.redhat.com (mx6-phx2.redhat.com [209.132.183.39]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 98BB329E8F for ; Fri, 30 Sep 2016 08:04:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx6-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8U82Hs7011577; Fri, 30 Sep 2016 04:02:18 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u8T9DK9b008302 for ; Thu, 29 Sep 2016 05:13:20 -0400 Received: from mx1.redhat.com (ext-mx08.extmail.prod.ext.phx2.redhat.com [10.5.110.32]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8T9DK9G032034 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 29 Sep 2016 05:13:20 -0400 Received: from mout.web.de (mout.web.de [212.227.17.12]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1B3F5C05ACA9; Thu, 29 Sep 2016 09:13:19 +0000 (UTC) Received: from [192.168.1.2] ([78.49.118.68]) by smtp.web.de (mrweb102) with ESMTPSA (Nemesis) id 0MFL6u-1bk3kl32gO-00EQL0; Thu, 29 Sep 2016 11:13:15 +0200 To: dm-devel@redhat.com, linux-raid@vger.kernel.org, Alasdair Kergon , Mike Snitzer , Shaohua Li References: <566ABCD9.1060404@users.sourceforge.net> <080668d9-1e1e-e208-f9ea-ff718e8070e5@users.sourceforge.net> From: SF Markus Elfring Message-ID: <9cb9e644-7d2e-0630-f26b-2143fc82eea6@users.sourceforge.net> Date: Thu, 29 Sep 2016 11:13:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <080668d9-1e1e-e208-f9ea-ff718e8070e5@users.sourceforge.net> X-Provags-ID: V03:K0:VmA48H3REZvherBr2dcu+wn0r1HVVks0jA52NwOhQx/T6m6ZqI2 isT233VsUCzT5C7vecE6E7PtrUMRUJqkezQti6B8U3nVanDTg55w34MAOhXS8OREs+VtKw3 jPdj61Y2t0ShMzBUb2W6i4kXKkkVJXVwH/PRo8gjIp2JnCKekVzOZYf8zWtCvpEvGxNPnPp +xsxx9DDS4yMntlfjTydA== X-UI-Out-Filterresults: notjunk:1; V01:K0:ZQ7qQ0hXGlM=:Vhjoe+fizVi0+ztWIuF3k/ xwyw8kBcjWXCZUMy7OzbTh5QBUiDFM4rCNWTsV1lC2SmWRNq8NXJMRlMQO2BNyWkOM78cB5Dc GqK2VFrKFtw61AF8MYkiu8JuRSLdlQiPEUmYSM3vaQDKI+rFpOlHBjvBHUiKeWGrwneHKgktj zulAmDzvBnQiNw63ISkqRF2Hz6D+9Fn7+S4PKBo+Bl/L4qI4JiElP9Xe6993lJqf96DTjQoyP KgDwZ6tEn5B8+dWLvuetct58J/KwuFB7iC+0PMSRDGCrYYmlD+3Vx/Sn8XpWENbywyJf06Xtt p7L6ZbN7ZhP1cxV3vcvsgTLA5HerIkb07gxZYXIsDUZHhKrI2+dyu/3jFFwefQRxsV24VCBCV C5UMJrAmH3+GAYzw2CAyPB+QILWbe1uERiMDKtr/9q6wZ40wQE7KHWqwt/eQiqpJHBccutyjV f+cRPrwiCDc4iICTqBvCNB2NorwJ3EMRw/F10rq7fkOLlqPGZIwPHENoTiFZ6cNgDRQf7dP7K 9o31SxmJNdhTr4kobhBuV5upkmb8IDzXr7xs4ba27YuLMvPP3EK4V4xJ4E565e+Fd3jpOsvdJ 7cN390/fbpLCPdFpJMv4IotHct09oUZ8w19Y8WMDzymLmtcZzyk401F9YCMig7vpVdSpQU8t3 DKATyusrxmzYU4ppko2QYhYv+M2ShM3EQtixS9hroezRR5Ynv7anltRNTu8F6NJvyv+U8Ef6e z9pi+la5xsaT31Mu6ygGZZ6pNlgNuy86YW+5W7L5k/gKUOBZMYqWWGvRgTnO+lPNkUEBqMVhg voywVhi X-Greylist: Sender IP whitelisted by DNSRBL, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 29 Sep 2016 09:13:19 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 29 Sep 2016 09:13:19 +0000 (UTC) for IP:'212.227.17.12' DOMAIN:'mout.web.de' HELO:'mout.web.de' FROM:'elfring@users.sourceforge.net' RCPT:'' X-RedHat-Spam-Score: 0.079 (BAYES_50, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 212.227.17.12 mout.web.de 212.227.17.12 mout.web.de X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Scanned-By: MIMEDefang 2.78 on 10.5.110.32 X-loop: dm-devel@redhat.com X-Mailman-Approved-At: Fri, 30 Sep 2016 04:02:16 -0400 Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML Subject: [dm-devel] [PATCH 05/10] dm snapshot: Delete unnecessary variable initialisations in pending_complete() X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Thu, 29 Sep 2016 08:25:47 +0200 Three local variables will be set to an appropriate pointer a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/md/dm-snap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/md/dm-snap.c b/drivers/md/dm-snap.c index a6b797f..7bbd3c4 100644 --- a/drivers/md/dm-snap.c +++ b/drivers/md/dm-snap.c @@ -1450,9 +1450,9 @@ static void pending_complete(void *context, int success) struct dm_snap_pending_exception *pe = context; struct dm_exception *e; struct dm_snapshot *s = pe->snap; - struct bio *origin_bios = NULL; - struct bio *snapshot_bios = NULL; - struct bio *full_bio = NULL; + struct bio *origin_bios; + struct bio *snapshot_bios; + struct bio *full_bio; int error = 0; if (!success) {