From patchwork Mon Dec 13 09:07:44 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Chauhan, Vijay" X-Patchwork-Id: 405172 X-Patchwork-Delegate: christophe.varoqui@free.fr Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id oBD9AtSV012722 for ; Mon, 13 Dec 2010 09:11:26 GMT Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id oBD98lMe019314; Mon, 13 Dec 2010 04:08:49 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id oBD98kIj032148 for ; Mon, 13 Dec 2010 04:08:46 -0500 Received: from mx1.redhat.com (ext-mx05.extmail.prod.ext.phx2.redhat.com [10.5.110.9]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oBD98fFG023559 for ; Mon, 13 Dec 2010 04:08:41 -0500 Received: from na3sys009aog106.obsmtp.com (na3sys009aog106.obsmtp.com [74.125.149.77]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oBD98Wcr018375 for ; Mon, 13 Dec 2010 04:08:32 -0500 Received: from source ([192.19.220.66]) (using TLSv1) by na3sys009aob106.postini.com ([74.125.148.12]) with SMTP ID DSNKTQXikO4qU0QE8jBATYRQfnF/+mV7S5/m@postini.com; Mon, 13 Dec 2010 01:08:32 PST Received: from coshub01.lsi.com (135.142.2.64) by COSEDGE01.lsi.com (192.19.220.66) with Microsoft SMTP Server (TLS) id 8.3.106.1; Mon, 13 Dec 2010 02:09:12 -0700 Received: from inbexch01.lsi.com (135.36.98.37) by coshub01.lsi.com (135.142.2.64) with Microsoft SMTP Server (TLS) id 8.2.254.0; Mon, 13 Dec 2010 02:08:55 -0700 Received: from inbmail01.lsi.com ([135.36.98.64]) by inbexch01.lsi.com ([135.36.98.37]) with mapi; Mon, 13 Dec 2010 14:38:51 +0530 From: "Chauhan, Vijay" To: device-mapper development Date: Mon, 13 Dec 2010 14:37:44 +0530 Thread-Topic: [dm-devel] rdac.c patch not quite right. Thread-Index: AcuXtmWpC4HVQxxWQM+bCI1CKUQM7wAABS9AALo3+UA= Message-ID: References: <1291759024.4430.2.camel@zezette> <20101208213936.GB5205@us.ibm.com> <20101209151742.GA25922@us.ibm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 X-RedHat-Spam-Score: -2.301 (RCVD_IN_DNSWL_MED,SPF_PASS) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Scanned-By: MIMEDefang 2.67 on 10.5.110.9 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id oBD98kIj032148 X-loop: dm-devel@redhat.com Subject: Re: [dm-devel] rdac.c patch not quite right. X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Mon, 13 Dec 2010 09:11:26 +0000 (UTC) --- multipath-tools-orig/libmultipath/checkers/rdac.c 2010-12-06 02:59:40.000000000 -0600 +++ multipath-tools/libmultipath/checkers/rdac.c 2010-12-09 10:34:52.000000000 -0600 @@ -107,7 +107,7 @@ libcheck_check (struct checker * c) if (0 != do_inq(c->fd, 0xC9, &inq, sizeof(struct volume_access_inq))) { ret = PATH_DOWN; goto done; - } else if ((inq.PQ_PDT & 0x20) || (inq.PQ_PDT & 0x7f)) { + } else if (((inq.PQ_PDT & 0xE0) == 0x20) || (inq.PQ_PDT == 0x7f)) { /* LUN not connected*/ ret = PATH_DOWN; goto done;