From patchwork Fri Dec 13 22:22:24 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Varoqui X-Patchwork-Id: 3342721 X-Patchwork-Delegate: christophe.varoqui@free.fr Return-Path: X-Original-To: patchwork-dm-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1D750C0D4A for ; Fri, 13 Dec 2013 22:25:56 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D6382200DC for ; Fri, 13 Dec 2013 22:25:54 +0000 (UTC) Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by mail.kernel.org (Postfix) with ESMTP id C140D200DA for ; Fri, 13 Dec 2013 22:25:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rBDMMS7u003406; Fri, 13 Dec 2013 17:22:29 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rBDMMRWK031362 for ; Fri, 13 Dec 2013 17:22:27 -0500 Received: from mx1.redhat.com (ext-mx14.extmail.prod.ext.phx2.redhat.com [10.5.110.19]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBDMMQZU017703 for ; Fri, 13 Dec 2013 17:22:26 -0500 Received: from mail-ie0-f170.google.com (mail-ie0-f170.google.com [209.85.223.170]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBDMMPP2032577 for ; Fri, 13 Dec 2013 17:22:25 -0500 Received: by mail-ie0-f170.google.com with SMTP id qd12so3803480ieb.29 for ; Fri, 13 Dec 2013 14:22:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=/FNGcqroe9xlOlMKx7MCBId37NiVbEMOMS/PiSg52t8=; b=TmVg8yPaB3NX7WK8FQg38QPTTVqnGq3QWQqNH0lgbKe1WOnblyu4e+U89ba0/M4TWa usN5H4Hirh5bbHmDcp0AynqdG8hM2AOLjPhsDIPDJLIugc5ivi66NhMiYH1hkI+HaAuS BRY5Nd1ScHwIciQHKhJLkEssqCnWv1q2aRQ+6VkY0mfdJUq5fcOdbXXjKUVXMWToFasH jAg0TZy2e2r1E09RaR8fW6LEJFkmcXxUiKHfLyt7+Qo7E/d7A4lWJSiJiDXNJh7DIxQE OB0XPhxWyDTJ03i6DBbm89gsiDWJWWwdQ9pOLg+dm03ajaxNX23jNiRq10uvlJSkFVuA ocAw== MIME-Version: 1.0 X-Received: by 10.42.82.196 with SMTP id e4mr3745924icl.58.1386973344458; Fri, 13 Dec 2013 14:22:24 -0800 (PST) Received: by 10.64.228.243 with HTTP; Fri, 13 Dec 2013 14:22:24 -0800 (PST) In-Reply-To: <1386936854-8399-9-git-send-email-hare@suse.de> References: <1386936854-8399-1-git-send-email-hare@suse.de> <1386936854-8399-9-git-send-email-hare@suse.de> Date: Fri, 13 Dec 2013 23:22:24 +0100 X-Google-Sender-Auth: KWDbA0zbEeZJAi5eaDhR62ANbs4 Message-ID: From: Christophe Varoqui To: device-mapper development X-RedHat-Spam-Score: -2.598 (BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_LOW, SPF_PASS, URIBL_BLOCKED) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Scanned-By: MIMEDefang 2.68 on 10.5.110.19 X-loop: dm-devel@redhat.com Subject: Re: [dm-devel] [PATCH 08/11] Reset timezone information on reconfigure X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, HTML_MESSAGE,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hannes, FYI, related to your latest patchset, commit dd205886ed2d41bb8e2602cb9771be403a99cd27 Author: Christophe Varoqui Date: Fri Dec 13 23:20:40 2013 +0100 Add missing includes to support tzget() usage Best regards, Christophe Varoqui On Fri, Dec 13, 2013 at 1:14 PM, Hannes Reinecke wrote: > Whenever 'reconfigure' is called we need to re-initialize the > timezone information as it might have been changed in the > meantime. > > References: bnc#830511 > > Signed-off-by: Hannes Reinecke > --- > libmultipath/log.c | 1 + > multipathd/main.c | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/libmultipath/log.c b/libmultipath/log.c > index 37c7cd7..74702d8 100644 > --- a/libmultipath/log.c > +++ b/libmultipath/log.c > @@ -99,6 +99,7 @@ void log_close (void) > void log_reset (char *program_name) > { > closelog(); > + tzset(); > openlog(program_name, 0, LOG_DAEMON); > } > > diff --git a/multipathd/main.c b/multipathd/main.c > index 96564f8..1a1aa2d 100644 > --- a/multipathd/main.c > +++ b/multipathd/main.c > @@ -1416,6 +1416,9 @@ reconfigure (struct vectors * vecs) > vecs->pathvec = NULL; > conf = NULL; > > + /* Re-read any timezone changes */ > + tzset(); > + > if (!load_config(DEFAULT_CONFIGFILE, udev)) { > conf->verbosity = old->verbosity; > conf->daemon = 1; > -- > 1.8.1.4 > > -- > dm-devel mailing list > dm-devel@redhat.com > https://www.redhat.com/mailman/listinfo/dm-devel > --- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel diff --git a/libmultipath/log.c b/libmultipath/log.c index 74702d8..ab92e2a 100644 --- a/libmultipath/log.c +++ b/libmultipath/log.c @@ -8,6 +8,7 @@ #include #include #include +#include #include "memory.h" #include "log.h" diff --git a/multipathd/main.c b/multipathd/main.c index 37a9bc2..fd70b70 100644 --- a/multipathd/main.c +++ b/multipathd/main.c @@ -22,6 +22,7 @@ #endif #include #include +#include /* * libcheckers