From patchwork Fri Jan 15 20:26:07 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: babu moger X-Patchwork-Id: 73215 X-Patchwork-Delegate: agk@redhat.com Received: from mx01.util.phx2.redhat.com (mx1-phx2.redhat.com [209.132.183.26]) by demeter.kernel.org (8.14.3/8.14.2) with ESMTP id o0FKSerw019946 for ; Fri, 15 Jan 2010 20:28:41 GMT Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx01.util.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o0FKQZEv027132; Fri, 15 Jan 2010 15:26:36 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o0FKQY9h021905 for ; Fri, 15 Jan 2010 15:26:34 -0500 Received: from mx1.redhat.com (ext-mx01.extmail.prod.ext.phx2.redhat.com [10.5.110.5]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o0FKQT82006231; Fri, 15 Jan 2010 15:26:29 -0500 Received: from na3sys009aog113.obsmtp.com (na3sys009aog113.obsmtp.com [74.125.149.209]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0FKQCGd014459; Fri, 15 Jan 2010 15:26:13 -0500 Received: from source ([147.145.40.20]) by na3sys009aob113.postini.com ([74.125.148.12]) with SMTP ID DSNKS1DPZO3YjFZt7EiLnWbRhqIGOsVt8KMc@postini.com; Fri, 15 Jan 2010 12:26:14 PST Received: from milmhbs0.lsil.com (mhbs.lsil.com [147.145.1.30]) by mail0.lsil.com (8.12.11/8.12.11) with ESMTP id o0FKQB0b000961; Fri, 15 Jan 2010 12:26:11 -0800 (PST) Received: from coscas01.lsi.com (coscas01.co.lsil.com [172.21.36.60]) by milmhbs0.lsil.com (8.12.11/8.12.11) with ESMTP id o0FKQFXJ030585; Fri, 15 Jan 2010 12:26:15 -0800 Received: from cosmail01.lsi.com ([172.21.36.24]) by coscas01.lsi.com ([172.21.36.60]) with mapi; Fri, 15 Jan 2010 13:26:10 -0700 From: "Moger, Babu" To: "dm-devel@redhat.com" , "linux-scsi@vger.kernel.org" Date: Fri, 15 Jan 2010 13:26:07 -0700 Thread-Topic: [PATCH][RESUBMIT] dm-mpath: Two minor fixes while processing activate_path Thread-Index: AcqWIPfsMf7hDnelTRWXkElf1F0Wrw== Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-Scanned-By: MIMEDefang 2.67 on 10.5.110.5 X-Scanned-By: MIMEDefang 2.39 X-RedHat-Spam-Score: -2.909 (AWL,RCVD_IN_DNSWL_MED) X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id o0FKQY9h021905 X-loop: dm-devel@redhat.com Cc: Alasdair G Kergon Subject: [dm-devel] [PATCH][RESUBMIT] dm-mpath: Two minor fixes while processing activate_path X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com --- linux-2.6.33-rc2/drivers/md/dm-mpath.c.orig 2010-01-15 15:04:37.000000000 -0400 +++ linux-2.6.33-rc2/drivers/md/dm-mpath.c 2010-01-15 15:11:48.000000000 -0400 @@ -461,6 +461,9 @@ static void process_queued_ios(struct wo m->pg_init_count++; m->pg_init_required = 0; list_for_each_entry(tmp, &pgpath->pg->pgpaths, list) { + /* Skip failed paths */ + if (!tmp->is_active) + continue; if (queue_work(kmpath_handlerd, &tmp->activate_path)) m->pg_init_in_progress++; } @@ -1143,8 +1146,8 @@ static void pg_init_done(void *data, int errors = 0; break; } - DMERR("Cannot failover device because scsi_dh_%s was not " - "loaded.", m->hw_handler_name); + DMERR("Could not failover the device, Handler scsi_dh_%s " + "Error %d.", m->hw_handler_name, errors); /* * Fail path for now, so we do not ping pong */