From patchwork Thu Sep 29 09:15:26 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9357759 X-Patchwork-Delegate: snitzer@redhat.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A67D1600C8 for ; Fri, 30 Sep 2016 08:05:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9811128F77 for ; Fri, 30 Sep 2016 08:05:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8C32C29EB1; Fri, 30 Sep 2016 08:05:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from mx5-phx2.redhat.com (mx5-phx2.redhat.com [209.132.183.37]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2E10228F77 for ; Fri, 30 Sep 2016 08:05:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx5-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8U82ucA004165; Fri, 30 Sep 2016 04:02:56 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u8T9FUYr008408 for ; Thu, 29 Sep 2016 05:15:30 -0400 Received: from mx1.redhat.com (ext-mx01.extmail.prod.ext.phx2.redhat.com [10.5.110.25]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8T9FUJf006963 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 29 Sep 2016 05:15:30 -0400 Received: from mout.web.de (mout.web.de [212.227.17.11]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9C225A0CCC; Thu, 29 Sep 2016 09:15:28 +0000 (UTC) Received: from [192.168.1.2] ([78.49.118.68]) by smtp.web.de (mrweb102) with ESMTPSA (Nemesis) id 0MZUWH-1bUqBf3Dg5-00LBZU; Thu, 29 Sep 2016 11:15:26 +0200 To: dm-devel@redhat.com, linux-raid@vger.kernel.org, Alasdair Kergon , Mike Snitzer , Shaohua Li References: <566ABCD9.1060404@users.sourceforge.net> <080668d9-1e1e-e208-f9ea-ff718e8070e5@users.sourceforge.net> From: SF Markus Elfring Message-ID: Date: Thu, 29 Sep 2016 11:15:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <080668d9-1e1e-e208-f9ea-ff718e8070e5@users.sourceforge.net> X-Provags-ID: V03:K0:XzSUtmpaf5gJSecRcYmFiP63YZj1fSFwJKctdpGEfGt71nXOHB9 MVfmg6jMHHX6R7Wj255Lu2GA1tRATzuix0Co+d2bSmaL8wl7jsyUyLQkWk1xbIZq3EEdPLY oiMgHXc40C/xW0gTGdn3Swtu32Ckom5h6G2jUW+Ddp1ZLoT4aQZU+Byts5RDV5OT52U8Pgl hR2USHKCN+N3kyyXr2Acw== X-UI-Out-Filterresults: notjunk:1; V01:K0:JIVWAOAF7kE=:Wma9h1/F1WVWi1DvWu2hvn Ye9lt3lKfTYc4xRmFVv9P5KtxUA1D68JNDGgL71GQMOXY+K14Al5Um8VJfH+9Z2EnYYatl+OJ 9Ouv0GXQUfVH8BgTgtnoCYoIXpUGsWKSjgax5rNsqcGVME8bfys0QdWhh3nobT/SPXLzNBwOa 8GG1A1UVi2nwkOmsKalfkQrg6T5hublAevmgUQF2uybf7TLObUtxAXUxhcbjmFiiBl3vNC1qm O2cGE5mYCAolwaq6FqxzkghBJmNqWZa6bHiHNC5eB7QvOywcOQVVOEAYzmeH1AoEeLc/y56hP mfFVsPixgU8lWRc3ahyBm3HzPfy96FJfUVFINGHyg8YXTUdkXVZB7q9uR7C59/pPBokE6OHmy pXxg1ThjZFysJwEhIO5Y2Npkgg1t6TR0VEMs8Tqn4hxcuyuznVjCAfqX1qHBFDFN6WDAmUUSo Xv6X49P60oVsayaUrYxQjIs+AqzP4jhh25U0gmQcd4DHpdZGTlEuV79vIP3EJzowRrQ4FiYGT RFVNoDGFtpjBk+dwSTX0XcoedxvaocKoOZpJHKMLMaOxLZCsbxFaKjN20OcxSspKBaj4j6lkQ 0qd9+Kn6mCFDvifRuMevBZ20z+Q+rZq+9sfJ1kHGevTaLHuEJ6QZ1XextePvu9AYd/eY8wN3m nGQdR+gE6KXJ25kOQAPddThrqctnwxa2a8/rNx0aP4Nr7O687VYFD3NoB6IP33gyBFruF2+l8 0aDz8mrzyJkZIf1K10V6HmEZW5F3KwVhbDSo2Y8yuqk6wYyrH7eRyiUVA9CrVJT6hK8jH+76i t3bBTp5 X-Greylist: Sender IP whitelisted by DNSRBL, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 29 Sep 2016 09:15:29 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 29 Sep 2016 09:15:29 +0000 (UTC) for IP:'212.227.17.11' DOMAIN:'mout.web.de' HELO:'mout.web.de' FROM:'elfring@users.sourceforge.net' RCPT:'' X-RedHat-Spam-Score: 0.079 (BAYES_50, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 212.227.17.11 mout.web.de 212.227.17.11 mout.web.de X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Scanned-By: MIMEDefang 2.78 on 10.5.110.25 X-loop: dm-devel@redhat.com X-Mailman-Approved-At: Fri, 30 Sep 2016 04:02:16 -0400 Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML Subject: [dm-devel] [PATCH 07/10] dm snapshot: Delete an unnecessary variable initialisation in merge_callback() X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Thu, 29 Sep 2016 09:00:06 +0200 The local variable "b" will be set to an appropriate pointer a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/md/dm-snap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-snap.c b/drivers/md/dm-snap.c index 06b1b69..1d90131 100644 --- a/drivers/md/dm-snap.c +++ b/drivers/md/dm-snap.c @@ -1046,7 +1046,7 @@ static void error_bios(struct bio *bio); static void merge_callback(int read_err, unsigned long write_err, void *context) { struct dm_snapshot *s = context; - struct bio *b = NULL; + struct bio *b; if (read_err || write_err) { if (read_err)