From patchwork Sat Oct 1 07:48:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9360091 X-Patchwork-Delegate: snitzer@redhat.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 94014601C0 for ; Mon, 3 Oct 2016 07:13:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7DA1B289A3 for ; Mon, 3 Oct 2016 07:13:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 72706289B3; Mon, 3 Oct 2016 07:13:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C5AF3289A3 for ; Mon, 3 Oct 2016 07:13:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u937BTrI005897; Mon, 3 Oct 2016 03:11:29 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u917ms8r024890 for ; Sat, 1 Oct 2016 03:48:54 -0400 Received: from mx1.redhat.com (ext-mx07.extmail.prod.ext.phx2.redhat.com [10.5.110.31]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u917msJl014953 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 1 Oct 2016 03:48:54 -0400 Received: from mout.web.de (mout.web.de [217.72.192.78]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 09E78C0B2A3E; Sat, 1 Oct 2016 07:48:53 +0000 (UTC) Received: from [192.168.1.3] ([92.228.150.161]) by smtp.web.de (mrweb101) with ESMTPSA (Nemesis) id 0LuuFh-1aqPEx36en-0103LW; Sat, 01 Oct 2016 09:48:50 +0200 To: dm-devel@redhat.com, linux-raid@vger.kernel.org, Alasdair Kergon , Mike Snitzer , Shaohua Li References: <45984567-4421-5f8d-ddf3-eb2a769a1860@users.sourceforge.net> From: SF Markus Elfring Message-ID: Date: Sat, 1 Oct 2016 09:48:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <45984567-4421-5f8d-ddf3-eb2a769a1860@users.sourceforge.net> X-Provags-ID: V03:K0:CoHRVvI4EF9dw6f12bwmvjMEpNfPaTFqZcvgpFb1Bp8FTbJj4W0 Bq1AURCadzU0HzRYoE2pFyAohj2eyFWpkP6cxlnl6a/K2iaRYJhsHMHLIJ/SF297YcpdrKP aPHmf5eUTJAl8XnZwAH5lLrzhyvJSKaHf30zYQPfq7hiKpuhtQVKNrqpPBlZ7NPhkk+ABv7 FPVuzyEKUQzSXY5pyu/6g== X-UI-Out-Filterresults: notjunk:1; V01:K0:r6qXaHfkGME=:Yj2E+wJZGibZDfFXtZa2dW dtDShReBVDScoEjc1SfUxjE6I924GxZVsCAczxB1bNQ/pvHWNagqOYnw1zrf988hg5MkBFyO2 lOmvoeQJnCNquQciZRyKNZt5l1dBvU1JXJDQqvLieMWu/lAodPHtRpmTc8DGk0AKVTB8v6hq3 XoV9sD1au1SOOu5FW5Pr6R2a3JjYQhNCLuTZYJkgGcupsfeStl3xuiSEoljNLPrlTWZQCcLCf dhK63h0GBuYCSlOitxlg+BnIbHMUEEvExQMsKXTCO+/DjMR3OnYV5UG2S4cMDxAiRbq09J+k/ eK0DTZ1agzON9yMC1s+SWv/RfAl1g5BkWt0lL+l+xC9ueyNYgDE30gXasHCTwK96BAe7ZfLEr 64gSBquTHCWBj2voeVKapKjp9Pd+Glbfm7pjppBQh/numc9OIYV2PCacX9nzz8lmTGShVv9dM 0G5ZG5N71uSQhchKe4UjGrW5xjbhJ8dVhg/CRqpZIijs2CvnopVOB7KwkLFDJxs+xE4jzrJ2S 5G8Nn4cIHrqluZkI4sL4umMCu0m0ncpULXr0JvrhnkaIzXOKGEQruaeLnA0jbGq9zYApb/dRX FXNvLWyIaYGjVnuwO5mJRgXiKPQ3bAkZ9EM4qouroKBZOzB6+G49mI1g2zE7vj/Li9to96Qux TxV3uKGneZVYfXoP9pTyeJOzUwd4S3LKbYcC/CrxAsRQv9OoV2NKwB/Gbwn0JYNXkqWV55I16 KZPrm+9HXWSFx/FpER98Y23N+JIDKg+tgrHT7m+fFHUqE+yNe+vxlNx01dz8YhzCq8eqMR9az 25gJS4Q X-Greylist: Sender IP whitelisted by DNSRBL, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Sat, 01 Oct 2016 07:48:53 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Sat, 01 Oct 2016 07:48:53 +0000 (UTC) for IP:'217.72.192.78' DOMAIN:'mout.web.de' HELO:'mout.web.de' FROM:'elfring@users.sourceforge.net' RCPT:'' X-RedHat-Spam-Score: 0.079 (BAYES_50, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 217.72.192.78 mout.web.de 217.72.192.78 mout.web.de X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Scanned-By: MIMEDefang 2.78 on 10.5.110.31 X-loop: dm-devel@redhat.com X-Mailman-Approved-At: Mon, 03 Oct 2016 03:10:51 -0400 Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML Subject: [dm-devel] [PATCH 6/9] md/dm-table: Combine substrings for ten messages X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Sat, 1 Oct 2016 08:39:58 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: quoted string split across lines Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/md/dm-table.c | 32 ++++++++++---------------------- 1 file changed, 10 insertions(+), 22 deletions(-) diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c index 0f60417..9b7d8b7 100644 --- a/drivers/md/dm-table.c +++ b/drivers/md/dm-table.c @@ -296,8 +296,7 @@ static int device_area_is_invalid(struct dm_target *ti, struct dm_dev *dev, */ q = bdev_get_queue(bdev); if (!q || !q->make_request_fn) { - DMWARN("%s: %s is not yet initialised: " - "start=%llu, len=%llu, dev_size=%llu", + DMWARN("%s: %s is not yet initialised: start=%llu, len=%llu, dev_size=%llu", dm_device_name(ti->table->md), bdevname(bdev, b), (unsigned long long)start, (unsigned long long)len, @@ -309,8 +308,7 @@ static int device_area_is_invalid(struct dm_target *ti, struct dm_dev *dev, return 0; if ((start >= dev_size) || (start + len > dev_size)) { - DMWARN("%s: %s too small for target: " - "start=%llu, len=%llu, dev_size=%llu", + DMWARN("%s: %s too small for target: start=%llu, len=%llu, dev_size=%llu", dm_device_name(ti->table->md), bdevname(bdev, b), (unsigned long long)start, (unsigned long long)len, @@ -322,8 +320,7 @@ static int device_area_is_invalid(struct dm_target *ti, struct dm_dev *dev, return 0; if (start & (logical_block_size_sectors - 1)) { - DMWARN("%s: start=%llu not aligned to h/w " - "logical block size %u of %s", + DMWARN("%s: start=%llu not aligned to h/w logical block size %u of %s", dm_device_name(ti->table->md), (unsigned long long)start, limits->logical_block_size, bdevname(bdev, b)); @@ -331,8 +328,7 @@ static int device_area_is_invalid(struct dm_target *ti, struct dm_dev *dev, } if (len & (logical_block_size_sectors - 1)) { - DMWARN("%s: len=%llu not aligned to h/w " - "logical block size %u of %s", + DMWARN("%s: len=%llu not aligned to h/w logical block size %u of %s", dm_device_name(ti->table->md), (unsigned long long)len, limits->logical_block_size, bdevname(bdev, b)); @@ -446,9 +442,7 @@ static int dm_set_device_limits(struct dm_target *ti, struct dm_dev *dev, } if (bdev_stack_limits(limits, bdev, start) < 0) - DMWARN("%s: adding target device %s caused an alignment inconsistency: " - "physical_block_size=%u, logical_block_size=%u, " - "alignment_offset=%u, start=%llu", + DMWARN("%s: adding target device %s caused an alignment inconsistency: physical_block_size=%u, logical_block_size=%u, alignment_offset=%u, start=%llu", dm_device_name(ti->table->md), bdevname(bdev, b), q->limits.physical_block_size, q->limits.logical_block_size, @@ -659,8 +653,7 @@ static int validate_hardware_logical_block_alignment(struct dm_table *table, } if (remaining) { - DMWARN("%s: table line %u (start sect %llu len %llu) " - "not aligned to h/w logical block size %u", + DMWARN("%s: table line %u (start sect %llu len %llu) not aligned to h/w logical block size %u", dm_device_name(table->md), i, (unsigned long long) ti->begin, (unsigned long long) ti->len, @@ -902,8 +895,7 @@ static int dm_table_determine_type(struct dm_table *t) bio_based = 1; if (bio_based && request_based) { - DMWARN("Inconsistent table: different target types" - " can't be mixed up"); + DMWARN("Inconsistent table: different target types can't be mixed up"); return -EINVAL; } } @@ -960,8 +952,7 @@ static int dm_table_determine_type(struct dm_table *t) struct request_queue *q = bdev_get_queue(dd->dm_dev->bdev); if (!blk_queue_stackable(q)) { - DMERR("table load rejected: including" - " non-request-stackable devices"); + DMERR("table load rejected: including non-request-stackable devices"); return -EINVAL; } @@ -973,8 +964,7 @@ static int dm_table_determine_type(struct dm_table *t) /* verify _all_ devices in the table are blk-mq devices */ list_for_each_entry(dd, devices, list) if (!bdev_get_queue(dd->dm_dev->bdev)->mq_ops) { - DMERR("table load rejected: not all devices" - " are blk-mq request-stackable"); + DMERR("table load rejected: not all devices are blk-mq request-stackable"); return -EINVAL; } @@ -1374,9 +1364,7 @@ int dm_calculate_queue_limits(struct dm_table *table, * for the table. */ if (blk_stack_limits(limits, &ti_limits, 0) < 0) - DMWARN("%s: adding target device " - "(start sect %llu len %llu) " - "caused an alignment inconsistency", + DMWARN("%s: adding target device (start sect %llu len %llu) caused an alignment inconsistency", dm_device_name(table->md), (unsigned long long) ti->begin, (unsigned long long) ti->len);