From patchwork Thu Sep 29 09:16:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9357749 X-Patchwork-Delegate: snitzer@redhat.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 462E9600C8 for ; Fri, 30 Sep 2016 08:05:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3897428F77 for ; Fri, 30 Sep 2016 08:05:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2BD0C29EB1; Fri, 30 Sep 2016 08:05:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from mx6-phx2.redhat.com (mx6-phx2.redhat.com [209.132.183.39]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C981E28F77 for ; Fri, 30 Sep 2016 08:05:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx6-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8U82won011624; Fri, 30 Sep 2016 04:02:58 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u8T9GMdm008752 for ; Thu, 29 Sep 2016 05:16:22 -0400 Received: from mx1.redhat.com (ext-mx01.extmail.prod.ext.phx2.redhat.com [10.5.110.25]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8T9GMET010949 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 29 Sep 2016 05:16:22 -0400 Received: from mout.web.de (mout.web.de [212.227.17.12]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 74891923BE; Thu, 29 Sep 2016 09:16:20 +0000 (UTC) Received: from [192.168.1.2] ([78.49.118.68]) by smtp.web.de (mrweb102) with ESMTPSA (Nemesis) id 0Le4Po-1b8W3q1YgG-00ppyM; Thu, 29 Sep 2016 11:16:18 +0200 To: dm-devel@redhat.com, linux-raid@vger.kernel.org, Alasdair Kergon , Mike Snitzer , Shaohua Li References: <566ABCD9.1060404@users.sourceforge.net> <080668d9-1e1e-e208-f9ea-ff718e8070e5@users.sourceforge.net> From: SF Markus Elfring Message-ID: Date: Thu, 29 Sep 2016 11:16:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <080668d9-1e1e-e208-f9ea-ff718e8070e5@users.sourceforge.net> X-Provags-ID: V03:K0:GdhwLLIddV98R3vumt3Gctk3wvLNrkXYUG2ZL4TzDTEdx1b/iSu GDaEzYhDjwZI4sKqsmBToxPK1SLQuz5w0Hu36c8CJu0J6rqxE2IvGMhOdR6MUhtlTz6pxN0 hozq9caOFnIuXlhmQTcFjqX8AbVnlr/ntAY1iiEKnIzO2ccsG/lNiKoG3FFcGjPky63AbHS 7G/XOvQ4T4Petf+hZ4Jbw== X-UI-Out-Filterresults: notjunk:1; V01:K0:aHIqk0GV2DU=:+BE0HxQc7heaLsLTEghGHe fmj/5jWKVuDRhc7e4z7NBy3v9WzxFn3DMLU9tdQRVM/Q+NOSVpKfc4KUM22n1CFJsjbj3ciNW rq6sqJx7Bsze91sxeqIABn2Vw9U4/I8+Hu3T3TerA4t8WhSxNTzR+Da0oEJEey9WSUeH5OaLm X5RGVOqrZ+VGb20bFob2GTFjNhKyCn4jt+nZ375vtyLFwSqNSvP67o4Y75CHYESbTh4qKE+ez 6uUpb3h96emQUOIdsXFrst2RKbgKT74MTuiquDcj2KYPFv86NQ9ydlpbB0kI7JfuG6BDkS2rl Mzn0vQn2xSNKC3iDPkI6zTFbywnhd7Bftm9CaYItYeG6wr+P2gZDiuXRcHdyCqpwIkt6sonUD GNTfJeLS42Ys1+hwnE+gGvd6A7qft30FOU90+WGRfOH0LkSLGM5IpPeb7WBVweMGN+kf4k389 5pq+tGfqrFiRRm2pXWiLQl/wFbBHiJRTh+JeCA3czNqf39jhQZ7NsG/RvGmjfZqUu+T4kDgBF rU6BKyl2gzPn5xrf2LURwBZPVXWJqTczUjJxiN+D1hYUiMe5mBMBQdUn+vq9R0mpKUi1yArmt Oun71aZTsYLcmTW+19g+4tb5cD71a+DdGkZPpP5xfss26fv+sfboOFwlLI6A5G1Z2rFalE9Kb ekwOK/+KyQuW3lcqIeMntqreIr/6BZsIniAgd/mQRBUgr9q03qNvbhG41RYS+MJTyXATExj9U yR6ha9tJxdcxY0v1BP3SY+W43hhUAyDIW3+LHwcc8bRR6QKBVSLM7m0fuAg7FvKrxRgkHoEqn EPdhmZl X-Greylist: Sender IP whitelisted by DNSRBL, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 29 Sep 2016 09:16:21 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 29 Sep 2016 09:16:21 +0000 (UTC) for IP:'212.227.17.12' DOMAIN:'mout.web.de' HELO:'mout.web.de' FROM:'elfring@users.sourceforge.net' RCPT:'' X-RedHat-Spam-Score: 0.079 (BAYES_50, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 212.227.17.12 mout.web.de 212.227.17.12 mout.web.de X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Scanned-By: MIMEDefang 2.78 on 10.5.110.25 X-loop: dm-devel@redhat.com X-Mailman-Approved-At: Fri, 30 Sep 2016 04:02:16 -0400 Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML Subject: [dm-devel] [PATCH 08/10] dm snapshot: Delete an unnecessary variable initialisation in remove_single_exception_chunk() X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Thu, 29 Sep 2016 09:06:37 +0200 The local variable "b" will be set to an appropriate pointer a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/md/dm-snap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-snap.c b/drivers/md/dm-snap.c index 1d90131..4966584 100644 --- a/drivers/md/dm-snap.c +++ b/drivers/md/dm-snap.c @@ -904,7 +904,7 @@ static void flush_bios(struct bio *bio); static int remove_single_exception_chunk(struct dm_snapshot *s) { - struct bio *b = NULL; + struct bio *b; int r; chunk_t old_chunk = s->first_merging_chunk + s->num_merging_chunks - 1;