From patchwork Sat Oct 1 07:43:18 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9360099 X-Patchwork-Delegate: snitzer@redhat.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 00AC7601C0 for ; Mon, 3 Oct 2016 07:14:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DFB2D289A2 for ; Mon, 3 Oct 2016 07:13:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D49C9289B2; Mon, 3 Oct 2016 07:13:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from mx5-phx2.redhat.com (mx5-phx2.redhat.com [209.132.183.37]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C4476289A2 for ; Mon, 3 Oct 2016 07:13:58 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx5-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u937BQw3032554; Mon, 3 Oct 2016 03:11:26 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u917hTuY024414 for ; Sat, 1 Oct 2016 03:43:29 -0400 Received: from mx1.redhat.com (ext-mx03.extmail.prod.ext.phx2.redhat.com [10.5.110.27]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u917hTu1019671 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 1 Oct 2016 03:43:29 -0400 Received: from mout.web.de (mout.web.de [212.227.17.11]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DE190B040C; Sat, 1 Oct 2016 07:43:27 +0000 (UTC) Received: from [192.168.1.3] ([92.228.150.161]) by smtp.web.de (mrweb102) with ESMTPSA (Nemesis) id 0MSJGB-1bMhsm0br1-00TT4T; Sat, 01 Oct 2016 09:43:23 +0200 To: dm-devel@redhat.com, linux-raid@vger.kernel.org, Alasdair Kergon , Mike Snitzer , Shaohua Li References: <45984567-4421-5f8d-ddf3-eb2a769a1860@users.sourceforge.net> From: SF Markus Elfring Message-ID: Date: Sat, 1 Oct 2016 09:43:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <45984567-4421-5f8d-ddf3-eb2a769a1860@users.sourceforge.net> X-Provags-ID: V03:K0:ZXplqlNmebKd/p9bWXQ8W6CnE9zXXr0BPhB1AfJHDIyKYNRrNEj EkD6L2QFoN6lOilYquQ5IPpYYKmtDma8q7VHJuSSUDKgFlsZvvl4Ypbl2XtLbO8PJ3nkxUe YzUl0WJ2f6hnDZGF+6D2QZFvUBbEvDkWmf5SGa+UFEwDqn05QIrrv2ZjWx/B2rgmwxQ251w d9nRazGNxErkppoKoRglA== X-UI-Out-Filterresults: notjunk:1; V01:K0:IqwfYoCFx8c=:RB51fO7LHMpdEkWKchxCVY cYTPxMgCtcNSLN3GeEbrKY74eiaG87NFf41DJcvNpOIebwBUAyqjS4dgpMg2rOC49VCfE+JCB oQHV5iV5xt/DsUazYMQFWnYMu5JX+lnnvEgiAbmaBIrp+NiL5cjVuLQ6wvylo2nY0QlPDJLte +RiR47N1f68LJvuNWZKq5Yf2TZn/WQsyPgyCCTkBXFvfglpn/6U8kSYQ4PwWrdzfDqPBN0WpO HcWB9rxaaT0aXb6wtjsQVL6615O5jv8mK3J+WCrTuKPrIAzUyKgOvYBNiU89J7UIcL2n5JVe1 VPg416XGsMRCbsC0CqhCR7EBNebg+ctCgWMF5UC8rXORQuxi+7h5N7uU950Ktr8WsM97wRzWb 22+86yxZ2rqNOxWrP+x9ffyxbN/buDIN7ppjqFZyVwGLn4XE9cKSGl4xEn7os7nm+4yYcO0PT IqaQI7x8s4wpWQ3VXDXdChCfYir/6x44ta8vMYlfzANBWykA/zmhvob8P/CfYvHP5i66lBAZZ /337i6UyH6NP1jfi/o8s8gQVX6IWWVlMVfhlw9hbn5jcNqGJ7lSL3GJBn8a90U35QWI4XP303 KwIV2tP6W4QUZm70ZS2lXYjesdUa9N17POSUi1bcmZj7Z4Ux6NhJQaLwBk74aBwKVTtZnAznY lgUYFqMS9DR+6jlUhuchQWyQUoUq6IUKR9EgxgFSzmEE10Z18HqbMZQ/XJkEXHtCehm3yigSr gpwkrCIvWZ4k+BW1Yt69vcWGRCs+vU1FYUexeA8HeAy4UgW6EOwh0xnJxgGAEtPhjw8ifouDJ 2xtWtJR X-Greylist: Sender IP whitelisted by DNSRBL, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Sat, 01 Oct 2016 07:43:28 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Sat, 01 Oct 2016 07:43:28 +0000 (UTC) for IP:'212.227.17.11' DOMAIN:'mout.web.de' HELO:'mout.web.de' FROM:'elfring@users.sourceforge.net' RCPT:'' X-RedHat-Spam-Score: 0.079 (BAYES_50, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 212.227.17.11 mout.web.de 212.227.17.11 mout.web.de X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Scanned-By: MIMEDefang 2.78 on 10.5.110.27 X-loop: dm-devel@redhat.com X-Mailman-Approved-At: Mon, 03 Oct 2016 03:10:51 -0400 Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML Subject: [dm-devel] [PATCH 1/9] md/dm-table: Use kmalloc_array() in realloc_argv() X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Sat, 1 Oct 2016 06:47:16 +0200 A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/md/dm-table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c index 3e407a9..f6b817c 100644 --- a/drivers/md/dm-table.c +++ b/drivers/md/dm-table.c @@ -523,7 +523,7 @@ static char **realloc_argv(unsigned *array_size, char **old_argv) new_size = 8; gfp = GFP_NOIO; } - argv = kmalloc(new_size * sizeof(*argv), gfp); + argv = kmalloc_array(new_size, sizeof(*argv), gfp); if (argv) { memcpy(argv, old_argv, *array_size * sizeof(*argv)); *array_size = new_size;