| Message ID | 1532605933-26209-1-git-send-email-ray.huang@amd.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/ttm: move non-x86 definitions to the common header | expand |
On Thu, Jul 26, 2018 at 1:52 PM, Huang Rui <ray.huang@amd.com> wrote: > Hi, > > As suggested by Christian, we should move non-x86 definitions into one common > header, and it will make the codes readable. They are based on the improvement > fix of Bas (already rebase Bas's patch to drm-next). > > Changes from V1 -> V2: > - add ttm_ prefix at this header. > - use set_pages_wb instead of set_memory_wb. Thanks! For the series Reviewed-by: Bas Nieuwenhuizen <basni@chromium.org> > > Thanks, > Ray > > Bas Nieuwenhuizen (1): > drm/ttm: Merge hugepage attr changes in ttm_dma_page_put. (v2) > > Huang Rui (3): > drm/ttm: add ttm_set_memory header (v2) > drm/ttm: clean up non-x86 definitions on ttm_page_alloc_dma > drm/ttm: clean up non-x86 definitions on ttm_page_alloc > > drivers/gpu/drm/ttm/ttm_page_alloc.c | 62 ++------------- > drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 57 ++------------ > include/drm/ttm/ttm_set_memory.h | 128 +++++++++++++++++++++++++++++++ > 3 files changed, 140 insertions(+), 107 deletions(-) > create mode 100644 include/drm/ttm/ttm_set_memory.h > > -- > 2.7.4 >
Am 26.07.2018 um 13:59 schrieb Bas Nieuwenhuizen: > On Thu, Jul 26, 2018 at 1:52 PM, Huang Rui <ray.huang@amd.com> wrote: >> Hi, >> >> As suggested by Christian, we should move non-x86 definitions into one common >> header, and it will make the codes readable. They are based on the improvement >> fix of Bas (already rebase Bas's patch to drm-next). >> >> Changes from V1 -> V2: >> - add ttm_ prefix at this header. >> - use set_pages_wb instead of set_memory_wb. > Thanks! For the series Agreed, really nice cleanup. > Reviewed-by: Bas Nieuwenhuizen <basni@chromium.org> Reviewed-by: Christian König <christian.koenig@amd.com> as well. Regards, Christian. >> Thanks, >> Ray >> >> Bas Nieuwenhuizen (1): >> drm/ttm: Merge hugepage attr changes in ttm_dma_page_put. (v2) >> >> Huang Rui (3): >> drm/ttm: add ttm_set_memory header (v2) >> drm/ttm: clean up non-x86 definitions on ttm_page_alloc_dma >> drm/ttm: clean up non-x86 definitions on ttm_page_alloc >> >> drivers/gpu/drm/ttm/ttm_page_alloc.c | 62 ++------------- >> drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 57 ++------------ >> include/drm/ttm/ttm_set_memory.h | 128 +++++++++++++++++++++++++++++++ >> 3 files changed, 140 insertions(+), 107 deletions(-) >> create mode 100644 include/drm/ttm/ttm_set_memory.h >> >> -- >> 2.7.4 >>
On Thu, Jul 26, 2018 at 08:12:05PM +0800, Koenig, Christian wrote: > Am 26.07.2018 um 13:59 schrieb Bas Nieuwenhuizen: > > On Thu, Jul 26, 2018 at 1:52 PM, Huang Rui <ray.huang@amd.com> wrote: > >> Hi, > >> > >> As suggested by Christian, we should move non-x86 definitions into one common > >> header, and it will make the codes readable. They are based on the improvement > >> fix of Bas (already rebase Bas's patch to drm-next). > >> > >> Changes from V1 -> V2: > >> - add ttm_ prefix at this header. > >> - use set_pages_wb instead of set_memory_wb. > > Thanks! For the series > > Agreed, really nice cleanup. > > > Reviewed-by: Bas Nieuwenhuizen <basni@chromium.org> > > Reviewed-by: Christian König <christian.koenig@amd.com> as well. > Thank you, guys. :-) Already applied them. Ray > Regards, > Christian. > > >> Thanks, > >> Ray > >> > >> Bas Nieuwenhuizen (1): > >> drm/ttm: Merge hugepage attr changes in ttm_dma_page_put. (v2) > >> > >> Huang Rui (3): > >> drm/ttm: add ttm_set_memory header (v2) > >> drm/ttm: clean up non-x86 definitions on ttm_page_alloc_dma > >> drm/ttm: clean up non-x86 definitions on ttm_page_alloc > >> > >> drivers/gpu/drm/ttm/ttm_page_alloc.c | 62 ++------------- > >> drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 57 ++------------ > >> include/drm/ttm/ttm_set_memory.h | 128 +++++++++++++++++++++++++++++++ > >> 3 files changed, 140 insertions(+), 107 deletions(-) > >> create mode 100644 include/drm/ttm/ttm_set_memory.h > >> > >> -- > >> 2.7.4 > >> >