From patchwork Tue Aug 7 17:22:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dmitry Osipenko X-Patchwork-Id: 10563443 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 641A613B4 for ; Sat, 11 Aug 2018 12:07:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3F7E02A2B8 for ; Sat, 11 Aug 2018 12:07:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3385B2A529; Sat, 11 Aug 2018 12:07:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E143C2A2B8 for ; Sat, 11 Aug 2018 12:07:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 595D46E208; Sat, 11 Aug 2018 12:05:18 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id A4E0C89E63 for ; Tue, 7 Aug 2018 18:06:53 +0000 (UTC) Received: by mail-lj1-x244.google.com with SMTP id r13-v6so14152305ljg.10 for ; Tue, 07 Aug 2018 11:06:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=caz4zpbrhsxCxjAXbBjsvCQXOktRb8UQQ+3be1uVpjc=; b=Px1ddeUJHsG2uqI0krnzJtY2T2r3FJKbw+hQD2gG7guGjSzVNC4ywTdd7d91Z3DMFW MgeIEwSU1/uZHTkosDsgT1zdLUdSJ6yyjBpMmA0bbA1Pg2zuv3074X1Z5Fs+twnobTUR moUMZgq7JErCjiTGdMaanhA/kYml1B+EGmuNzBgVIgBLRKbLSHn0hg7aPT5Tjp2UjA9A 4lYqG1Lo40eqyqErRqJA4gJGKYeu7JB/An6hj80g1I0tA/D6pWg5b8T/QDkZ1ur+Z6Kf wVLy117SkQN9hWtbN1z/phV4qot+jg5CpN6ax7W8o/3u1ZidcdY5L28eko8fbK/QrG7E NiRQ== X-Gm-Message-State: AOUpUlGUfmk7ZoYrZ4Lm+dXVyAsFb4934w+ln/1N1c4YI7uW2a1YXpnQ 3OPRAkuGUK/8oj5ST0rx9ww= X-Google-Smtp-Source: AAOMgpfEA0mUAxOFcB38VEMnQJbZI1mAQelo+md7vkx5c8jbAGMprbDb9jWEpUatTGmpahjqSZgzNQ== X-Received: by 2002:a2e:458b:: with SMTP id s133-v6mr15947986lja.151.1533665212116; Tue, 07 Aug 2018 11:06:52 -0700 (PDT) Received: from localhost.localdomain ([109.252.90.13]) by smtp.gmail.com with ESMTPSA id h4-v6sm375922lfj.69.2018.08.07.11.06.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Aug 2018 11:06:51 -0700 (PDT) From: Dmitry Osipenko To: Laurent Pinchart , =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= , Thierry Reding , Neil Armstrong , Maxime Ripard , dri-devel@lists.freedesktop.org, Paul Kocialkowski , Russell King , Maarten Lankhorst Subject: [RFC PATCH v4 0/2] drm: Add generic colorkey plane properties Date: Tue, 7 Aug 2018 20:22:00 +0300 Message-Id: <20180807172202.1961-1-digetx@gmail.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 X-Mailman-Approved-At: Sat, 11 Aug 2018 12:05:12 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Hellstrom , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Ben Skeggs , Rodrigo Vivi , linux-tegra@vger.kernel.org, linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Changes in v4: 1) In response to Ville's Syrjälä review comments: - Added new "colorkey.plane_mask" property that specifies which planes shall participate in color key matching operation. - Added short glossary-comment to drm_plane_create_colorkey_properties() that clarifies 'destination' / 'source' plane terms. - Returned "colorkey.mask" property that was dropped from v3, looks like masking is quite common among different HW and hence makes more sense to have that property by default instead of having additional color keying modes. - Changed the color keying mode name to "transparent". 2) In response to Maarten's Lankhorst review comments: - Added a drm_colorkey_extract_component() helper which is supposed to commonize color key component value extraction code among DRM drivers. 3) In response to Russell's King review comments: - The doc-comment to drm_plane_create_colorkey_properties() now explicitly states that "The converted value shall be *rounded up* to the nearest value". Hence userspace now knows what to expect when plane has a 1bpp format. Please review, thanks. v3: https://lists.freedesktop.org/archives/dri-devel/2018-June/179057.html v2: https://lists.freedesktop.org/archives/dri-devel/2018-May/178408.html v1: https://lists.freedesktop.org/archives/dri-devel/2017-December/160510.html Dmitry Osipenko (1): drm/tegra: plane: Add generic colorkey properties for older Tegra's Laurent Pinchart (1): drm: Add generic colorkey properties for display planes drivers/gpu/drm/drm_atomic.c | 20 +++++ drivers/gpu/drm/drm_blend.c | 150 ++++++++++++++++++++++++++++++++ drivers/gpu/drm/tegra/dc.c | 25 ++++++ drivers/gpu/drm/tegra/dc.h | 7 ++ drivers/gpu/drm/tegra/plane.c | 156 ++++++++++++++++++++++++++++++++++ include/drm/drm_blend.h | 3 + include/drm/drm_plane.h | 91 ++++++++++++++++++++ 7 files changed, 452 insertions(+)