From patchwork Fri Oct 5 09:26:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru-Cosmin Gheorghe X-Patchwork-Id: 10627693 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 852D015A6 for ; Fri, 5 Oct 2018 09:26:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6DEC62923A for ; Fri, 5 Oct 2018 09:26:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6135C2923F; Fri, 5 Oct 2018 09:26:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id EB4232923A for ; Fri, 5 Oct 2018 09:26:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3E4416E0B9; Fri, 5 Oct 2018 09:26:48 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80058.outbound.protection.outlook.com [40.107.8.58]) by gabe.freedesktop.org (Postfix) with ESMTPS id 62F026E0B9 for ; Fri, 5 Oct 2018 09:26:46 +0000 (UTC) Received: from DB6PR0802MB2551.eurprd08.prod.outlook.com (10.172.251.149) by DB6PR0802MB2197.eurprd08.prod.outlook.com (10.172.227.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1185.22; Fri, 5 Oct 2018 09:26:43 +0000 Received: from DB6PR0802MB2551.eurprd08.prod.outlook.com ([fe80::647d:f29a:a6d3:c8f2]) by DB6PR0802MB2551.eurprd08.prod.outlook.com ([fe80::647d:f29a:a6d3:c8f2%12]) with mapi id 15.20.1207.022; Fri, 5 Oct 2018 09:26:43 +0000 From: Alexandru-Cosmin Gheorghe To: "seanpaul@chromium.org" , "airlied@linux.ie" , "dri-devel@lists.freedesktop.org" , Liviu Dudau , Brian Starkey , "malidp@foss.arm.com" , "gustavo@padovan.org" , "maarten.lankhorst@linux.intel.com" , Ayan Halder , "daniel.vetter@ffwll.ch" , Raymond Smith , David Garbett , Lisa Wu , Matt Szczesiak , Charles Xu , "james qian wang (Arm Technology China)" Subject: [PATCH v3 0/6] Add method to describe tile/bit_level_packed formats Thread-Topic: [PATCH v3 0/6] Add method to describe tile/bit_level_packed formats Thread-Index: AQHUXI2HQLlNU/qvb0ecvJKtVE5h1A== Date: Fri, 5 Oct 2018 09:26:43 +0000 Message-ID: <20181005092606.21100-1-alexandru-cosmin.gheorghe@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1P195CA0039.EURP195.PROD.OUTLOOK.COM (2603:10a6:802:5a::28) To DB6PR0802MB2551.eurprd08.prod.outlook.com (2603:10a6:4:a1::21) x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [217.140.106.51] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB6PR0802MB2197; 6:ik3r0NaG3WkwiVVt2WIPjZ9K5oO4TnVbHKYwoABnkp6H78iGw3PlcKvyD6E142hdJYr6cQaiPhslbzOeeb33f01Kd203kxKsmS2B8B4pzGhF4zKqlUdqDK2seFsdadT1nDnaggm7ulpaKoZqFYYSnexmArE6dZMMe5aBPalhCasfz6Hb65OPK5Uj05XrPY4qTYoY8th+DN64t/4RYcpnuwDKsIDpIwHOoM3Br8nmkd/pGq420ZBjk2mQAj08duBa5I1TimcmDXghjFqlUvZMWJLojHoxg0a62QQHaYiVdwIySGo44EFtfyJz0wo7Xz5DykDZLSAd9+RUfBp7mI8VmUNfBc0T7X/Ips/QU+ct124Ba9NcBqM4Ll2bVPDtDpFcY3ziOHCJqpRThrQcbifSbxyEpDJysQDB6q2OSRTaC1I+cGOx8c4LHaxdrDAUHodUVa9BBdfANGHXaTG7oMpB4w==; 5:w8QyWs8rRki2zP4AcLE19DFoeO2WwaBcYBAFPMuB1Zc+da4U5QJUtMRwQyIda6o/ic6rNcf6QSHShIGwRaiBE8cvEGeTDcKrEZrIRXuMCx4DuUQci2hm50aS617hfIJeVGgyDy3HSDu2MdIrbF3T+PHNKuSV7wilnkTSHmhgRNc=; 7:eTiJYuqMXEcfZwPz6+Y4Q1Ms13ZFukIkCqUqWDvzRbd9De4w8WHP9+8TsgJkd83Ec3+1q72xOOBnojL2AaVxLV6kcqZiGwrSkti12iA8N9BcLGyjBcFuTFDSzhO7agmFSb0RM3qQE+0+4Jg1WeB1uk8tGYBlcmS/yvO+kw776t34iNctkoNdoWVtdyJTppD+juOeXKP0LKgn9BF0ZWRUKYiWJs8YoPpFaDDTBlpPpF5sImvjMiUPYrFgyvAJ0VM0 x-ms-office365-filtering-correlation-id: 273bda5f-c177-4ced-ad73-08d62aa4a97b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB6PR0802MB2197; x-ms-traffictypediagnostic: DB6PR0802MB2197: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(217544274631240); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231355)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(149066)(150057)(6041310)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(201708071742011)(7699051); SRVR:DB6PR0802MB2197; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0802MB2197; x-forefront-prvs: 0816F1D86E x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(366004)(346002)(396003)(39860400002)(376002)(189003)(199004)(72206003)(68736007)(8676002)(26005)(36756003)(14454004)(256004)(186003)(71190400001)(486006)(71200400001)(5660300001)(2616005)(6636002)(2900100001)(105586002)(106356001)(66066001)(305945005)(6506007)(7736002)(102836004)(8936002)(52116002)(81166006)(476003)(99286004)(386003)(110136005)(316002)(54906003)(2201001)(4326008)(5250100002)(6436002)(81156014)(6486002)(2906002)(25786009)(86362001)(1076002)(53936002)(2501003)(6116002)(3846002)(966005)(97736004)(478600001)(6306002)(6512007)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0802MB2197; H:DB6PR0802MB2551.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: S+8wQsshGAaMJj3lTQCOTMtp0zVG90ehb+RSTvck3OEGHOlTWe/CnYkxrAOXhRh8I4HpDbKT5XQQlHovJXVWtM+HYbaOsXI4C0Byv9gW/r0r/nEaDGevYIrugU86R1O2JEH3lwIktXeSWmXKakynA4i+T8vU9EQlbH77VS4EdKTKwYeqR3HdFkJikJmrMY43+SqleFIfLOrQikEsycyo2a6K+pJYDAxzyoXbvA6yprG74jlZI6dp59KFJmFekROf/UEYH6jT2DDa6zQuD1r91bGdiJ49w+wge4CwudCQgm9an+XKnB/RtoU8YXv7Xcws9aW2eQrPb32cQGNmNhWSxqzKiNV+dFPu5pnALcELUNc= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 273bda5f-c177-4ced-ad73-08d62aa4a97b X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Oct 2018 09:26:43.7601 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2197 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nd , Alexandru-Cosmin Gheorghe Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP There has been some discussion about extending drm core to handle linear tile formats, in the series sent by me here [1] and how to handle formats that are intended to be used just with modifiers(particularly AFBC modifiers) on Brian series [2] and on IRC here [3] and [4]. Hence, this big-merged series: Patches 1-3: handle tiled formats both in core and in malidp driver, this is done by extending drm_format_info with three new fields char_per_block, block_w, block_h and consistently handle in the generic code paths, both linear tiled formats and normal formats. What's different from [1] is the interpretation of pitch for tile formats which has been kept to be the same as for the other formats: pitch = average_chars_per_pixel * width. Patches 4-6: Introduce the YUV AFBC formats, the only thing noteworthy here is that cpp/char_per_block are set to 0 for formats where it's mandatory to be used together with a non-linear modifier and then that is used to bypass pitch check in framebuffer_check for formats that have cpp/char_per_block set to 0. [1] https://lists.freedesktop.org/archives/dri-devel/2018-September/188245.html [2] https://lists.freedesktop.org/archives/dri-devel/2018-September/189620.html [3] https://people.freedesktop.org/~cbrill/dri-log/?channel=dri-devel&highlight_names=&date=2018-09-13&show_html=true [4] https://people.freedesktop.org/~cbrill/dri-log/?channel=dri-devel&highlight_names=&date=2018-09-14&show_html=true Alexandru Gheorghe (4): drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info drm/fourcc: Add fourcc for Mali linear tiled formats drm: mali-dp: Enable Mali-DP tiled buffer formats drm: Extend framebuffer_check to handle formats with cpp/char_per_block 0 Brian Starkey (2): drm/fourcc: Add AFBC yuv fourccs for Mali drm/afbc: Add AFBC modifier usage documentation Documentation/gpu/afbc.rst | 233 +++++++++++++++++++ Documentation/gpu/drivers.rst | 1 + MAINTAINERS | 1 + drivers/gpu/drm/arm/malidp_hw.c | 14 +- drivers/gpu/drm/arm/malidp_planes.c | 23 +- drivers/gpu/drm/drm_fb_cma_helper.c | 21 +- drivers/gpu/drm/drm_fb_helper.c | 6 + drivers/gpu/drm/drm_fourcc.c | 65 ++++++ drivers/gpu/drm/drm_framebuffer.c | 13 +- drivers/gpu/drm/drm_gem_framebuffer_helper.c | 4 +- include/drm/drm_fourcc.h | 29 ++- include/uapi/drm/drm_fourcc.h | 31 +++ 12 files changed, 428 insertions(+), 13 deletions(-) create mode 100644 Documentation/gpu/afbc.rst