From patchwork Thu Oct 25 12:45:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Boris Brezillon X-Patchwork-Id: 10655765 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AAEEE14BB for ; Thu, 25 Oct 2018 12:46:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9B74E2B886 for ; Thu, 25 Oct 2018 12:46:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8F07E2B887; Thu, 25 Oct 2018 12:46:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0D7142B888 for ; Thu, 25 Oct 2018 12:46:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8B28C6E007; Thu, 25 Oct 2018 12:46:18 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 444296E007 for ; Thu, 25 Oct 2018 12:46:15 +0000 (UTC) Received: by mail.bootlin.com (Postfix, from userid 110) id D0C36208BE; Thu, 25 Oct 2018 14:46:13 +0200 (CEST) Received: from localhost.localdomain (aaubervilliers-681-1-12-210.w90-88.abo.wanadoo.fr [90.88.133.210]) by mail.bootlin.com (Postfix) with ESMTPSA id A40AA208EB; Thu, 25 Oct 2018 14:45:47 +0200 (CEST) From: Boris Brezillon To: Eric Anholt , Daniel Vetter Subject: [PATCH v2 0/3] drm/vc4: Add a load tracker Date: Thu, 25 Oct 2018 14:45:43 +0200 Message-Id: <20181025124546.22145-1-boris.brezillon@bootlin.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , dri-devel@lists.freedesktop.org MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Hello, This is the 2nd version of the VC4 load tracker patch. Daniel, as you suggested, I've implemented a generic infrastructure to track and report underrun errors (patch 1). Not sure this is what you had in mind, but it seems to do the job for my use case, and should allow me to easily track regressions in the load tracking logic with a bunch of IGT tests. Let me know if you want it done differently. Patch 2 is implementing the generic underrun interface in the VC4 driver, and patch 3 is just adding the load tracking logic (hasn't changed since the RFC except for the unused 'ret' var removal). Regards, Boris Boris Brezillon (3): drm/atomic: Add a generic infrastructure to track underrun errors drm/vc4: Report underrun errors drm/vc4: Add a load tracker to prevent HVS underflow errors drivers/gpu/drm/drm_atomic.c | 12 +++ drivers/gpu/drm/drm_atomic_helper.c | 4 + drivers/gpu/drm/vc4/vc4_drv.c | 1 + drivers/gpu/drm/vc4/vc4_drv.h | 14 ++++ drivers/gpu/drm/vc4/vc4_hvs.c | 71 ++++++++++++++++++ drivers/gpu/drm/vc4/vc4_kms.c | 110 +++++++++++++++++++++++++++- drivers/gpu/drm/vc4/vc4_plane.c | 60 +++++++++++++++ drivers/gpu/drm/vc4/vc4_regs.h | 46 +++--------- include/drm/drm_atomic_helper.h | 53 ++++++++++++++ include/drm/drm_device.h | 15 ++++ include/drm/drm_mode_config.h | 26 +++++++ 11 files changed, 376 insertions(+), 36 deletions(-) Tested-by: Paul Kocialkowski