mbox series

[v4,0/5] vc4/hdmi: Support TV margin props

Message ID 20181206142439.10441-1-boris.brezillon@bootlin.com (mailing list archive)
Headers show
Series vc4/hdmi: Support TV margin props | expand

Message

Boris Brezillon Dec. 6, 2018, 2:24 p.m. UTC
Hello,

As suggested by Ville, this version uses the already available TV
margin props to define left/right/top/bottom margins insted of adding
new underscan props.

This works pretty well for what we want to do in VC4: allow one to
define the visible area on a TV.

The first 2 patches are fixing the existing doc, patch 3 is allowing
one to create and attach TV margins independently of the TV connector
props. Finally, patch 4 and 5 add support for those props to the VC4
driver.

Regards,

Boris 

Boris Brezillon (5):
  drm/connector: Fix drm_mode_create_tv_properties() doc
  drm/connector: Clarify the unit of TV margins
  drm/connector: Allow creation of margin props alone
  drm/vc4: Take margin setup into account when updating planes
  drm/vc4: Attach margin props to the HDMI connector

 drivers/gpu/drm/drm_connector.c | 83 +++++++++++++++++++++++++--------
 drivers/gpu/drm/vc4/vc4_crtc.c  | 43 +++++++++++++++++
 drivers/gpu/drm/vc4/vc4_drv.h   |  3 ++
 drivers/gpu/drm/vc4/vc4_hdmi.c  | 16 +++++++
 drivers/gpu/drm/vc4/vc4_plane.c | 50 ++++++++++++++++++++
 include/drm/drm_connector.h     |  4 +-
 include/drm/drm_mode_config.h   |  8 ++--
 7 files changed, 183 insertions(+), 24 deletions(-)

Comments

Eric Anholt Dec. 6, 2018, 7:04 p.m. UTC | #1
Boris Brezillon <boris.brezillon@bootlin.com> writes:

> Hello,
>
> As suggested by Ville, this version uses the already available TV
> margin props to define left/right/top/bottom margins insted of adding
> new underscan props.
>
> This works pretty well for what we want to do in VC4: allow one to
> define the visible area on a TV.
>
> The first 2 patches are fixing the existing doc, patch 3 is allowing
> one to create and attach TV margins independently of the TV connector
> props. Finally, patch 4 and 5 add support for those props to the VC4
> driver.

This series is:

Reviewed-by: Eric Anholt <eric@anholt.net>
Boris Brezillon Dec. 19, 2018, 1:51 p.m. UTC | #2
On Thu,  6 Dec 2018 15:24:34 +0100
Boris Brezillon <boris.brezillon@bootlin.com> wrote:

> Hello,
> 
> As suggested by Ville, this version uses the already available TV
> margin props to define left/right/top/bottom margins insted of adding
> new underscan props.
> 
> This works pretty well for what we want to do in VC4: allow one to
> define the visible area on a TV.
> 
> The first 2 patches are fixing the existing doc, patch 3 is allowing
> one to create and attach TV margins independently of the TV connector
> props. Finally, patch 4 and 5 add support for those props to the VC4
> driver.
> 
> Regards,
> 
> Boris 
> 
> Boris Brezillon (5):
>   drm/connector: Fix drm_mode_create_tv_properties() doc
>   drm/connector: Clarify the unit of TV margins
>   drm/connector: Allow creation of margin props alone
>   drm/vc4: Take margin setup into account when updating planes
>   drm/vc4: Attach margin props to the HDMI connector

Queued to drm-misc-next after collecting R-b/A-b.

> 
>  drivers/gpu/drm/drm_connector.c | 83 +++++++++++++++++++++++++--------
>  drivers/gpu/drm/vc4/vc4_crtc.c  | 43 +++++++++++++++++
>  drivers/gpu/drm/vc4/vc4_drv.h   |  3 ++
>  drivers/gpu/drm/vc4/vc4_hdmi.c  | 16 +++++++
>  drivers/gpu/drm/vc4/vc4_plane.c | 50 ++++++++++++++++++++
>  include/drm/drm_connector.h     |  4 +-
>  include/drm/drm_mode_config.h   |  8 ++--
>  7 files changed, 183 insertions(+), 24 deletions(-)
>