[00/11] drm/tinydrm: Remove tinydrm_device

Message

Noralf Trønnes Jan. 20, 2019, 11:43 a.m. UTC

This patchset is part of the effort to remove tinydrm.ko. It removes
struct tinydrm_device and tinydrm.h.

While doing this refactoring I have ensured that device unplug is
working.

The generic fbdev emulation has now been verified that it properly
handles device unplug with open file handles and bound fbcon.

Noralf.

Noralf Trønnes (11):
  drm: Add devm_drm_dev_init/register
  drm/modes: Add DRM_SIMPLE_MODE()
  drm/simple-kms-helper: Add drm_simple_connector_create()
  drm/tinydrm: Remove tinydrm_display_pipe_init()
  drm/tinydrm/mipi-dbi: Add drm_to_mipi_dbi()
  drm/tinydrm: Remove tinydrm_shutdown()
  drm/tinydrm/repaper: Use devm_drm_dev_*()
  drm/tinydrm: Use devm_drm_dev_*()
  drm/tinydrm: Remove tinydrm_device
  drm/tinydrm: Use drm_dev_enter/exit()
  drm/fb-helper: generic: Don't take module ref for fbcon

 Documentation/driver-model/devres.txt         |   4 +
 Documentation/gpu/tinydrm.rst                 |  29 +--
 Documentation/gpu/todo.rst                    |   4 -
 drivers/gpu/drm/drm_drv.c                     | 106 ++++++++++
 drivers/gpu/drm/drm_fb_helper.c               |   6 +-
 drivers/gpu/drm/drm_simple_kms_helper.c       | 122 ++++++++++++
 drivers/gpu/drm/tinydrm/core/Makefile         |   2 +-
 drivers/gpu/drm/tinydrm/core/tinydrm-core.c   | 183 ------------------
 .../gpu/drm/tinydrm/core/tinydrm-helpers.c    |   2 +
 drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c   | 183 ------------------
 drivers/gpu/drm/tinydrm/hx8357d.c             |  44 +++--
 drivers/gpu/drm/tinydrm/ili9225.c             |  67 +++++--
 drivers/gpu/drm/tinydrm/ili9341.c             |  44 +++--
 drivers/gpu/drm/tinydrm/mi0283qt.c            |  52 +++--
 drivers/gpu/drm/tinydrm/mipi-dbi.c            | 133 +++++++++----
 drivers/gpu/drm/tinydrm/repaper.c             | 129 ++++++++----
 drivers/gpu/drm/tinydrm/st7586.c              | 133 +++++++------
 drivers/gpu/drm/tinydrm/st7735r.c             |  44 +++--
 include/drm/drm_drv.h                         |   6 +
 include/drm/drm_modes.h                       |  16 ++
 include/drm/drm_simple_kms_helper.h           |   6 +
 include/drm/tinydrm/mipi-dbi.h                |  27 ++-
 include/drm/tinydrm/tinydrm.h                 |  75 -------
 23 files changed, 715 insertions(+), 702 deletions(-)
 delete mode 100644 drivers/gpu/drm/tinydrm/core/tinydrm-core.c
 delete mode 100644 drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c
 delete mode 100644 include/drm/tinydrm/tinydrm.h

Comments

Sam Ravnborg Jan. 21, 2019, 8:34 a.m. UTC | #1

Hi Noralf.

On Sun, Jan 20, 2019 at 12:43:07PM +0100, Noralf Trønnes wrote:
> This patchset is part of the effort to remove tinydrm.ko. It removes
> struct tinydrm_device and tinydrm.h.
> 
> While doing this refactoring I have ensured that device unplug is
> working.

Very nice series, it looks good the way the core get a little extra
functionality thus the tinydrm drivers are now more normal drivers.

A few comments for some patches, and those where I felt confident
that I could follow the code got a "Reviewed-by:".

	Sam

Noralf Trønnes Jan. 21, 2019, 1:20 p.m. UTC | #2

Den 21.01.2019 09.34, skrev Sam Ravnborg:
> Hi Noralf.
> 
> On Sun, Jan 20, 2019 at 12:43:07PM +0100, Noralf Trønnes wrote:
>> This patchset is part of the effort to remove tinydrm.ko. It removes
>> struct tinydrm_device and tinydrm.h.
>>
>> While doing this refactoring I have ensured that device unplug is
>> working.
> 
> Very nice series, it looks good the way the core get a little extra
> functionality thus the tinydrm drivers are now more normal drivers.

Yes, I'm happy to see these drivers act more like normal drivers now.
Daniel wasn't happy about the tinydrm midlayer so I'm glad it's going away.

> 
> A few comments for some patches, and those where I felt confident
> that I could follow the code got a "Reviewed-by:".

Thanks for going through the patches.

Noralf.